public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jiong Wang <jiong.wang@arm.com>
To: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: [PATCH/AArch64] Fix testcase glitch for linux target
Date: Thu, 10 Jul 2014 08:16:00 -0000	[thread overview]
Message-ID: <53BE4BD2.2070201@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

the testcase for previous --emit-relocs issue was written & tested for bare-metal,
while for linux target, the start address will include "SIZEOF_HEADERS"

   . = SEGMENT_START("text-segment", 0x400000) + SIZEOF_HEADERS;

should specify -T relocs.ld in the testcase to be consistent will all other emit-relocs* testcases

ok for trunk?

thanks

ld/testsuite/

   * ld-aarch64/emit-relocs-local-addend.d: Use target linker script.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-test.patch --]
[-- Type: text/x-patch; name=fix-test.patch, Size: 1711 bytes --]

diff --git a/ld/testsuite/ld-aarch64/emit-relocs-local-addend.d b/ld/testsuite/ld-aarch64/emit-relocs-local-addend.d
index 1739e64..9d652c2 100644
--- a/ld/testsuite/ld-aarch64/emit-relocs-local-addend.d
+++ b/ld/testsuite/ld-aarch64/emit-relocs-local-addend.d
@@ -1,16 +1,16 @@
 #source: emit-relocs-local-addend-foo.s
 #source: emit-relocs-local-addend-bar.s
-#ld: -e0 --emit-relocs
+#ld: -T relocs.ld -e0 --emit-relocs
 #readelf: -r

 Relocation section '\.rela\.text' at offset 0x102f8 contains 4 entries:
   Offset          Info           Type           Sym\. Value    Sym\. Name \+ Addend
-000000400000  000200000113 R_AARCH64_ADR_PRE 0000000000400018 \.rodata \+ 0
-000000400004  000200000115 R_AARCH64_ADD_ABS 0000000000400018 \.rodata \+ 0
-00000040000c  000200000113 R_AARCH64_ADR_PRE 0000000000400018 \.rodata \+ 10
-000000400010  000200000115 R_AARCH64_ADD_ABS 0000000000400018 \.rodata \+ 10
+000000010000  000200000113 R_AARCH64_ADR_PRE 0000000000010018 \.rodata \+ 0
+000000010004  000200000115 R_AARCH64_ADD_ABS 0000000000010018 \.rodata \+ 0
+00000001000c  000200000113 R_AARCH64_ADR_PRE 0000000000010018 \.rodata \+ 10
+000000010010  000200000115 R_AARCH64_ADD_ABS 0000000000010018 \.rodata \+ 10

 Relocation section '\.rela\.rodata' at offset 0x10358 contains 2 entries:
   Offset          Info           Type           Sym\. Value    Sym. Name \+ Addend
-000000400020  000200000101 R_AARCH64_ABS64   0000000000400018 \.rodata \+ 0
-000000400030  000200000101 R_AARCH64_ABS64   0000000000400018 \.rodata \+ 10
+000000010020  000200000101 R_AARCH64_ABS64   0000000000010018 \.rodata \+ 0
+000000010030  000200000101 R_AARCH64_ABS64   0000000000010018 \.rodata \+ 10

             reply	other threads:[~2014-07-10  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  8:16 Jiong Wang [this message]
2014-07-15  9:04 ` Nicholas Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BE4BD2.2070201@arm.com \
    --to=jiong.wang@arm.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).