public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Don't complain about dbCC to long branch conversion
@ 2014-07-14 19:11 Andreas Schwab
  2014-07-15  7:56 ` Nicholas Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2014-07-14 19:11 UTC (permalink / raw)
  To: binutils

When the m68k assembler sees a dbCC insn that jumps to an address
outside of the 16 bit range it converts it to a sequence using a long
branch.  This is still pc-relative code, so don't complain with --pcrel.

Andreas.

	* config/tc-m68k.c (md_convert_frag_1): Don't complain with
	--pcrel about TAB (DBCCLBR, LONG) conversion.

diff --git a/gas/config/tc-m68k.c b/gas/config/tc-m68k.c
index 2005cd2..56db083 100644
--- a/gas/config/tc-m68k.c
+++ b/gas/config/tc-m68k.c
@@ -5166,10 +5166,6 @@ md_convert_frag_1 (fragS *fragP)
       /* Only DBcc instructions can come here.
 	 Change dbcc into dbcc/bral.
 	 JF: these used to be fr_opcode[2-7], but that's wrong.  */
-      if (flag_keep_pcrel)
-    	as_bad_where (fragP->fr_file, fragP->fr_line,
-		  _("Conversion of DBcc to absolute jump"));
-
       *buffer_address++ = 0x00;	/* Branch offset = 4.  */
       *buffer_address++ = 0x04;
       *buffer_address++ = 0x60;	/* Put in bra pc+6.  */
-- 
2.0.1

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Don't complain about dbCC to long branch conversion
  2014-07-14 19:11 [PATCH] Don't complain about dbCC to long branch conversion Andreas Schwab
@ 2014-07-15  7:56 ` Nicholas Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Clifton @ 2014-07-15  7:56 UTC (permalink / raw)
  To: Andreas Schwab, binutils

Hi Andreas,

> 	* config/tc-m68k.c (md_convert_frag_1): Don't complain with
> 	--pcrel about TAB (DBCCLBR, LONG) conversion.

Approved - please apply.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-15  7:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-14 19:11 [PATCH] Don't complain about dbCC to long branch conversion Andreas Schwab
2014-07-15  7:56 ` Nicholas Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).