From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30440 invoked by alias); 20 Jul 2014 14:03:40 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 30415 invoked by uid 89); 20 Jul 2014 14:03:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pa0-f43.google.com Received: from mail-pa0-f43.google.com (HELO mail-pa0-f43.google.com) (209.85.220.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 20 Jul 2014 14:03:37 +0000 Received: by mail-pa0-f43.google.com with SMTP id lf10so8229156pab.30 for ; Sun, 20 Jul 2014 07:03:35 -0700 (PDT) X-Received: by 10.66.241.39 with SMTP id wf7mr18634526pac.58.1405865015751; Sun, 20 Jul 2014 07:03:35 -0700 (PDT) Received: from [192.168.1.101] ([223.72.65.126]) by mx.google.com with ESMTPSA id nm14sm15229448pdb.54.2014.07.20.07.03.34 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 20 Jul 2014 07:03:35 -0700 (PDT) Message-ID: <53CBCC2F.7040702@gmail.com> Date: Sun, 20 Jul 2014 14:03:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: eager@eagercon.com CC: binutils@sourceware.org, gdb-patches@sourceware.org Subject: [PATCH] gdb/microblaze-tdep.c: Check whether less than zero in conditional expression Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00170.txt.bz2 Use typecast 'size_t' on 'reg', not only avoid the related warning, but also check whether less than zero -- for 'reg' is type 'int', and sizeof (dwarf2_to_reg_map) is less than 0x7fff. It is quoted in gdb_assert(), so need check 'reg' whether less than zero. And the related warning (with '-W'): ../../binutils-gdb/gdb/microblaze-tdep.c:667:3: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ChangeLog: * microblaze-tdep.c (microblaze_dwarf2_reg_to_regnum): Check whether less tha zero in conditional expression. Signed-off-by: Chen Gang --- gdb/microblaze-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c index 7e89241..9bec260 100644 --- a/gdb/microblaze-tdep.c +++ b/gdb/microblaze-tdep.c @@ -664,7 +664,7 @@ static int dwarf2_to_reg_map[78] = static int microblaze_dwarf2_reg_to_regnum (struct gdbarch *gdbarch, int reg) { - gdb_assert (reg < sizeof (dwarf2_to_reg_map)); + gdb_assert ((size_t) reg < sizeof (dwarf2_to_reg_map)); return dwarf2_to_reg_map[reg]; } -- 1.7.11.7