From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060.outbound.protection.outlook.com [40.107.249.60]) by sourceware.org (Postfix) with ESMTPS id 03A3F3858CDB for ; Thu, 20 Jul 2023 10:37:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03A3F3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKeaBNBRdTlGPqQQCDIyUPrLdp8hxqh5CF54WfJj0bolAZUldzMbVphXXpujDgW0QFgFx4GaRkjfvP6dSdz/ARGUvAUKV847ClxUcPXJg7HIzMMBofMaytu7CjDgCHZrPKKTyJg+/+uK7hKBjuCaz4eDYh1PG1nH4VaZsPHocN5sXPErRJKOSz5YlpYlxYa0t4MhSZGq1Crrb+6/aUOvbQl8HLWKyJbxp8/xsqKgrzF96JF0zOZ+pmrnUypADRU7cDyXc4TrMxUCZyW2B0Ge3DbMJ6wdV4w/0F/OrCcc9abk6R/ZTvFnE3X5aMjb+4ue/X0k13XiHUBUuaKfU8+9Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+JCOvYMD1ZRr9ybQPJ0v2i970glQ3QD9jcWTjpZwcg=; b=ZDMGEnAKQEluSzHrhtskSwYjl0MlV7l1oR5fKGubS3n8/NueaSLGjemXQzfSamPGnavM7Cap4ovRl04GQk8aLuqZW1PrzPuUNHvhNBbnKv221PMCkq2qKdxDiUDAgm1OmdLCe094j7JeU7hmTysXWD+cMnIQX0dSztRyH/H4U90ypglLFSEsImaGC5RgeDHFa/r7bQ9pcw21YEug4/CbO0n8QO3aUodIynrxoX1ztMG7X3tJHJPPrlvsTxWXQkMgyCiRzX/X6n0e2lsnasmdoyqoVcUl1oso2oJl+ehmANVTC+1RRFXP3PpflVU3ZeAznHv07LZxcWLOUHAZv7/DFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+JCOvYMD1ZRr9ybQPJ0v2i970glQ3QD9jcWTjpZwcg=; b=lp0cjlMrBqWoBzt13c7cvpGVLTjPoejlB43J6Kont+I42AObtyH8X5VDlZ2l7Lp1ZLt+9r0X4Ziug0dNvoPh11Q6aj9Og8jH/ol956PBwPbrmDEo+P5hbJbONMES5fr22R5bDYWSaS3kGuPfVtkxYhxeSR7nc3PGJCSoRubGbXi+h92orcATJCKxcLEX/9b6F3xE3tQ8KeASJbfwBd1HWwa7BSYDFEcssY+LEvbaJ1nz8Kz/M8y+H2ocuToYhh0k7ArdZ7fcOjwWCQVDOJZY0F+VFu4KMOaMzk1+ej1uKd+Lqi+85xOIp8t98H0yxRxQTHWUr/22YH9abXfadt0STw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9738.eurprd04.prod.outlook.com (2603:10a6:800:1dc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Thu, 20 Jul 2023 10:37:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6588.031; Thu, 20 Jul 2023 10:37:51 +0000 Message-ID: <53e359ef-ec3d-ad9d-e91b-f3aae693decf@suse.com> Date: Thu, 20 Jul 2023 12:37:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] Support Intel SHA512 Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20230718075412.1304548-1-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9738:EE_ X-MS-Office365-Filtering-Correlation-Id: addc3938-b2fb-4b83-e66d-08db890d5e29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NPI6kaEaGRQTdwlSviNlWYZsnXmtcUpEQ8TH/lD0OcKConoBQl4jIp98zAdSpZQmrRoc7tGxP+4qLvwpHvTpHtrdP8Seq6QTpoE7XgPjya3PbrS8YHrkMeSAR4UFaJiEtZnQqJv50oEy8e8s8dD0TLYEnUOhtHqX/jghodxCviiKEuBcfYGET105UxsjNhd6pWHXPIfJYMRsRUXFmtbXwr/Wo2IjJQPXuTND9CI6ZeXpEfI400f0sycpa0A4QJNkE/wDm3WJshK6mTEjLBR4vp7hK3FVdKQs+D2Pz2HIKN8MSqkfvKGqw9CHrZnSAnfrjrranlMtwSG/vgVowMagcgh5O+Xvu8A4AoXeeqD3MfX3MTMqw7rI75uNF73FWYGOZuQNla5WcaMGMRANFNbEU+0268u/WjmOhwgsz2zjcCKL17mj99jj1vkt92XY7As7B9KvoMBaUvRskeLNpTR/99jeKz17TnG+djbORugjcoK1KgJIixtkC9DtLW8vPAyPjhH8cFExSjRJHOz5NvFugNswLpb3L2Fq1irGEWqNrLFxxnuhWLkXGtl6kSDKED9DSveOS2c8HpAvex4jZ8Ornq+xxTyNZfKwNbWF1FYV3U0aobAmJjSJxFT1jYuvGPoHselWH/4Vtgjc09PEwG2qjg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199021)(41300700001)(6512007)(8676002)(8936002)(66946007)(6916009)(66556008)(2906002)(6486002)(54906003)(31686004)(86362001)(66476007)(4326008)(316002)(36756003)(2616005)(5660300002)(38100700002)(186003)(26005)(31696002)(53546011)(6506007)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWxHbVBlalQxSWQrMXJLQlZYdGFScU5aTTVpSUZPYnVBVDU4cUM3WjF2YkM1?= =?utf-8?B?eStyZEoyQUw2d1dZWTNRT0ZtR2I5TzVPem5Nb0pYRHh4K1JJL05NbnQ4T3lh?= =?utf-8?B?V0lSUmE5NjdVc3ZoMWFaam9rSC9NR29mYWhsQzFuZW1TOWMvQmt1TlZSdEV4?= =?utf-8?B?OHRSOEt2MTlwelczbm1XT21yYkt5YUUwVEVvcDVpakZqTXVBcXgrYS8wNlJh?= =?utf-8?B?ci9QQnJCRjJaVGhuRkVNeEZuM29tNlRoNGkyZGZtQ1VFM1ZQbFdtWGdiTGxz?= =?utf-8?B?Zk1GQ0JuMmd5R2JMRDZHa0M4SXA4QVBPeHErbHpLSnJPYnRnMWVUVFBCdWtE?= =?utf-8?B?ZS9QTVJTS1NjVTJLdWlwazEyUGVCa08rcmVVTXI4NDdBMWhIQ0VUYm00L0ZX?= =?utf-8?B?SmZLYSs3SUlWcUttVlVwd1NVRmp0NUQxQkRUM0dDWHFNdStnVTJPWVhLblpL?= =?utf-8?B?Mk94RkNxSDEvaWJOMkZLK0pUYmIyQzh3L1lRdU4xS2gvaHRGZUZVdk5JWW5B?= =?utf-8?B?R3lZbHgwb3pwUytKSi9EcCsrWG1SQzFvL2M3K1grZkpiMUMyVi94U09OMTdl?= =?utf-8?B?T0V5NWhNeXpoZ0tmQUpnOVVuckRXUytseks5c1hGWk9rcTE0NnU0MngwYXFk?= =?utf-8?B?cVNCdDUvV21JemJkWmFNK1RocXpoTVhsVHBWekRDT21IZmphNmdzVVcyQ1Zx?= =?utf-8?B?MSt2cGlXRHVNQi9UMWNKTHZZcW9RUEszdHh0N1hnQ3dHRW02cFF0a0M0Qlhi?= =?utf-8?B?RFB4WW5iUjNtaldocFgvc2VZYTZIbmc1azNyQUVreWdsVFRjMUp1NExxa3VH?= =?utf-8?B?YzRKNExHWWZ4SlVEMG1kdFI2aHQ0c1lpdVhJM1ZFLy9OcWxjNkpsblFGZ2NI?= =?utf-8?B?ZzZCcmZSQU13ZXJmNjRuZzVFVkZLVmQwUE01ckk3eWFaMWVTd0xmKyttWStr?= =?utf-8?B?UXppbDJQaXVvQUtWTXhha0Y5UmVEMXRhb1dNbktDSFN5R0N4UkdtUmU5WVpR?= =?utf-8?B?cEs1K3hiSmlWRFQvZ2hxYmdBMzl3ZytDUFJFaWJCQmx2TzRPUjRyajMzczcv?= =?utf-8?B?eDV1K1g0Z09HSEdkU1dBYnFadkR4VlJmL3diMUVrem80dVJ0OFVkb0YrZkdZ?= =?utf-8?B?NTErdlFQWWlzaXZOdHRzSXhJbGo0QmJtbXh2OVNhWVhKOUNzTnVQMXhMajhy?= =?utf-8?B?dXNyUFZhUituUnBFSGxPU2NWOXhaMnByZDZWc2c4c00zVjYzcUtxbjhjVlRP?= =?utf-8?B?QjlJYkxRMkNVV01UY3pPQ1AyVm1MczRvWEQwa2w4QnROeW1jZWtBdmF3L1lZ?= =?utf-8?B?ejZFRjZIYXBlT3JpQk9EREY4YjdoZEJET2RGUVRrSDUxSkF6T3Jyb2tNM3JC?= =?utf-8?B?VHZya2lLRHhDanpmbm9PZFhwckptclhOSlJobVNlUUJyaW5KN1FFeTNTVksy?= =?utf-8?B?MGRRRkVTWkRobU1UVVRZMFREMHJOMDJFUDFKZG13K2VCK3BXRS9sTlJRZ05i?= =?utf-8?B?VmVoVXVncTAxS0VnaHhra3VaNG1RSHJiWnBxM0ZZNkNZV0NLd0d2YmNOQWlZ?= =?utf-8?B?UklHTG5hbVJoS0pscHdmaXVnNDFBQ09scDNWeG9ObDdoOVdvSXI0Q2duSXVP?= =?utf-8?B?b1JyNlFybmFsUlJIMnFpUWxNNTNpS0pZZ0FBbXpPeHQ3cVRmZHU0OVZHcTFl?= =?utf-8?B?VkVIdm1iNHk0Y2hXdlNBSmw3Q1RTWnM5dnVVV1E1VmZ1amhMTll2R2gyaUhL?= =?utf-8?B?SGJUU3FZdWhPU2UrMk8xWHBWc1BpakM5Zm5DUll0aDUydkVmVU1EYmhDUEQ1?= =?utf-8?B?SXE3NGRpQzRNdjR4Mmcrd2hhTlZpL0tMYkRHRE50OGt2SUFyS2pWZ1N4S1F5?= =?utf-8?B?cXROM2xzbU1wVHljL2FiY2RxSE1JdkMyMzZZN3NiUkluTzlkc3VyZmRDeUNB?= =?utf-8?B?eFFQbUdyVFpObk0vQkU4MUxJenNweUN4WjY1MVVyMFhvSnBLTFZSNjZ4SFg3?= =?utf-8?B?VnBlYjVKYmNnWFBBK3NKZGYxWExyOTVPR2NlYlNkTGVuUWYyRGxzZlFyeVhF?= =?utf-8?B?VUx5QWpRV1dDV1NXOTc1T2lYeXdDSHpmeFcrZ2xJRHpJZWNRa05aMy9SWmxk?= =?utf-8?Q?lVNX3d21V7K041FxNxdzxgU7P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: addc3938-b2fb-4b83-e66d-08db890d5e29 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 10:37:51.1550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wbs1xpdJemKqzRIrX0Dfgwnng6dWWmsfGp9VfBuKa0gUizjnQenYOFrnlNhzUmCBwja668bSDLlgxddvCAvUuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9738 X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.07.2023 10:32, Jiang, Haochen wrote: >>> --- /dev/null >>> +++ b/gas/testsuite/gas/i386/sha512.d >>> @@ -0,0 +1,16 @@ >>> +#as: >> >> What purpose does this line (present in several of the tests) have? >> >>> --- /dev/null >>> +++ b/gas/testsuite/gas/i386/sha512.s >>> @@ -0,0 +1,13 @@ >>> +# Check 32bit SHA512 instructions >>> + >>> + .allow_index_reg >> >> This doesn't look to be needed either. >> > > We use script to generate the testcases so these two are to fit all > circumstances since actually script does not know what will happen > for a new ISA. (The former is for some extra option in as the latter is > for index reg.) > > We could omit that but one thing I need to mention is that there are > also some redundant things in all the existing testcases. If we want to > eliminate all of them, some may need careful manual work. I am > wondering if that is time-worthy to change all of them. Therefore, I > propose not to omit that to keep align with all the testcases since it > is not wrong. I guess H.J. was more permissive in what he allowed in. I'm concerned of pieces in testcases which aren't relevant: It easily raises questions of why things are there. I'd be happy to - over time - clean up that aspect as well in the testsuite, just like I've been cleaning up other oddities. I'd prefer if new testcases contained just what is needed in there for the test to fulfill its purpose. > All the other mentioned in the review has been fixed in my v3 patch > which will be sent out later. Thanks; looks like it wasn't marked as being v3. Jan