From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E9CF23875478 for ; Wed, 27 Sep 2023 13:49:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9CF23875478 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695822552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ECk1abGE6sSKZcZpAyT8Fv8ylS55HuTY1pDbHytCblE=; b=c0NKwO8vl2VzXJE23+n4wvBgoAnHUpxEGd5W8Y15B/Z6Rsh9ZWBXU0bTQlB13ILesPb3IP p1aQ8WqbBFiwJoNtbh/KAsPERK2awLDV4wPdEeIwLM0PHU+0unDRk4MAxskhKRraiYXwr3 LPVC3qmeIcvoEsPkeZxFwMhMaMLcL14= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-lrIckCDMOA601WPTLfRr4Q-1; Wed, 27 Sep 2023 09:49:11 -0400 X-MC-Unique: lrIckCDMOA601WPTLfRr4Q-1 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-452be6023d3so6533201137.0 for ; Wed, 27 Sep 2023 06:49:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695822551; x=1696427351; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ECk1abGE6sSKZcZpAyT8Fv8ylS55HuTY1pDbHytCblE=; b=RzkUPkLOjwIiLEG2zeEu+GUyiIFMSdmtZgIAtQang/6IxEUdY5mSfBVlOqm2TV2VBb Iq/t6c3l3FwU2QQAOGUPVUF2UtDEyoR6uH5MO0ZcPgjKX263FGO3k2zrexXHxIG7+DHX clj3TQhvedy7fHc2u4TmVz5IaAt5vh44V+woVbymbyLn2Mbaa71CuADqDox220HAek4W HMHdT+ufHldFNYCjnzdARyhRYpC/RR0vMkhBF4+qjYb1SCcVf/rnwWOG+M79GxTtYNKZ rlz6resF6Wq0tJbDVfVMKvfZcNSX6Ai0RH8AIzFpfqyZNNonB+G8DbEGBO+m81LZLUx1 C1Kg== X-Gm-Message-State: AOJu0Yy/X22Xk8mDRKnKUC10sqTgXeGTybmuJZyOp9J/4Up1GYRrGIAR XqWlEZKKQfBzZXpbIs++pAlnDT3mtfqZOpPDqnjkVHyjasoh8IrH83DfgTHipGTTEuoA0CvlUR0 uNSQBGvAiQhLdp60STA== X-Received: by 2002:a05:6102:2d6:b0:44d:4b34:af92 with SMTP id h22-20020a05610202d600b0044d4b34af92mr2135055vsh.7.1695822550984; Wed, 27 Sep 2023 06:49:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMM3y0rJSwvFLRivf+uOeKkYRiWEliggqnfGXJ46uPobIlI9YUEEcPY97FhqV5BvvcNH1Cvw== X-Received: by 2002:a05:6102:2d6:b0:44d:4b34:af92 with SMTP id h22-20020a05610202d600b0044d4b34af92mr2135038vsh.7.1695822550709; Wed, 27 Sep 2023 06:49:10 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id h11-20020a0cf20b000000b0065b0e724f83sm2704040qvk.6.2023.09.27.06.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 06:49:10 -0700 (PDT) Message-ID: <54010468-6534-37e0-996f-b199fb8a4214@redhat.com> Date: Wed, 27 Sep 2023 14:49:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1 1/1] opcodes: microblaze: Add wdc.ext.clear and wdc.ext.flush insns To: Neal Frager , binutils@sourceware.org Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com References: <20230925092244.3449756-1-neal.frager@amd.com> From: Nick Clifton In-Reply-To: <20230925092244.3449756-1-neal.frager@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Neal, > Added two new instructions, wdc.ext.clear and wdc.ext.flush, > to enable MicroBlaze to flush an external cache, which is > used with the new coherency support for multiprocessing. Patch approved and applied. One small question: > + {"wdc.ext.clear", INST_TYPE_R1_R2_SPECIAL, INST_NO_OFFSET, NO_DELAY_SLOT, IMMVAL_MASK_NON_SPECIAL, 0x90000466, OPCODE_MASK_H35B, wdcextclear, special_inst } This new line omits a comma at the end. Was this deliberate ? I have assumed that it was just a typo and added one, but if there is a good reason to omit the comma, please let me know and I will correct the pushed patch. Cheers Nick