From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 0D0213847718 for ; Wed, 3 Apr 2024 10:22:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D0213847718 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D0213847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712139763; cv=none; b=x4TZNXzUQsyl8t6ErwEKvkroqs2mQiS3nzP+SglH7wue+wg8lLZBYzVv3sgcAqm8+7YFFcD4awsBlaGQuEfqx8w8Nkl/g2CBLIG+9FWFYbPGMzW9fgkzyIPB7MUZNERngN10PLYy8XnViaG1SrX4D+shjxXxiFhop6cnfF0f3NE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712139763; c=relaxed/simple; bh=aRaqBftEHXcVrBMzSIWodShviuf/i4jHUwYRctkLhiU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rh2xW5MV77SGrS+TC/TOXGuIKBqY/XuKvoW2C2daMOEu7oJCvYkwsa4AuS8tgLfs5tJ48zV5o4Yzdtm3OUpwP10K8dxvhPBHbhWVsbSUO84NN32ZKan5J325bUpbfUEmMqhYDNQKmRB89gOE+H4CZ2QGV81Gq71Vm8BYb1GvMp0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-416252b5aa9so1211375e9.0 for ; Wed, 03 Apr 2024 03:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1712139759; x=1712744559; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=knK9GvR6LhPMk1mjHQ76SGhCCbCo7QkhSTb+1BrULl8=; b=R53b3t+MpOMg1tXUX2rCik6WeRfjFcmoM5FPZMWGC8BErfHxSNBuBUdXIV2XdfRuQ4 n2uIQAwysUyAFxbvLAXvD50SuVxHETjvjeEO2OIzeQMb77EYm3rl02dpJyTVFycXlKBS DCttGlj3W9BA7Vpj/YfFoOZY7OYvjSma/yE54jvbU4ClcdTSIca6Z/IMJLNMllFxh+n6 TR5muhKE+SHa3qk3+FcZFH2GH3XUBEPnrgp6oHdXiiGJbqr+eofY1pdKQR8pLUYo3oK2 VtLGr5exKFgX/TBSjDpDaeUIACOE0nbuNCMlw0F6w8dOaXPykEAZ4cX4HadcTx2/ltVl VfNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712139759; x=1712744559; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=knK9GvR6LhPMk1mjHQ76SGhCCbCo7QkhSTb+1BrULl8=; b=d6aEGZfPIDkMh3Ykb/U4y8IEmKSpFEezX9gIHyl3wz+pA5vaTRNuY9lPmtA3zwBRII yLjjUXs9xzWHQ4pg5tisJO4WvxltLmvBqmt7CsMlQP8OdfosdOqmB9hYaWBW3Ua8QSta mZcrmRTEdAiJcJuxrAgaO8FeIf4zB9ogA180Alkyx5M1y9+VHzcrtr5SKIiJ4Xt4Jpz6 7Qy6rSG6oeplkMQrXlXuHTra9jUzSDdR8s+LDESAGYGlpgpFMiTj+PqniiWCOqrkAaXi /LKoXoSAl0axgn3HjkNtKVrYQbqJ7CgMVf8KSj5LRIP08/0CoEhd2eKzdK+uYEn96unl pvqw== X-Forwarded-Encrypted: i=1; AJvYcCVu1WxoEQG6mr+qX0uOVt0WxS6drz0LncvQ9/YRGaCV8C9HK1AoJSZmBUArXxMjfSJh8TJAs3O4s2wCQI22SOaTsDWphZdF0A== X-Gm-Message-State: AOJu0YzoPAun4A2691p3M8pnSbY53TYJ4Xyjt6YdDp4tzXHlWftJ2Wwu 87+dVhzP2Dlqe1GoD4Y/pV7ZwR+kEzY7NYVE9XgZtJh9DdhAPJcIDjr6YWibBQ== X-Google-Smtp-Source: AGHT+IEjWPyaP/h0VG5nnub9UIJ3a7ilYmXKJRvsBgVBkQGcFNR8uI1Rm4vgACNmvTJnRrB/RHNbrw== X-Received: by 2002:adf:e990:0:b0:343:80d7:6b31 with SMTP id h16-20020adfe990000000b0034380d76b31mr2082954wrm.57.1712139759476; Wed, 03 Apr 2024 03:22:39 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id g1-20020adfa481000000b00341e7e52802sm16917190wrb.92.2024.04.03.03.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 03:22:39 -0700 (PDT) Message-ID: <545cf8d9-6caa-40de-b244-3d20c01a5f24@suse.com> Date: Wed, 3 Apr 2024 12:22:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] x86/APX: extend SSE2AVX coverage Content-Language: en-US To: "Jiang, Haochen" , "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <155929a3-eb8b-4b82-a4ca-84ab6de34b97@suse.com> <7add52dd-e2ab-4a65-8636-f5bb41d4d45c@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.04.2024 11:17, Jiang, Haochen wrote: > > >> On 03.04.2024 09:59, Cui, Lili wrote: >>>>> This conversion is clever, although the mnemonic has changed, but >>>> considering it is controlled by -msse2avx, maybe we can mention in the >>>> option that it might change the mnemonic. Judging from the option name >>>> alone, it is difficult for users to predict that the mnemonic will change >>>> (traditionally, it seems to just add V). >>>> >>>> I don't think doc adjustment is needed here. We already have at least one >>>> example where the mnemonic also changes: CVTPI2PD -> VCVTDQ2PD. >>>> >>> >>> Oh, there has been such a conversion before. Another thing that comes to >> mind is that sse2avx was previously used to support sse to vex conversion. >> This option works on machines that don't support evex. We now extend sse to >> evex, which makes this option unavailable on machines that do not support >> the evex instruction (e.g. hybrid machines like Alderlake). Do you think we >> should add a new option? >> >> That's a question I've tentatively answered with "No". SSE => VEX requires >> systems supporting AVX. SSE-with-eGPR requires systems with APX. >> SSE-with-eGPR => EVEX similarly can rely on APX being there, and I expect >> all such systems will support at least AVX10/128. If that is deemed a wrong >> assumption, then indeed we may need to consider adding a new option (but >> not -msse2avx512 as you suggest further down, as SSE only ever covers 128- >> bit operations; -msse2avx10 maybe). > > Just to clarify one thing, is the behavior change for -msse2avx happen only with > EGPRs? Yes, or if the programmer uses {evex}. Jan > If answer is no, no matter the assumption is right or not, I suppose the problem is > if we change the behavior for legacy -msse2avx to also promote to EVEX silently, > from my understanding, it will cause on current hybrid clients and upcoming Sierra > Forest and Clearwater Forest, EVEX instructions will appear under these platforms, > which is not aligned with previous behavior for -msse2avx. Eventually it will crash > since on those machines, there are no EVEX instructions. It might be a surprise to > users. > > Thx, > Haochen