From: Xi Ruoyao <xry111@xry111.site>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, i.swmail@xen0n.name,
maskray@google.com
Subject: Re: [PATCH v1 1/2] LoongArch: Fix pcaddi format string
Date: Wed, 09 Aug 2023 19:37:31 +0800 [thread overview]
Message-ID: <548af2c302efcdb23ae3bedd7249db9e618930be.camel@xry111.site> (raw)
In-Reply-To: <20230809013939.3388720-2-mengqinggang@loongson.cn>
On Wed, 2023-08-09 at 09:39 +0800, mengqinggang wrote:
> Add "<<2" for pcaddi format string
> ---
> opcodes/loongarch-opc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/loongarch-opc.c b/opcodes/loongarch-opc.c
> index 2f02e33dbec..7d110683e93 100644
> --- a/opcodes/loongarch-opc.c
> +++ b/opcodes/loongarch-opc.c
> @@ -564,7 +564,7 @@ static struct loongarch_opcode loongarch_imm_opcodes[] =
> { 0x10000000, 0xfc000000, "addu16i.d", "r0:5,r5:5,s10:16", 0, 0, 0, 0 },
> { 0x14000000, 0xfe000000, "lu12i.w", "r0:5,s5:20", 0, 0, 0, 0 },
> { 0x16000000, 0xfe000000, "lu32i.d", "r0:5,s5:20", 0, 0, 0, 0 },
> - { 0x18000000, 0xfe000000, "pcaddi", "r0:5,s5:20", 0, 0, 0, 0 },
> + { 0x18000000, 0xfe000000, "pcaddi", "r0:5,s5:20<<2", 0, 0, 0, 0 },
The Linux kernel already uses things like "pcaddi t0, 4". To me this
change will break them completely, and fixing it on the kernel side will
be difficult (we'll need to create some nasty gas version check).
So I don't think we should make such a backward incompatible change
without a very compelling reason. You may argue that "<<2" has a better
readability, but if we really need the readability we can write
pcaddi t0, 4 # << 2
in the code anyway.
> { 0x1a000000, 0xfe000000, "pcalau12i", "r0:5,s5:20", 0, 0, 0, 0 },
> { 0x1c000000, 0xfe000000, "pcaddu12i", "r0:5,s5:20", 0, 0, 0, 0 },
> { 0x1e000000, 0xfe000000, "pcaddu18i", "r0:5,s5:20", 0, 0, 0, 0 },
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-08-09 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 1:39 [PATCH v1 0/2] Add support for "pcaddi rd, label" mengqinggang
2023-08-09 1:39 ` [PATCH v1 1/2] LoongArch: Fix pcaddi format string mengqinggang
2023-08-09 11:37 ` Xi Ruoyao [this message]
2023-08-09 11:48 ` Xi Ruoyao
2023-08-11 3:08 ` WANG Xuerui
2023-08-15 10:00 ` mengqinggang
2023-08-15 10:44 ` Xi Ruoyao
2023-08-15 11:35 ` mengqinggang
2023-08-15 15:03 ` Xi Ruoyao
2023-08-09 1:39 ` [PATCH v1 2/2] LoongArch: Add support for "pcaddi rd, label" mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548af2c302efcdb23ae3bedd7249db9e618930be.camel@xry111.site \
--to=xry111@xry111.site \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).