* [PATCH] ld: don't use ia64 register name in expression of pr16322 test
@ 2015-01-08 12:40 Jan Beulich
2015-01-08 12:58 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2015-01-08 12:40 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
"f1" is a register name on ia64, and hence gets warned upon when used
as expression value:
.../binutils/2.25/ld/testsuite/ld-elf/pr16322.s: Assembler messages:
.../binutils/2.25/ld/testsuite/ld-elf/pr16322.s:6: Warning: register value used as expression
Change the name (and "p1" at once, which is a register name too, albeit
not currently causing any immediate problem).
ld/testsuite/
2015-01-08 Jan Beulich <jbeulich@suse.com>
* ld-elf/pr16322.s (p1): Rename to px1.
(f1): Rename to fx1.
--- 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2014-02-20 15:36:37.000000000 +0100
+++ 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2015-01-08 12:53:04.000000000 +0100
@@ -1,6 +1,6 @@
- .globl p1
+ .globl px1
.section .data.rel.ro,"aw",%progbits
.p2align 5
- .type p1, %object
-p1:
- .dc.a f1
+ .type px1, %object
+px1:
+ .dc.a fx1
[-- Attachment #2: binutils-master-ia64-ld-pr16322-regname.patch --]
[-- Type: text/plain, Size: 922 bytes --]
ld: don't use ia64 register name in expression of pr16322 test
"f1" is a register name on ia64, and hence gets warned upon when used
as expression value:
.../binutils/2.25/ld/testsuite/ld-elf/pr16322.s: Assembler messages:
.../binutils/2.25/ld/testsuite/ld-elf/pr16322.s:6: Warning: register value used as expression
Change the name (and "p1" at once, which is a register name too, albeit
not currently causing any immediate problem).
ld/testsuite/
2015-01-08 Jan Beulich <jbeulich@suse.com>
* ld-elf/pr16322.s (p1): Rename to px1.
(f1): Rename to fx1.
--- 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2014-02-20 15:36:37.000000000 +0100
+++ 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2015-01-08 12:53:04.000000000 +0100
@@ -1,6 +1,6 @@
- .globl p1
+ .globl px1
.section .data.rel.ro,"aw",%progbits
.p2align 5
- .type p1, %object
-p1:
- .dc.a f1
+ .type px1, %object
+px1:
+ .dc.a fx1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ld: don't use ia64 register name in expression of pr16322 test
2015-01-08 12:40 [PATCH] ld: don't use ia64 register name in expression of pr16322 test Jan Beulich
@ 2015-01-08 12:58 ` H.J. Lu
2015-01-23 17:03 ` Ping: " Jan Beulich
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2015-01-08 12:58 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils
On Thu, Jan 8, 2015 at 4:40 AM, Jan Beulich <JBeulich@suse.com> wrote:
> "f1" is a register name on ia64, and hence gets warned upon when used
> as expression value:
>
> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s: Assembler messages:
> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s:6: Warning: register value used as expression
>
> Change the name (and "p1" at once, which is a register name too, albeit
> not currently causing any immediate problem).
>
> ld/testsuite/
> 2015-01-08 Jan Beulich <jbeulich@suse.com>
>
> * ld-elf/pr16322.s (p1): Rename to px1.
> (f1): Rename to fx1.
>
> --- 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2014-02-20 15:36:37.000000000 +0100
> +++ 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2015-01-08 12:53:04.000000000 +0100
> @@ -1,6 +1,6 @@
> - .globl p1
> + .globl px1
> .section .data.rel.ro,"aw",%progbits
> .p2align 5
> - .type p1, %object
> -p1:
> - .dc.a f1
> + .type px1, %object
> +px1:
> + .dc.a fx1
>
>
>
It is OK.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping: [PATCH] ld: don't use ia64 register name in expression of pr16322 test
2015-01-08 12:58 ` H.J. Lu
@ 2015-01-23 17:03 ` Jan Beulich
2015-01-23 17:09 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2015-01-23 17:03 UTC (permalink / raw)
To: Nick Clifton, Binutils; +Cc: H.J. Lu
H.J. gave his okay, but aiui this isn't sufficient for me to commit.
Thanks, Jan
>>> On 08.01.15 at 13:58, <hjl.tools@gmail.com> wrote:
> On Thu, Jan 8, 2015 at 4:40 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> "f1" is a register name on ia64, and hence gets warned upon when used
>> as expression value:
>>
>> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s: Assembler messages:
>> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s:6: Warning: register value
> used as expression
>>
>> Change the name (and "p1" at once, which is a register name too, albeit
>> not currently causing any immediate problem).
>>
>> ld/testsuite/
>> 2015-01-08 Jan Beulich <jbeulich@suse.com>
>>
>> * ld-elf/pr16322.s (p1): Rename to px1.
>> (f1): Rename to fx1.
>>
>> --- 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2014-02-20
> 15:36:37.000000000 +0100
>> +++ 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2015-01-08
> 12:53:04.000000000 +0100
>> @@ -1,6 +1,6 @@
>> - .globl p1
>> + .globl px1
>> .section .data.rel.ro,"aw",%progbits
>> .p2align 5
>> - .type p1, %object
>> -p1:
>> - .dc.a f1
>> + .type px1, %object
>> +px1:
>> + .dc.a fx1
>>
>>
>>
>
> It is OK.
>
> Thanks.
>
> --
> H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: [PATCH] ld: don't use ia64 register name in expression of pr16322 test
2015-01-23 17:03 ` Ping: " Jan Beulich
@ 2015-01-23 17:09 ` H.J. Lu
2015-01-28 7:08 ` Alan Modra
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2015-01-23 17:09 UTC (permalink / raw)
To: Jan Beulich; +Cc: Nick Clifton, Binutils
On Fri, Jan 23, 2015 at 9:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
> H.J. gave his okay, but aiui this isn't sufficient for me to commit.
Since I wrote the testcase, my OK should be sufficient.
> Thanks, Jan
>
>>>> On 08.01.15 at 13:58, <hjl.tools@gmail.com> wrote:
>> On Thu, Jan 8, 2015 at 4:40 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> "f1" is a register name on ia64, and hence gets warned upon when used
>>> as expression value:
>>>
>>> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s: Assembler messages:
>>> .../binutils/2.25/ld/testsuite/ld-elf/pr16322.s:6: Warning: register value
>> used as expression
>>>
>>> Change the name (and "p1" at once, which is a register name too, albeit
>>> not currently causing any immediate problem).
>>>
>>> ld/testsuite/
>>> 2015-01-08 Jan Beulich <jbeulich@suse.com>
>>>
>>> * ld-elf/pr16322.s (p1): Rename to px1.
>>> (f1): Rename to fx1.
>>>
>>> --- 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2014-02-20
>> 15:36:37.000000000 +0100
>>> +++ 2015-01-08/ld/testsuite/ld-elf/pr16322.s 2015-01-08
>> 12:53:04.000000000 +0100
>>> @@ -1,6 +1,6 @@
>>> - .globl p1
>>> + .globl px1
>>> .section .data.rel.ro,"aw",%progbits
>>> .p2align 5
>>> - .type p1, %object
>>> -p1:
>>> - .dc.a f1
>>> + .type px1, %object
>>> +px1:
>>> + .dc.a fx1
>>>
>>>
>>>
>>
>> It is OK.
>>
>> Thanks.
>>
>> --
>> H.J.
>
>
>
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: [PATCH] ld: don't use ia64 register name in expression of pr16322 test
2015-01-23 17:09 ` H.J. Lu
@ 2015-01-28 7:08 ` Alan Modra
0 siblings, 0 replies; 5+ messages in thread
From: Alan Modra @ 2015-01-28 7:08 UTC (permalink / raw)
To: H.J. Lu; +Cc: Jan Beulich, Nick Clifton, Binutils
On Fri, Jan 23, 2015 at 09:09:12AM -0800, H.J. Lu wrote:
> On Fri, Jan 23, 2015 at 9:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
> > H.J. gave his okay, but aiui this isn't sufficient for me to commit.
>
> Since I wrote the testcase, my OK should be sufficient.
Jan, you know what you're doing. Please consider this sort of fix as
obvious.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-28 7:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 12:40 [PATCH] ld: don't use ia64 register name in expression of pr16322 test Jan Beulich
2015-01-08 12:58 ` H.J. Lu
2015-01-23 17:03 ` Ping: " Jan Beulich
2015-01-23 17:09 ` H.J. Lu
2015-01-28 7:08 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).