public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [Committed][AArch64] Add test case for ADR :got:foo
@ 2015-02-26 22:35 Marcus Shawcroft
  0 siblings, 0 replies; only message in thread
From: Marcus Shawcroft @ 2015-02-26 22:35 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

The modifier :got: does not make sense on an ADR instruction.  Add a 
test case to ensure we gripe. This test case will FAIL until the 
following patch is applied to correct our behaviour.

/Marcus

[-- Attachment #2: 0005-AArch64-Add-test-case-for-ADR-got-foo.patch --]
[-- Type: text/x-patch, Size: 1339 bytes --]

diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 96697eb..8884e35 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-26  Marcus Shawcroft  <marcus.shawcroft@arm.com>
+
+	* gas/aarch64/diagnostic.s: Add ADR test.
+	* gas/aarch64/diagnostic.l: Likewise.
+
 2015-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* gas/avr/avr-prop-1.d: New file.
diff --git a/gas/testsuite/gas/aarch64/diagnostic.l b/gas/testsuite/gas/aarch64/diagnostic.l
index 61ce5d2..50f2a6d 100644
--- a/gas/testsuite/gas/aarch64/diagnostic.l
+++ b/gas/testsuite/gas/aarch64/diagnostic.l
@@ -114,3 +114,4 @@
 [^:]*:123: Warning: unpredictable transfer with writeback -- `str x1,\[x1\],#8'
 [^:]*:124: Warning: unpredictable transfer with writeback -- `stp x0,x1,\[x0,#16\]!'
 [^:]*:125: Warning: unpredictable transfer with writeback -- `ldp x0,x1,\[x1\],#16'
+[^:]*:126: Error: this relocation modifier is not allowed on this instruction at operand 2 -- `adr x2,:got:s1'
diff --git a/gas/testsuite/gas/aarch64/diagnostic.s b/gas/testsuite/gas/aarch64/diagnostic.s
index 88001da..6dbe6e1 100644
--- a/gas/testsuite/gas/aarch64/diagnostic.s
+++ b/gas/testsuite/gas/aarch64/diagnostic.s
@@ -123,3 +123,4 @@
 	str	x1, [x1], #8
 	stp	x0, x1, [x0, #16]!
 	ldp	x0, x1, [x1], #16
+	adr	x2, :got:s1
-- 
1.9.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-02-26 22:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 22:35 [Committed][AArch64] Add test case for ADR :got:foo Marcus Shawcroft

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).