From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Renlin Li <renlin.li@arm.com>,
Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
"nickc@redhat.com" <nickc@redhat.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [GAS][ARM]Positively emit symbols for alignment. --> [PATCH][LD][ARM] Fix two test case failures.
Date: Wed, 29 Apr 2015 09:23:00 -0000 [thread overview]
Message-ID: <5540A329.3090807@foss.arm.com> (raw)
In-Reply-To: <5540A28F.9090108@arm.com>
On 29/04/15 10:21, Renlin Li wrote:
> Hi Hans-Peter,
>
> Thank you for your report! I have attached the patch to fix the test cases.
>
> Previously, the padding bytes are treated as instruction, because data
> mapping symbols are missing. With the new patch, data mapping symbols
> are emitted, the bytes thereafter are correctly interpreted as data.
>
> Okay to commit?
>
OK.
R.
> Regards,
> Renlin Li
>
> ld/testsuite/ChangeLog:
>
> 2015-04-29 Renlin Li <renlin.li@arm.com>
>
> * ld-arm/ifunc-10.dd: Adjust expected output.
> * ld-arm/ifunc-2.dd: Likewise.
>
> On 28/04/15 22:07, Hans-Peter Nilsson wrote:
>> Maybe you refer to some other target (which one?) than
>> arm-unknown-eabi, because for arm-unknown-eabi, this patch
>> caused failures in the ld testsuite:
>>
>> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-arm/arm-elf.exp ...
>> FAIL: IFUNC test 2
>> FAIL: IFUNC test 10
>>
>> I'm guessing you just need to adjust the
>> expected-result-templates for the "mapping symbols".
>>
>> brgds, H-P
>>
>>
>> ld.diff
>>
>>
>> diff --git a/ld/testsuite/ld-arm/ifunc-10.dd b/ld/testsuite/ld-arm/ifunc-10.dd
>> index 88bae50..d96c086 100644
>> --- a/ld/testsuite/ld-arm/ifunc-10.dd
>> +++ b/ld/testsuite/ld-arm/ifunc-10.dd
>> @@ -267,7 +267,7 @@ Disassembly of section \.text:
>>
>> 0000a010 <tbf1>:
>> a010: 46f7 mov pc, lr
>> - a012: 0000 movs r0, r0
>> + a012: 0000 .short 0x0000
>> a014: e1a0f00e mov pc, lr
>> a018: e1a0f00e mov pc, lr
>> a01c: e1a0f00e mov pc, lr
>> diff --git a/ld/testsuite/ld-arm/ifunc-2.dd b/ld/testsuite/ld-arm/ifunc-2.dd
>> index f6d57fa..91eab54 100644
>> --- a/ld/testsuite/ld-arm/ifunc-2.dd
>> +++ b/ld/testsuite/ld-arm/ifunc-2.dd
>> @@ -84,10 +84,10 @@ Disassembly of section \.text:
>>
>> 0000a00c <f4>:
>> a00c: 46f7 mov pc, lr
>> - a00e: 0000 movs r0, r0
>> + a00e: 0000 .short 0x0000
>> a010: e1a0f00e mov pc, lr
>> a014: 46f7 mov pc, lr
>> - a016: 0000 movs r0, r0
>> + a016: 0000 .short 0x0000
>> a018: e1a0f00e mov pc, lr
>> a01c: 46f7 mov pc, lr
>> \.\.\.
next prev parent reply other threads:[~2015-04-29 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 12:53 [GAS][ARM]Positively emit symbols for alignment Renlin Li
2015-04-24 16:40 ` Nicholas Clifton
2015-05-05 15:22 ` Commit: [GAS][AARCH64]Positively " Renlin Li
2015-04-28 21:07 ` [GAS][ARM]Positively " Hans-Peter Nilsson
2015-04-29 9:21 ` [GAS][ARM]Positively emit symbols for alignment. --> [PATCH][LD][ARM] Fix two test case failures Renlin Li
2015-04-29 9:23 ` Richard Earnshaw [this message]
2015-06-16 8:24 ` [2.25][ARM][GAS]Backport "Positively emit symbols for alignment." Renlin Li
2015-06-16 8:29 ` Tristan Gingold
2015-06-16 8:31 ` Renlin Li
2015-06-17 9:39 ` [2.25][AARCH64][GAS]Backport " Renlin Li
2015-06-17 10:20 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540A329.3090807@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=binutils@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
--cc=nickc@redhat.com \
--cc=renlin.li@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).