From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124869 invoked by alias); 29 Apr 2015 09:23:59 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 124855 invoked by uid 89); 29 Apr 2015 09:23:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Apr 2015 09:23:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A393429; Wed, 29 Apr 2015 02:23:30 -0700 (PDT) Received: from e105689-lin.cambridge.arm.com (e105689-lin.cambridge.arm.com [10.2.207.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D87313F3E7; Wed, 29 Apr 2015 02:23:54 -0700 (PDT) Message-ID: <5540A329.3090807@foss.arm.com> Date: Wed, 29 Apr 2015 09:23:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Renlin Li , Hans-Peter Nilsson CC: "binutils@sourceware.org" , "nickc@redhat.com" , Marcus Shawcroft Subject: Re: [GAS][ARM]Positively emit symbols for alignment. --> [PATCH][LD][ARM] Fix two test case failures. References: <201504282107.t3SL77lQ029543@ignucius.se.axis.com> <5540A28F.9090108@arm.com> In-Reply-To: <5540A28F.9090108@arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00458.txt.bz2 On 29/04/15 10:21, Renlin Li wrote: > Hi Hans-Peter, > > Thank you for your report! I have attached the patch to fix the test cases. > > Previously, the padding bytes are treated as instruction, because data > mapping symbols are missing. With the new patch, data mapping symbols > are emitted, the bytes thereafter are correctly interpreted as data. > > Okay to commit? > OK. R. > Regards, > Renlin Li > > ld/testsuite/ChangeLog: > > 2015-04-29 Renlin Li > > * ld-arm/ifunc-10.dd: Adjust expected output. > * ld-arm/ifunc-2.dd: Likewise. > > On 28/04/15 22:07, Hans-Peter Nilsson wrote: >> Maybe you refer to some other target (which one?) than >> arm-unknown-eabi, because for arm-unknown-eabi, this patch >> caused failures in the ld testsuite: >> >> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-arm/arm-elf.exp ... >> FAIL: IFUNC test 2 >> FAIL: IFUNC test 10 >> >> I'm guessing you just need to adjust the >> expected-result-templates for the "mapping symbols". >> >> brgds, H-P >> >> >> ld.diff >> >> >> diff --git a/ld/testsuite/ld-arm/ifunc-10.dd b/ld/testsuite/ld-arm/ifunc-10.dd >> index 88bae50..d96c086 100644 >> --- a/ld/testsuite/ld-arm/ifunc-10.dd >> +++ b/ld/testsuite/ld-arm/ifunc-10.dd >> @@ -267,7 +267,7 @@ Disassembly of section \.text: >> >> 0000a010 : >> a010: 46f7 mov pc, lr >> - a012: 0000 movs r0, r0 >> + a012: 0000 .short 0x0000 >> a014: e1a0f00e mov pc, lr >> a018: e1a0f00e mov pc, lr >> a01c: e1a0f00e mov pc, lr >> diff --git a/ld/testsuite/ld-arm/ifunc-2.dd b/ld/testsuite/ld-arm/ifunc-2.dd >> index f6d57fa..91eab54 100644 >> --- a/ld/testsuite/ld-arm/ifunc-2.dd >> +++ b/ld/testsuite/ld-arm/ifunc-2.dd >> @@ -84,10 +84,10 @@ Disassembly of section \.text: >> >> 0000a00c : >> a00c: 46f7 mov pc, lr >> - a00e: 0000 movs r0, r0 >> + a00e: 0000 .short 0x0000 >> a010: e1a0f00e mov pc, lr >> a014: 46f7 mov pc, lr >> - a016: 0000 movs r0, r0 >> + a016: 0000 .short 0x0000 >> a018: e1a0f00e mov pc, lr >> a01c: 46f7 mov pc, lr >> \.\.\.