From: "Jan Beulich" <JBeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "Binutils" <binutils@sourceware.org>
Subject: Re: [committed, PATCH] Remove Disp16|Disp32 from 64-bit direct branches
Date: Tue, 12 May 2015 15:17:00 -0000 [thread overview]
Message-ID: <555235930200007800079911@mail.emea.novell.com> (raw)
In-Reply-To: <CAMe9rOrOS+K0R+r1jHCNwAkgrhjftHUOGt_wTuP8wRYcPdifmQ@mail.gmail.com>
>>> On 12.05.15 at 17:11, <hjl.tools@gmail.com> wrote:
> On Tue, May 12, 2015 at 8:09 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 12.05.15 at 17:03, <hjl.tools@gmail.com> wrote:
>>> On Tue, May 12, 2015 at 7:59 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> Yes. But then what was the point of you ripping out Disp16?
>>>
>>> I removed it since it doesn't jump to the target. Can you verify
>>> that it does jump to "(nextip + disp16) & 0xffff, not jump to
>>> "(nextip + disp16)"?
>>
>> Yes - see the gdb output I provided yesterday.
>>
>
> Does it mean it is wrong to display
>
> 0: 66 e9 00 00 jmpw 4 <bar>
> 2: R_X86_64_PC16 foo-0x2
>
> 0000000000000004 <bar>:
> 4: 89 c2 mov %eax,%edx
I don't think so - this looks quite okay. It would become more of an
issue when looking at other than relocatable object files (namely
when their image base is non-zero), or ones with .text exceeding
32k.
Jan
next prev parent reply other threads:[~2015-05-12 15:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 21:23 H.J. Lu
2015-05-12 10:41 ` Jan Beulich
2015-05-12 11:54 ` H.J. Lu
2015-05-12 12:20 ` Jan Beulich
2015-05-12 12:37 ` H.J. Lu
2015-05-12 13:03 ` Jan Beulich
2015-05-12 13:37 ` H.J. Lu
2015-05-12 13:49 ` Michael Matz
2015-05-12 13:57 ` H.J. Lu
2015-05-12 14:31 ` Michael Matz
2015-05-12 14:49 ` H.J. Lu
2015-05-12 15:14 ` Michael Matz
2015-05-12 15:21 ` H.J. Lu
2015-05-12 15:32 ` Michael Matz
2015-05-12 14:59 ` Jan Beulich
2015-05-12 15:03 ` H.J. Lu
2015-05-12 15:09 ` Jan Beulich
2015-05-12 15:11 ` H.J. Lu
2015-05-12 15:17 ` Jan Beulich [this message]
2015-05-12 15:37 ` Michael Matz
2015-05-12 15:43 ` H.J. Lu
2015-05-12 15:47 ` Michael Matz
2015-05-12 16:00 ` H.J. Lu
2015-05-12 16:03 ` Michael Matz
2015-05-12 16:08 ` H.J. Lu
2015-05-13 6:18 ` Jan Beulich
2015-05-13 11:35 ` H.J. Lu
2015-05-13 12:27 ` Jan Beulich
2015-05-13 13:15 ` H.J. Lu
2015-05-13 12:34 ` Michael Matz
2015-05-13 13:32 ` H.J. Lu
2015-05-13 16:50 ` Maciej W. Rozycki
2015-05-13 16:53 ` H.J. Lu
2015-05-15 6:39 ` Jan Beulich
2015-05-15 16:52 ` H.J. Lu
2015-05-18 7:05 ` Jan Beulich
2015-05-18 11:22 ` H.J. Lu
2015-05-18 11:48 ` Jan Beulich
2015-05-18 12:18 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555235930200007800079911@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).