From: Chung-Lin Tang <cltang@codesourcery.com>
To: Ilya Malakhov <ilmalakhovthefirst@gmail.com>,
<binutils@sourceware.org>, <hjl.tools@gmail.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>
Subject: Re: ELF options may be missing from `ld --help' output after migration to ld_list_options
Date: Thu, 14 May 2015 10:41:00 -0000 [thread overview]
Message-ID: <55547BB9.4010003@codesourcery.com> (raw)
In-Reply-To: <20150410085450.GK27812@bubble.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On 15/4/10 4:54 PM, Alan Modra wrote:
> On Fri, Apr 10, 2015 at 11:05:45AM +0300, Ilya Malakhov wrote:
>> One should probably check whether to set elf_list_options and others to TRUE
>> in `*)' case rather than in `*" e${i}.o "*)' one within ld/configure.ac in
>> master branch of binutils-gdb.git:
>
> Indeed. Thanks!
>
> * configure.ac: Set elf_list_options etc. in proper case.
> * configure: Regenerate.
I have another case that needs fixing related to ld_list_options.
nios2-linux has an emulation named "nios2linux", and happens to not include
another extra emulation with a name matching *elf*. This makes nios2-linux
left out of the ELF options printing targets, which is unintended.
The name of emulation didn't play this part when I created "nios2linux" from
"nios2elf", so this is a recent breakage (glibc configure failed for me too :P).
I can change the emulation name to something like "nios2elf_linux" if required,
but may I suggest that configuration uses emulparams/*.sh contents too?
The attached patch also enables the ELF options when "TEMPLATE_NAME=elf32" is
found inside the emulparams file as well. This should make things more robust.
Thanks,
Chung-Lin
2015-05-14 Chung-Lin Tang <cltang@codesourcery.com>
* configure.ac (AC_PROG_GREP): Check for grep program.
(elf_list_options,elf_shlib_list_options,elf_plt_unwind_list_options):
Enable ELF option printing for emulations containing 'TEMPLATE_NAME=elf32'.
* configure: Regenerate.
[-- Attachment #2: ld-config.patch --]
[-- Type: text/x-patch, Size: 938 bytes --]
diff --git a/ld/configure.ac b/ld/configure.ac
index e120a05..54bfb86 100644
--- a/ld/configure.ac
+++ b/ld/configure.ac
@@ -31,6 +31,7 @@ AM_MAINTAINER_MODE
AC_PROG_CC
AC_PROG_CXX
+AC_PROG_GREP
AC_GNU_SOURCE
AC_USE_SYSTEM_EXTENSIONS
AC_PROG_INSTALL
@@ -324,8 +325,14 @@ do
test -z "$result" && result=$targ_alias
echo tdir_$i=$result >> tdirs
case "${i}" in
- *elf*)
- elf_list_options=TRUE
+ *elf*) elf_list_options=TRUE ;;
+ *)
+ if test `$GREP "TEMPLATE_NAME=elf32" ${srcdir}/emulparams/${i}.sh`; then
+ elf_list_options=TRUE
+ fi
+ ;;
+ esac
+ if test "$elf_list_options" = "TRUE"; then
. ${srcdir}/emulparams/${i}.sh
if test x${GENERATE_SHLIB_SCRIPT} = xyes; then
elf_shlib_list_options=TRUE
@@ -333,8 +340,7 @@ do
if test x${PLT_UNWIND} = xyes; then
elf_plt_unwind_list_options=TRUE
fi
- ;;
- esac
+ fi
;;
esac
done
next prev parent reply other threads:[~2015-05-14 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 8:05 Ilya Malakhov
2015-04-10 8:55 ` Alan Modra
2015-05-14 10:41 ` Chung-Lin Tang [this message]
2015-05-17 4:57 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55547BB9.4010003@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=ilmalakhovthefirst@gmail.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).