[ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[Matthew Wahab]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hello,

Support for ARMv8.1 Adv.SIMD was recently added to gas as architecture
extensions and as the -mfpu option neon-fp-armv8.1. This patch adds the -mfpu
option crypto-neon-fp-armv8.1 as neon-fp-armv8.1 with the crypto extension
enabled.

Tested for arm-none-linux-gnueabihf with check-binutils and check-gas. Checked
HTML documentation.

Ok for trunk?
Matthew

gas/
2015-06-19  Matthew Wahab  <matthew.wahab@arm.com>

	* config/tc-arm.c (arm_fpus): Add crypto-neon-fp-armv8.1.
	* doc/c-arm.texi (-mfpu=): Likewise.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm_fpu_option.patch --]
[-- Type: text/x-patch; name=arm_fpu_option.patch, Size: 1024 bytes --]

diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 1793965..b1e51f5 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -24989,6 +24989,8 @@ static const struct arm_option_fpu_value_table arm_fpus[] =
   {"crypto-neon-fp-armv8",
 			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8},
   {"neon-fp-armv8.1",	FPU_ARCH_NEON_VFP_ARMV8_1},
+  {"crypto-neon-fp-armv8.1",
+			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_1},
   {NULL,		ARM_ARCH_NONE}
 };
 
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 0c3b9f9..11ecc09 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -274,9 +274,10 @@ The following format options are recognized:
 @code{neon},
 @code{neon-vfpv4},
 @code{neon-fp-armv8},
-@code{crypto-neon-fp-armv8}.
+@code{crypto-neon-fp-armv8},
+@code{neon-fp-armv8-1}
 and
-@code{neon-fp-armv8-1},
+@code{crypto-neon-fp-armv8-1}.
 
 In addition to determining which instructions are assembled, this option
 also affects the way in which the @code{.double} assembler directive behaves

Re: [ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[Matthew Wahab]

On 19/06/15 10:35, Matthew Wahab wrote:
> Hello,
>
> Support for ARMv8.1 Adv.SIMD was recently added to gas as architecture
> extensions and as the -mfpu option neon-fp-armv8.1. This patch adds the -mfpu
> option crypto-neon-fp-armv8.1 as neon-fp-armv8.1 with the crypto extension
> enabled.
>
> Tested for arm-none-linux-gnueabihf with check-binutils and check-gas. Checked
> HTML documentation.
>
> Ok for trunk?
> Matthew
>
> gas/
> 2015-06-19  Matthew Wahab  <matthew.wahab@arm.com>
>
> 	* config/tc-arm.c (arm_fpus): Add crypto-neon-fp-armv8.1.
> 	* doc/c-arm.texi (-mfpu=): Likewise.
>

Unfortunately I got the documentation wrong for this and the neon-fp-armv8.1 option. 
The manual has the command line options ending with 'v8-1' rather than 'v8.1'.
I'll redo the patch to fix both.

Matthew

Re: [ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[Matthew Wahab]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On 19/06/15 10:49, Matthew Wahab wrote:
> On 19/06/15 10:35, Matthew Wahab wrote:
>> Support for ARMv8.1 Adv.SIMD was recently added to gas as architecture
>> extensions and as the -mfpu option neon-fp-armv8.1. This patch adds the -mfpu
>> option crypto-neon-fp-armv8.1 as neon-fp-armv8.1 with the crypto extension
>> enabled.
>
> Unfortunately I got the documentation wrong for this and the neon-fp-armv8.1 option.
> The manual has the command line options ending with 'v8-1' rather than 'v8.1'.
> I'll redo the patch to fix both.

Attached, the updated patch.

Tested for arm-none-linux-gnueabihf with check-binutils and check-gas. Checked the
HTML documentation.

Ok for trunk?
Matthew

gas/
2015-06-19  Matthew Wahab  <matthew.wahab@arm.com>

	* config/tc-arm.c (arm_fpus): Add crypto-neon-fp-armv8.1.
	* doc/c-arm.texi (-mfpu=): Likewise.  Correct the entry for
	neon-fp-armv8.1.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm_fpu_option_v2.patch --]
[-- Type: text/x-patch; name=arm_fpu_option_v2.patch, Size: 1024 bytes --]

diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 1793965..b1e51f5 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -24989,6 +24989,8 @@ static const struct arm_option_fpu_value_table arm_fpus[] =
   {"crypto-neon-fp-armv8",
 			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8},
   {"neon-fp-armv8.1",	FPU_ARCH_NEON_VFP_ARMV8_1},
+  {"crypto-neon-fp-armv8.1",
+			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_1},
   {NULL,		ARM_ARCH_NONE}
 };
 
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 0c3b9f9..7fadd28 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -274,9 +274,10 @@ The following format options are recognized:
 @code{neon},
 @code{neon-vfpv4},
 @code{neon-fp-armv8},
-@code{crypto-neon-fp-armv8}.
+@code{crypto-neon-fp-armv8},
+@code{neon-fp-armv8.1}
 and
-@code{neon-fp-armv8-1},
+@code{crypto-neon-fp-armv8.1}.
 
 In addition to determining which instructions are assembled, this option
 also affects the way in which the @code{.double} assembler directive behaves

Re: [ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[Matthew Wahab]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

Ping. Updated patch attached.

On 19/06/15 11:14, Matthew Wahab wrote:
> On 19/06/15 10:49, Matthew Wahab wrote:
>> On 19/06/15 10:35, Matthew Wahab wrote:
>>> Support for ARMv8.1 Adv.SIMD was recently added to gas as architecture
>>> extensions and as the -mfpu option neon-fp-armv8.1. This patch adds the -mfpu
>>> option crypto-neon-fp-armv8.1 as neon-fp-armv8.1 with the crypto extension
>>> enabled.
>>
>> Unfortunately I got the documentation wrong for this and the neon-fp-armv8.1 option.
>> The manual has the command line options ending with 'v8-1' rather than 'v8.1'.
>> I'll redo the patch to fix both.
>
> Attached, the updated patch.
>
> Tested for arm-none-linux-gnueabihf with check-binutils and check-gas. Checked the
> HTML documentation.
>
> Ok for trunk?
> Matthew
>
> gas/
> 2015-06-19  Matthew Wahab  <matthew.wahab@arm.com>
>
> 	* config/tc-arm.c (arm_fpus): Add crypto-neon-fp-armv8.1.
> 	* doc/c-arm.texi (-mfpu=): Likewise.  Correct the entry for
> 	neon-fp-armv8.1.
>


[-- Attachment #2: arm_fpu_option_v2.patch --]
[-- Type: text/x-patch, Size: 994 bytes --]

diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 1793965..b1e51f5 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -24989,6 +24989,8 @@ static const struct arm_option_fpu_value_table arm_fpus[] =
   {"crypto-neon-fp-armv8",
 			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8},
   {"neon-fp-armv8.1",	FPU_ARCH_NEON_VFP_ARMV8_1},
+  {"crypto-neon-fp-armv8.1",
+			FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_1},
   {NULL,		ARM_ARCH_NONE}
 };
 
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 0c3b9f9..7fadd28 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -274,9 +274,10 @@ The following format options are recognized:
 @code{neon},
 @code{neon-vfpv4},
 @code{neon-fp-armv8},
-@code{crypto-neon-fp-armv8}.
+@code{crypto-neon-fp-armv8},
+@code{neon-fp-armv8.1}
 and
-@code{neon-fp-armv8-1},
+@code{crypto-neon-fp-armv8.1}.
 
 In addition to determining which instructions are assembled, this option
 also affects the way in which the @code{.double} assembler directive behaves

Re: [ARM][gas] Add crypto-neon-fp-armv8.1 as an fpu option.

[Nicholas Clifton]

Hi Matthew,

>> gas/
>> 2015-06-19  Matthew Wahab  <matthew.wahab@arm.com>
>>
>>     * config/tc-arm.c (arm_fpus): Add crypto-neon-fp-armv8.1.
>>     * doc/c-arm.texi (-mfpu=): Likewise.  Correct the entry for
>>     neon-fp-armv8.1.

Approved - please apply.

Cheers
   Nick

PS. Sorry for the delay in reviewing.