From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TYDD=G5=foss.arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 878F3385B515
	for <binutils@sourceware.org>; Thu, 16 Nov 2023 14:13:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 878F3385B515
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 878F3385B515
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700144004; cv=none;
	b=TMV0Wn5z0nT5uZUaD+ZysP6In+O1IHn87RWMO4JfnfRWFNLFWVjWXW+68aLJwgdDie7LR8WxD/dFrJ56N5JvSIjhtn5BGrZHmYmRLpBTWrSS0dSMdAtCVOdzjG98byZrQPUDpOz5yROlcwihh77lTTyZ+l6MF1ATfUXdIk/18GM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1700144004; c=relaxed/simple;
	bh=DK+yp5Ay/Wl0EHj8biPlC6IFgkIRGTqrpGEj/77/lW4=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=Aqx6/b+t4gR0by1DPomrmuobzJBUxK70B/hsKejyOUtSemrha4WsSJXI1CpRj+t/l7hwqi3RehAPJMUBIB0hs7OPpYvoHONsHRUhAR/IyOY8fVSQKP4K84VzbHRbVjVd7w7VvV8bNh3ISt/BjWA6TlEOY0zke3Pie5/XmgKUjRM=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A1C21595;
	Thu, 16 Nov 2023 06:14:09 -0800 (PST)
Received: from [10.57.41.187] (unknown [10.57.41.187])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30C933F73F;
	Thu, 16 Nov 2023 06:13:22 -0800 (PST)
Message-ID: <5597da9a-abb7-4870-9f14-c83769297baf@foss.arm.com>
Date: Thu, 16 Nov 2023 14:13:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/5][BINUTILS] aarch64: Add new AT system instructions.
Content-Language: en-GB
To: Srinath Parvathaneni <srinath.parvathaneni@arm.com>,
 binutils@sourceware.org
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>, nickc@redhat.com
References: <8e6b9010-5a62-e00f-9afe-d86474343a2e@arm.com>
 <8dcf129a-88c8-198a-adbb-4da2e6403063@arm.com>
 <122e823d-6989-4b1e-bfa1-ce8b9a6de2cc@arm.com>
 <82c92cc2-bdb2-487c-b50f-05ec88f861d7@arm.com>
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
In-Reply-To: <82c92cc2-bdb2-487c-b50f-05ec88f861d7@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3489.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>



On 16/11/2023 11:38, Srinath Parvathaneni wrote:
> HI,
> 
> This patch adds 3 new AT system instructions through FEAT_ATS1A
> feature, which are available by default from Armv9.4-A architecture.
> 
> Regression tested for aarch64-none-elf target and found
> no regressions.
> 
> Ok for binutils-master?
> 
> Regards,
> Srinath.
@@ -245,7 +247,8 @@ enum aarch64_feature_bit {
  					 | AARCH64_FEATBIT (X, RASv2)	\
  					 | AARCH64_FEATBIT (X, SCTLR2)	\
  					 | AARCH64_FEATBIT (X, FGT2)	\
-					 | AARCH64_FEATBIT (X, PFAR))
+					 | AARCH64_FEATBIT (X, PFAR)	\
+					 | AARCH64_FEATBIT (X, ATS1A))

If you put the final closing parenthesis on the following line, then the 
next update will cause less churn in the diffs.

Otherwise OK.

R.