* [AArch64][5/8] GAS support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC
@ 2015-07-24 16:08 Jiong Wang
2015-08-11 15:29 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Jiong Wang @ 2015-07-24 16:08 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
2015-07-24 Jiong Wang <jiong.wang@arm.com>
bfd/
* reloc.c (BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC): New entry.
* bfd-in2.h: Regenerate.
* libbfd.h: Regenerate.
* elfnn-aarch64.c (elfNN_aarch64_howto_table): New entry for
BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC.
gas/
* config/tc-aarch64.c (reloc_table): New relocation modifiers.
(md_apply_fix): Support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC.
(aarch64_force_relocation): Likewise.
gas/testsuite/
* gas/aarch64/reloc-tlsldm_lo12_nc-1.s: New testcase.
* gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.s: Likewise.
* gas/aarch64/reloc-tlsldm_lo12_nc-1.d: New expectation file.
* gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d: Likewise.
--
Regards,
Jiong
[-- Attachment #2: 8-new.patch --]
[-- Type: text/x-diff, Size: 5803 bytes --]
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 60af8e9..c0abd62 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -5779,6 +5779,11 @@ BFD_RELOC_AARCH64_TLSGD_ADR_PAGE21. */
/* AArch64 TLS INITIAL EXEC relocation. */
BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19,
+/* Unsigned 12 bit byte offset to global offset table entry for a symbols
+tls_index structure. Used in conjunction with
+BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21. */
+ BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC,
+
/* GOT entry page address for AArch64 TLS Local Dynamic, used with ADRP
instruction. */
BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21,
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index d6ba9b5..126434c 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -942,5 +942,20 @@ static reloc_howto_type elfNN_aarch64_howto_table[] =
0xfff, /* dst_mask */
FALSE), /* pcrel_offset */
+ /* ADD: GOT offset G(S) & 0xff8 [no overflow check] */
+ HOWTO (AARCH64_R (TLSLD_ADD_LO12_NC), /* type */
+ 0, /* rightshift */
+ 2, /* size (0 = byte, 1 = short, 2 = long) */
+ 12, /* bitsize */
+ FALSE, /* pc_relative */
+ 0, /* bitpos */
+ complain_overflow_dont, /* complain_on_overflow */
+ bfd_elf_generic_reloc, /* special_function */
+ AARCH64_R_STR (TLSLD_ADD_LO12_NC), /* name */
+ FALSE, /* partial_inplace */
+ 0xfff, /* src_mask */
+ 0xfff, /* dst_mask */
+ FALSE), /* pcrel_offset */
+
HOWTO (AARCH64_R (TLSLD_ADR_PAGE21), /* type */
12, /* rightshift */
2, /* size (0 = byte, 1 = short, 2 = long) */
diff --git a/bfd/libbfd.h b/bfd/libbfd.h
index 2c82eec..f76d860 100644
--- a/bfd/libbfd.h
+++ b/bfd/libbfd.h
@@ -2746,6 +2746,7 @@ static const char *const bfd_reloc_code_real_names[] = { "@@uninitialized@@",
"BFD_RELOC_AARCH64_TLSIE_LD64_GOTTPREL_LO12_NC",
"BFD_RELOC_AARCH64_TLSIE_LD32_GOTTPREL_LO12_NC",
"BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19",
+ "BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC",
"BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21",
"BFD_RELOC_AARCH64_TLSLD_ADR_PREL21",
"BFD_RELOC_AARCH64_TLSLE_MOVW_TPREL_G2",
diff --git a/bfd/reloc.c b/bfd/reloc.c
index 62101bc..c3438eb 100644
--- a/bfd/reloc.c
+++ b/bfd/reloc.c
@@ -6818,6 +6818,12 @@ ENUM
ENUMDOC
AArch64 TLS INITIAL EXEC relocation.
ENUM
+ BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC
+ENUMDOC
+ Unsigned 12 bit byte offset to global offset table entry for a symbols
+ tls_index structure. Used in conjunction with
+ BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21.
+ENUM
BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21
ENUMDOC
GOT entry page address for AArch64 TLS Local Dynamic, used with ADRP
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index c01ec6d..a633b04 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -2513,6 +2513,15 @@ static struct reloc_table_entry reloc_table[] = {
0,
0},
+ /* 12 bit offset into the page containing GOT TLS entry for a symbol */
+ {"tlsldm_lo12_nc", 0,
+ 0, /* adr_type */
+ 0,
+ 0,
+ BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC,
+ 0,
+ 0},
+
/* Get to the page containing GOT TLS entry for a symbol */
{"gottprel", 0,
0, /* adr_type */
@@ -6778,6 +6787,7 @@ md_apply_fix (fixS * fixP, valueT * valP, segT seg)
case BFD_RELOC_AARCH64_TLSIE_LD32_GOTTPREL_LO12_NC:
case BFD_RELOC_AARCH64_TLSIE_LD64_GOTTPREL_LO12_NC:
case BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19:
+ case BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC:
case BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21:
case BFD_RELOC_AARCH64_TLSLD_ADR_PREL21:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_HI12:
@@ -6989,6 +6999,7 @@ aarch64_force_relocation (struct fix *fixp)
case BFD_RELOC_AARCH64_TLSIE_LD32_GOTTPREL_LO12_NC:
case BFD_RELOC_AARCH64_TLSIE_LD64_GOTTPREL_LO12_NC:
case BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19:
+ case BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC:
case BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21:
case BFD_RELOC_AARCH64_TLSLD_ADR_PREL21:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_HI12:
diff --git a/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.d b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.d
new file mode 100644
index 0000000..9054036
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.d
@@ -0,0 +1,10 @@
+#objdump: -dr
+
+.*: file format .*
+
+Disassembly of section \.text:
+
+0000000000000000 <.*>:
+ 0: 91000000 add x0, x0, #0x0
+ 0: R_AARCH64_TLSLD_ADD_LO12_NC x
+
diff --git a/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.s b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.s
new file mode 100644
index 0000000..676bbfc
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.s
@@ -0,0 +1,5 @@
+// Test file for AArch64 GAS -- reloc 519
+
+func:
+ // BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC
+ add x0, x0, #:tlsldm_lo12_nc:x
diff --git a/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d
new file mode 100644
index 0000000..f068cfb
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d
@@ -0,0 +1,11 @@
+#as: -mabi=ilp32
+#objdump: -dr
+
+.*: file format .*
+
+Disassembly of section \.text:
+
+00000000 <.*>:
+ 0: 91000000 add x0, x0, #0x0
+ 0: R_AARCH64_P32_TLSLD_ADD_LO12_NC x
+
diff --git a/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.s b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.s
new file mode 100644
index 0000000..2556276
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.s
@@ -0,0 +1,5 @@
+// Test file for AArch64 GAS -- reloc 85
+
+func:
+ // BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC
+ add x0, x0, #:tlsldm_lo12_nc:x
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [AArch64][5/8] GAS support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC
2015-07-24 16:08 [AArch64][5/8] GAS support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC Jiong Wang
@ 2015-08-11 15:29 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2015-08-11 15:29 UTC (permalink / raw)
To: Jiong Wang, binutils
Hi Jiong,
> 2015-07-24 Jiong Wang <jiong.wang@arm.com>
>
> bfd/
> * reloc.c (BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC): New entry.
> * bfd-in2.h: Regenerate.
> * libbfd.h: Regenerate.
> * elfnn-aarch64.c (elfNN_aarch64_howto_table): New entry for
> BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC.
>
> gas/
> * config/tc-aarch64.c (reloc_table): New relocation modifiers.
> (md_apply_fix): Support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC.
> (aarch64_force_relocation): Likewise.
>
> gas/testsuite/
> * gas/aarch64/reloc-tlsldm_lo12_nc-1.s: New testcase.
> * gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.s: Likewise.
> * gas/aarch64/reloc-tlsldm_lo12_nc-1.d: New expectation file.
> * gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d: Likewise.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-11 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-24 16:08 [AArch64][5/8] GAS support BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC Jiong Wang
2015-08-11 15:29 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).