From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <i.swmail@xen0n.name>
Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31])
	by sourceware.org (Postfix) with ESMTPS id E4D2E3854801
	for <binutils@sourceware.org>; Tue, 30 Aug 2022 10:18:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4D2E3854801
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail;
	t=1661854695; bh=BTb7YXsuFG7A/iGnlkNzRlYtTP43do5T6IlekTT9blc=;
	h=Date:Subject:To:References:From:In-Reply-To:From;
	b=ggwbn0+lV7Z4IEiQYlL8f7zuBOVTQXa9lHvZRSzvr2vpg1qjRzDfqfQm+3/v/9bRo
	 Jt9HaotWym2tOTW3ELGLYBTf2cTfWYYfC77iZ1mZk5xDDPHcW9vx9iIVkn37FmAoYb
	 TH8+VJVG/u+4x4p6VMpHVQnFjTPldQyKA/Akh1AE=
Received: from [100.100.57.219] (unknown [220.248.53.61])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 3509A600D4;
	Tue, 30 Aug 2022 18:18:15 +0800 (CST)
Message-ID: <560d49d4-c024-a9bd-b39c-2dbc31b5f174@xen0n.name>
Date: Tue, 30 Aug 2022 18:18:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:106.0)
 Gecko/20100101 Thunderbird/106.0a1
Subject: Re: [PATCH] LoongArch: Fix bug "PACKAGE" redefined.
Content-Language: en-US
To: liuzhensong <liuzhensong@loongson.cn>, binutils@sourceware.org
References: <20220830064311.3650494-1-liuzhensong@loongson.cn>
From: WANG Xuerui <i.swmail@xen0n.name>
In-Reply-To: <20220830064311.3650494-1-liuzhensong@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On 2022/8/30 14:43, liuzhensong wrote:
>    Running configure and make in binutils-gdb.
>
>    $ ./configure
>    $ make
> In file included from ./as.h:37,
>                   from ./config/loongarch-lex.l:21,
>                   from config/loongarch-lex-wrapper.c:20:
> ./config.h:206: error: “PACKAGE” redefined [-Werror]
>   #define PACKAGE "gas"
> ...
>
>    gas/config
>    *  loongarch-lex-wrapper.c
> ---
>   gas/config/loongarch-lex-wrapper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
The patch title could be simply "Fix redefinition of PACKAGE".

Otherwise okay.