From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 944923858C60 for ; Mon, 22 Apr 2024 06:51:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 944923858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 944923858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713768708; cv=none; b=w+aGvX1BVaNKSeIJeNX7z+uFAjjUMsL7gNP9egIfNr5TDuUHN1pnE30GASyyIopllI6AD8oBg+B82GbxLwFoB+eNxbT47Wvn8oIYPZK20wd4lEDHywRfcUyYXthPl8zo21a0oYguuVthSMZYZ47/cxaJYLscnN0/yLPyGy4o7qw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713768708; c=relaxed/simple; bh=eGcyUWMT5Q67o0ySzQ1DZnWz8eanVjuo8IrZ5F17X0o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=c8IeZtHHkdilCduUchVjoGqsTjIhyHuFeV8E17e1d3TfhSngxqg+4W8cA3+Z4gw7wEAWQNkCOlO8TbF/fT8lCM4mYMMyX+EyYuRodexmH/8pMW/paTfk++7pl/fF5YeTWUMnXeEFxTsIaILM/+E2M3vUkk5dDBjtkT788SxwpXQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-41a7820620dso1480735e9.0 for ; Sun, 21 Apr 2024 23:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713768705; x=1714373505; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=eGcyUWMT5Q67o0ySzQ1DZnWz8eanVjuo8IrZ5F17X0o=; b=gyXZ0aVA5G8Js6H2hHAvLA25ScUvVjIvngO/kCJagjZTIlLgyJRA+JACQre0S0YIC5 LiYym02Nfaq0TMLJF9RkOK0Hz8M5L1CqJ82plii0OStK2AwJ0Qgp8dbJBpM29lf3Z6NI PkZWX76EizCqzWlSV7mNU/VOIlDEjuxRGkpHVvhU/mSpjg+K/f/EAdf3WqYTe8b+7zw0 lmqzT2gQb1p+drMQPF2q3eJUgeuzsbnks3NJhsta50cReJ+N4zFtqiODZRonp8RUE9Cn meiW8igzyW63+GGdH5P9wAMpPqWdrPOT8jKIV5PehGeQ2kyXTJPgbrLPSdC7Vto76YF4 Kr/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713768705; x=1714373505; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eGcyUWMT5Q67o0ySzQ1DZnWz8eanVjuo8IrZ5F17X0o=; b=ubP2sFo3YxS6njID0Be+Bb1DtnZSq1HJYLjy45UtueizwlSqwj8Rl3SVkDLGJGukaH 6HkZz7QEldctpHSs3lxhv0jSYyytgWVzmFnQQHkgjUH0UcJka7GOqVtw5Nw+uIpuLxk0 ZkZ8TSkzA36tS5yYb3aHyfFITOXKoRtHX89yhxOCoQawvsyouSf2YR0I+MX9U4o8i39z i1p/EAnOgzn63P+8rdkLv5FvepgfBMdrxRF9vZVAKffgfQ6pz2X7PT1k/dHQcn4NBJer HNUvMutlCD3fPZ/gJufR7nZ+1WPyn2VPjSkyT17xEZ7wrc+3y8CAl/vkxW9clEz+4hG0 BwbQ== X-Gm-Message-State: AOJu0YxzGTTGBTg0qgTUpGRZjp1+UYfCzdD7Y2cDefYBsop4WYh9R0uk pVbKOfQiJqw85zrrU5pa2iukZ8SDqr+LbgIz3ChVubZ7pumvO1P1iAuT//ux9w== X-Google-Smtp-Source: AGHT+IEAsEvo141Aq8W1pu+P1BeGY+jC7x4Wb8YaAF4iNnoz7GX5m+1aSBftzBWGkoRgM8d47zK3DA== X-Received: by 2002:a05:600c:5403:b0:418:be2e:df9e with SMTP id he3-20020a05600c540300b00418be2edf9emr8752003wmb.41.1713768705249; Sun, 21 Apr 2024 23:51:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id iv19-20020a05600c549300b004186c58a9b5sm15303985wmb.44.2024.04.21.23.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Apr 2024 23:51:45 -0700 (PDT) Message-ID: <563b29cc-d3b5-45b7-b354-1ca8f3a2dcf4@suse.com> Date: Mon, 22 Apr 2024 08:51:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/Intel: SHLD/SHRD have dual meaning To: Hongtao Liu Cc: Binutils , "H.J. Lu" References: <117c9c1f-795e-41f9-b582-b8477b42bebd@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.04.2024 06:09, Hongtao Liu wrote: > On Fri, Apr 19, 2024 at 5:29 PM Jan Beulich wrote: >> >> Since we uniformly permit D suffixes in Intel mode whenever in AT&T mode >> an L suffix may be used, we need to be consistent with this. > I think we need to forbid the D suffix for APX NDD SHL/SHR under Intel > mode to avoid ambiguity. Hmm. Special casing just two insns is out of question imo (in fact that's what is - unintentionally - partly happening prior to the change here). > Neither SHL (always SAL), nor SHR with a D suffix (Intel mode) is > generated by GCC. While this may be deemed helpful, I actually view it as a mistake, even if only from a cosmetic perspective: SHL is the main insn; SAL is merely an alias (questionably using extension opcode 4 rather than 6 in gas). Still extending what you suggest - limiting the restriction to APX - may be an option, albeit ... >> --- >> The alternative, more intrusive and more risky (in terms of perceived or >> even real regressions) route would be to mark the few insns which permit >> suffixes even in Intel syntax, and reject suffix uses when that >> indicator isn't set. ... as implied here I'd still consider this inconsistent. Furthermore the point in time when suffixes are processed off of the incoming mnemonic is too early to know whether an insn is having an APX representation. Hence doing said extension of what you suggest would likely end up quite hacky. Jan