From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by sourceware.org (Postfix) with ESMTPS id 36C6C3858438 for ; Thu, 28 Sep 2023 08:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36C6C3858438 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqODwZmHXkldRjXRJad8MQUIUBO141NL0pl/9e3cNdyQu/dzhgGD12IfP7b5LEeYMzZNaGqh7lu2wt5QOKeGbgzVDi3e3QSMFKbd9ZOWWwIUGISKv+SSD+gqEw7Z+Ipl818m6E679Bn3ScVUFh9Q2ZUqRqTdgX4F0PGlNcHKf6/VrjPBReodwVN6X+qWu+cWHGrtUxQxi7Hknc8EKTbTMJ+c8D0XFTtM8Il1v7tMge49FryOp2iEkv5ZdCeyvzVViBjVrhe7DmPoTpgUfI1tDSYr1AZgyGp3uwTKRhsr1CR5oiBj3jmxbsycE8tPsXTyqTRV9PizAWTRe25XCM6OCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wEYAF/iFC1uZqSIro3Fm8zAEIv15KWvZoVvqzdSeZ5w=; b=AoR56N5X1hMcownpc1xTMPnFjeHwU87ci0bBg52P1g4Ly+Q4O8s1UzGCuRbwfQKD5ll1ZP2J9AvnBcsylmJ6ueMSqdG//A6f23PogtVn6O7PvAOiM9y++75s+rl5xQU0SCGgzOFE4qLwT0q11wgGZg0Kb04yJ1ZLNO+HDquM6roxD1+96xyd+F1yzK9r8AcInyiJva5kzCcZ7XzlWr/BZJofAPwCG7ZHSLXRcyypKy0hbdj+2xXP0KLjy6tOX73fCgwa2mkUUCXDl+4UkYSyjb3VwfRLh55JFTUrdn4gHo9I7f6BwlFAtcOnChB5LOC6WpYntH3XzBdt5OHv1/qJ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wEYAF/iFC1uZqSIro3Fm8zAEIv15KWvZoVvqzdSeZ5w=; b=PUWLgLUmh4EePvutA1KDV/MNoHLHY5YGgIzll/uyqJ+1QfQ7PpP3z73Q52yaAdCUuJUj8aM58LU4034bGaPdEBVhVfaEA69LMNFLsGqLnCVi3q+/rZt0HiIGvXW+NYFLxtYhg4yPph2dydFTL6CzcRCrSKe8dVistbjl4825Z683P2qbhWFfOj3rPYU7pcvX3veK6VZbfGYT9tQdxDMM8564L3lvkHm6xWLRb8ErGKcW1S9eSzqKyjC9v5vI5U1951FE7nfOQpg22SkDidoJx0Lc0R0RAy4nSxOumKjCvAswFAa6LyoAxY3iL1Mkc4Zk1gKAH+xCZECS5iRIYoV70w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9681.eurprd04.prod.outlook.com (2603:10a6:20b:480::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Thu, 28 Sep 2023 08:03:01 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9f5d:8bed:7a5b:e75a]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9f5d:8bed:7a5b:e75a%6]) with mapi id 15.20.6838.016; Thu, 28 Sep 2023 08:03:00 +0000 Message-ID: <5682d134-98c7-77b2-cb91-ff886d0e7240@suse.com> Date: Thu, 28 Sep 2023 10:02:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/8] Support APX GPR32 with rex2 prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-2-lili.cui@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9681:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bfe8578-aafe-410b-71b1-08dbbff95573 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n7jqUxQeLO9jUDbPhxtNEW+u9ZYZy5pgGKydee5KwMlctebnTYGvuPiZF4uuPhcFa4+WWtuzSLWWLk/7xO6d5ePAqmHAaQ9P0HQtsSYSbb421a25PKGQl3yRNUBzGnO1bmr7Mp/CzAKB7gf0cnaPXyP3QgCNQIFSzc8VdPchlYntg5bfTwHN+bbL7vbIo+wGQxtdpih0urXnE+qD8Q4ZhAMz1/FXuIbPpf9AYJaf3MS/q3mo2OUbTfe5WyK+uJOAz0ad8KE4xt4xZ6TpL1W6SFTnjBMhEDfEta0rkbfgd+bXBOST5TW8UUr7Yvv3s9WMwxfDocLWPAOookaYBheCRdDsLd1iJRNgvqPeTza0VD5CVNMPdArGRX9y0awnTeWWSyJBeUjOcRhGB+/pWTNCCOWm21P6i99NSHyISacOS93Gu28YITVwSeNP7ewVl7MEku54ntAtbwz5mVlzMEU2K2QYFVx4NeF1cCyaeA5D/H8Mrhx+9UZZTntgzkdrhOLAEjBDBl/2cONSezRQybBbNp0iYfrenP49EWwZSX84Io9HsXrYL5c/A9QbcZoE6wua1vzAecGXXVz8wbcWOwXQ5DGGV02hrUBmPIFiHU440nL6kmrJsPi8i4I57UCMW/epvy5s9jrDzJ+9KkE60xb/yA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(396003)(376002)(136003)(346002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(6512007)(31686004)(83380400001)(6916009)(5660300002)(2616005)(2906002)(8936002)(41300700001)(6506007)(36756003)(8676002)(4326008)(66556008)(38100700002)(86362001)(53546011)(66476007)(31696002)(66946007)(26005)(54906003)(6486002)(478600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmQ1NmRkRXpVMDQ2WkdDdi9ncVdVSDB2RktweWExZ3VWNkE4bmpYcDQ3RGp4?= =?utf-8?B?eVdOVFBTMlNSOEl5WXlVRUFFNlFibDk5ZTJLSTVJR3ovVFVXT1k1SzFJN3hL?= =?utf-8?B?OXRCSU1RV1pqQ1MrclFLU3FSWm51MHJQaXRnNXpuazV6Lzh1RUZmY2pRUk9G?= =?utf-8?B?T2N2NkpxUWUyRGR3U0NuT1pTUjQzYUVBWWR2NE00ZWczS1hQeS9aYU0zcDVF?= =?utf-8?B?RkJJVUFDR2tnNityOHVGa1NtcDhKYmo5V1dpUEhYTHZ6cU0zNWl2RCtHeU80?= =?utf-8?B?OXZ6RThVUEdveTRVbzZxamdZSUlRZ0wvWGlXSEdKNStnc2RiZ2p3UGhReUZl?= =?utf-8?B?VldRZVhrUmZudjM5S2lENkR3Wk9Fd1d1MHJ5QklhVkRNaXVxRlowV3hubWx3?= =?utf-8?B?VFh1dlR0UWRsRUJ5ZzUra2QrZVNlb2h3ZGRMS1pHT2hkM0NhcjZjRDYvTUlx?= =?utf-8?B?WXc3bmFWQStDaWxtUjVheGdqOHYvQUxFZGgwSmdvVEdHOGR3TGNsdlRSUnJx?= =?utf-8?B?d2p2T3NDejJaWEJtcGoxNnZ2ZlI4WVE4eTYrOVAvdXpLYVBVK2ppb2diQUQx?= =?utf-8?B?ei9iSXBVUnpaMlRmYnlMZGxjSjVOUjFGUHBRMXp1R0RxUWYrOS9vd2hOUVFF?= =?utf-8?B?Sk1BYzlJWkIySmVqSE1hSVZibGZsaTVFaVUrbXArM1JXYW9jUkFQTEwzRVYx?= =?utf-8?B?bm5oRHpac1NMc3gzWjVONFRTTGt3ZkU1dHBHRzQ2ZndYeU9NSk5laUh3QzdM?= =?utf-8?B?OHRZdnlyK2R2ZExJZmVsZXhNelFhSm92QTVsSHNNdklxSFB0bnFEbERlVDho?= =?utf-8?B?ZkVTWHRaQmh4aHZvUkcvQlRNR1dwSVIvWGpKYjJ6dE5rVnBldk8yVy93RVNs?= =?utf-8?B?akFOR09wSlpHRzVLVER2STgzRnRpdnpGaURNOUV6U2QyVWxjc2YvY20xL21Y?= =?utf-8?B?S3ppNE0zU0ZvVlBkRlR3MEdSVXZGMFNYajAyN0U0NHBUSjBiODR4SE1QSU1I?= =?utf-8?B?NVZOOTUwcWlBSzEwNW5qSnZtdTdKVm5rWDhMYmV4SEF4OW9NQmZwR2RTNE5C?= =?utf-8?B?UVhJM0ZrUjBnVFZrWVI3aTA5dmNRVFVvQjhPdW9NaUs0YlJid0VuZjdVVk13?= =?utf-8?B?QWE5b1ZXdjVvbjFiRjlEQW0wdFcxRS9UOGRReFNZbWxCcUV2bDhMazZzV0FN?= =?utf-8?B?ZC9UL2ZlK1ZIRFdrc0Rma3N0RjFHdWVTeFVKNWRmbDNHNFMraTcyVjJyRUo1?= =?utf-8?B?YkFMTnQwV2ljeEdjQ0IxcjdmOW1odnhjYUtmc3hzMGthOVVJUS9iYm5zM3da?= =?utf-8?B?OWMrNDVuamxnSERPQ0IzbHUxcGFsZjhlbXdvWnE2UzRHYVJPTDQ1OVY4NnRZ?= =?utf-8?B?WGNRcHNrUVVsMGo4VU9GcVcxQWFFMTFYTUZvQllPMUo0TittR0hCWG1BQTdm?= =?utf-8?B?SVFSN0hWSFAreXBaaFJlYlA4U1p1bi91bjFDYU5kdG9NdnRkczQ2MFUxbElj?= =?utf-8?B?N2gyd1p2ejJJRlpNZXpoQ0k4OXgrblllbWoxY3BYWGsvOVZZK2xMdWxjWE95?= =?utf-8?B?RXJMUHFibGtHL3NjSnBmQ1Bpb3dFTXN3dnkzVWZQRmZqcTRmcDc4ODF5VHR3?= =?utf-8?B?VVh6dWpHM1FJaGxZbEFWTjhVbFNBa3pHL1BBNDNReDdXM2FsTTRBYWt4ZHlP?= =?utf-8?B?cmVadGpSeFo1TTJTSDQ3cFVpZFpTeU9oTHIzcmVaQXEzR3lReG1CZmI4Y3Ay?= =?utf-8?B?OXZxRmRFb1FkbU5KYjQ4UDdMdmxEbmFIR1dPRGdlNXJZYUhteXl5ZHMrdWRq?= =?utf-8?B?SEk5UkxNT1dPb1Rld1JEZXVUaVc5RnR3K3FaencyaXRGZzAyRzhMVjdwVzlm?= =?utf-8?B?S0VGMVdRTXF0ZlRwN2FxbVQ3VmJJeFhxVkt5bnlBOUNsUlhadlJBZ2p2ZFRr?= =?utf-8?B?M3RrTG95Nk04REpSeUhMSkp4OXp4YWpaKzZIeTRJWm0zcEdRZHlaMFFLY0hH?= =?utf-8?B?VlJSUkt6YW05elNvODN5Rzd4N21XT29RYk1NeXlNWCs1TTVWMFJHcmxTOUQx?= =?utf-8?B?ZEh3Mjg4aVFqRTRaMW9kbXA5N2l0N3RzR3AzNVl3MG91SmwzdDZDWlUyK2l2?= =?utf-8?Q?WeUiBplJiR3cctIJaCOcDdhhm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bfe8578-aafe-410b-71b1-08dbbff95573 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 08:03:00.6068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vMCdXhn+8ozaXvP2ozQ70l3ByOegerOGktuez1eK6jLevvaGhYmb36p8jiapJxP1DpSLfwuGpAsrODf251EWKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9681 X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.09.2023 17:59, Cui, Lili wrote: >>> @@ -367,6 +381,7 @@ fetch_error (const instr_info *ins) >>> #define PREFIX_IGNORED_DATA (PREFIX_DATA << >> PREFIX_IGNORED_SHIFT) >>> #define PREFIX_IGNORED_ADDR (PREFIX_ADDR << >> PREFIX_IGNORED_SHIFT) >>> #define PREFIX_IGNORED_LOCK (PREFIX_LOCK << >> PREFIX_IGNORED_SHIFT) >>> +#define PREFIX_IGNORED_REX2 (PREFIX_REX2 << >> PREFIX_IGNORED_SHIFT) >> >> I don't think "ignored" is what you mean, considering ... >> >>> /* MOD_0FAE_REG_5 */ >>> - { "xrstor", { FXSAVE }, PREFIX_OPCODE }, >>> + { "xrstor", { FXSAVE }, PREFIX_OPCODE | >> PREFIX_IGNORED_REX2 }, >>> { PREFIX_TABLE (PREFIX_0FAE_REG_5_MOD_3) }, >>> }, >> >> ... these uses here. >> > > Replaced " PREFIX_IGNORED_REX2" with "ILLEGAL_PREFIX_REX2 ". May I ask that we keep PREFIX_ first, i.e. PREFIX_ILLEGAL_REX2 (or PREFIX_REX2_ILLEGAL)? > Finally, thank you for checking these large patches so carefully. The next few days are China's national holidays, which last about 8 days, my feedback time will be longer. Thank you. Oh, that fits nicely with me taking vacation the next two weeks. Jan