* [Patch, testsuite, avr] Make testcase pass for long source file paths
@ 2016-03-17 13:56 Senthil Kumar Selvaraj
2016-03-18 9:53 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Senthil Kumar Selvaraj @ 2016-03-17 13:56 UTC (permalink / raw)
To: binutils; +Cc: Nick Clifton, Denis Chertykov
Hi,
This trivial patch fixes a test failure that shows up if the source
file path is long.
objdump skips the "CU :" prefix and the directory part when printing
source file path for a CU's line number table, but the testcase
always expects it to be present. Since it doesn't really validate
anything in that line, I've relaxed the regex to only look for a
trailing semicolon.
And no, the --wide option doesn't help - the printing happens in
dwarf.c, which uses a do_wide variable that isn't set from objdump.
If this is ok, could someone commit please? I don't have commit access.
Regards
Senthil
ld/testsuite/ChangeLog
2016-03-17 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* ld-avr/gc-section-debugline.d: Relax regex check
for CU :.
diff --git a/ld/testsuite/ld-avr/gc-section-debugline.d b/ld/testsuite/ld-avr/gc-section-debugline.d
index 147ae42..5daf915 100644
--- a/ld/testsuite/ld-avr/gc-section-debugline.d
+++ b/ld/testsuite/ld-avr/gc-section-debugline.d
@@ -9,7 +9,7 @@
Decoded dump of debug contents of section .debug_line:
-CU: .*:
+.*:
File name Line number Starting address
per-function-debugline.s 39 0
--
Sent with my mu4e
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch, testsuite, avr] Make testcase pass for long source file paths
2016-03-17 13:56 [Patch, testsuite, avr] Make testcase pass for long source file paths Senthil Kumar Selvaraj
@ 2016-03-18 9:53 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2016-03-18 9:53 UTC (permalink / raw)
To: Senthil Kumar Selvaraj, binutils; +Cc: Denis Chertykov
Hi Senthil,
> This trivial patch fixes a test failure that shows up if the source
> file path is long.
> ld/testsuite/ChangeLog
> 2016-03-17 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * ld-avr/gc-section-debugline.d: Relax regex check
> for CU :.
Approved and applied.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-18 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-17 13:56 [Patch, testsuite, avr] Make testcase pass for long source file paths Senthil Kumar Selvaraj
2016-03-18 9:53 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).