public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] localize string returned from visium's md_atof ()
@ 2016-03-23  1:29 tbsaunde+binutils
  2016-03-23 13:18 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: tbsaunde+binutils @ 2016-03-23  1:29 UTC (permalink / raw)
  To: binutils; +Cc: Trevor Saunders

From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

Hi,

I'm not sure the string it returns is particularly useful, or better than the
string returned by other atof implementations on failure, but given the others
return a localized string it seems like this one should too.

 If someone has a better idea for the string here that would be good, and I'm
not really sure if I need to do more to get the string localized.  However at
least this patch calls attention to the issue :)

I tested a cross to visium-elf still builds, ok?

Trev

gas/ChangeLog:

2016-03-22  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-visium.c (md_atof): Localize the string returned on
	failure.
---
 gas/config/tc-visium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gas/config/tc-visium.c b/gas/config/tc-visium.c
index 3758a35..f4e7c14 100644
--- a/gas/config/tc-visium.c
+++ b/gas/config/tc-visium.c
@@ -861,7 +861,7 @@ md_atof (int type, char *litP, int *sizeP)
 
     default:
       *sizeP = 0;
-      return "Bad call to MD_ATOF()";
+      return _("Bad call to MD_ATOF()");
     }
 
   t = atof_ieee (input_line_pointer, type, words);
-- 
2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] localize string returned from visium's md_atof ()
  2016-03-23  1:29 [PATCH] localize string returned from visium's md_atof () tbsaunde+binutils
@ 2016-03-23 13:18 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2016-03-23 13:18 UTC (permalink / raw)
  To: tbsaunde+binutils, binutils

Hi Trevor,

> 2016-03-22  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* config/tc-visium.c (md_atof): Localize the string returned on
> 	failure.

Approved - please apply.

Cheers
  Nick

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-23 13:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-23  1:29 [PATCH] localize string returned from visium's md_atof () tbsaunde+binutils
2016-03-23 13:18 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).