From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5EFB93858D39 for ; Mon, 1 Aug 2022 11:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EFB93858D39 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-209-nWaGRADwMjCcrsbvIsHHjw-1; Mon, 01 Aug 2022 07:10:52 -0400 X-MC-Unique: nWaGRADwMjCcrsbvIsHHjw-1 Received: by mail-wm1-f71.google.com with SMTP id k27-20020a05600c1c9b00b003a2fee19a80so7974673wms.1 for ; Mon, 01 Aug 2022 04:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=XZXzQ/8cLKDd2LCal4zIXptKaKO6LLWQNVZ1A7uOEsQ=; b=nkV4VFUaFEGW2odAz73b34ReJuNaug0bqir8CBd5xmANoanJRMiHzf97mYsnnH7Nxc TOOFIwdSK3GOPF6fTrXuqBuFVMYEYN7VjcHQcKDHCzWHgQ3XfXRJKDbnFPTuFiiOeX36 0jCUmg3ZnXaoLMSE38lu/GLJ8RW+ZC2NVVcmQ0GJx6O0tJ7iK8nxODNqrPutCRqseTUT Dr9SFPPeYLRhurz/r9Et10qxf6vCRN8CyHdJGET3jN6x6nPWkwxyPBaN/ZI7nu0dL7LI mkGSoAScnvnco4a610Bt/4ISn6/fw/PNwwsoLbwaFskTsJe6unHqwgi0EEsWxtxQ3TiS CHUA== X-Gm-Message-State: ACgBeo3RJcnRFxeI0Ur9fTMbeBg0HLSl07AR8gfHJ/0LEFWLQiYhxXBP 47BbhmyuEfsYjFAM8R0AGwstAetr2YKBaeSRV+bZkGHSbSeRRb2e/l/NxNqWYe0vcwEiq69rnme QhDE4O09QkHcma4IvHQ== X-Received: by 2002:a05:6000:42:b0:21f:dc5:5ce0 with SMTP id k2-20020a056000004200b0021f0dc55ce0mr10199446wrx.12.1659352250775; Mon, 01 Aug 2022 04:10:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5eOW10ChivyYxNT+hk6razaIiHy9EKimIqNOTqUNvVxJ+OswZZkzzbHSDKfmSgxcV50mD5pA== X-Received: by 2002:a05:6000:42:b0:21f:dc5:5ce0 with SMTP id k2-20020a056000004200b0021f0dc55ce0mr10199440wrx.12.1659352250624; Mon, 01 Aug 2022 04:10:50 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id n2-20020a5d51c2000000b0021badf3cb26sm13669859wrv.63.2022.08.01.04.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Aug 2022 04:10:50 -0700 (PDT) Message-ID: <56cde846-f34f-72dc-7641-4bba6f544b06@redhat.com> Date: Mon, 1 Aug 2022 12:10:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Jojo R , binutils@sourceware.org References: <20220729074837.82957-1-rjiejie@linux.alibaba.com> From: Nick Clifton Subject: Re: [PATCH] Support multiple .eh_frame sections In-Reply-To: <20220729074837.82957-1-rjiejie@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 11:10:54 -0000 Hi Jojo, > This patch is based on MULTIPLE_FRAME_SECTIONS and EH_FRAME_LINKONCE, > it allows backend to enable this feature and use '--gc-sections' simply. This patch looks good to me. But there are two issues, one small, one major: * The small issue is that you need to add an entry to the gas/doc/internals.texi describing the new TARGET_MULTIPLE_EH_FRAME_SECTIONS macro. (I know that the name is basically self-describing, but it is nice to keep the documentation accurate). * The bigger issue is that I could not find a FSF copyright assignment under your name, or for Alibaba. We would need such an assignment before we could accept your patch. (Note - I did find an assignment for Alibaba contributions to gcc, so I would assume that obtaining a similar assignment for the binutils should not be too difficult). Cheers Nick