From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80053.outbound.protection.outlook.com [40.107.8.53]) by sourceware.org (Postfix) with ESMTPS id 4D6E13858D32; Mon, 19 Sep 2022 09:14:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D6E13858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z5eWQ+nKZ7eocQxCez0/RSo6CdNpELmRt8g6vLFc12zUJ2sCP3uvXFN7BSiJWSSpxrNQxikSohxNg/wWrQDs/LXwU5CesX9qQqsKEeUyz2F5grgDKKv15ip+i2yvu4OgVSx/brKKsULNfIi2Q7kSeoZXew60//BMAg7Ra8hn1mQmmfCrP1I2RMPZXHNK0/a7OglSdwtQ0ccW5whdtnzIOrB/6eTGsy7ixlhleyOM6fz32uwxUm1YHrqD9kUuucvEEutvE9I6QHLGMCmWy5o1P5N9fsFk13gMggtj9AP3a1ZrQZRLfIP4nVgRvG3sJ0zKg9Z1QPFPlWsLcuaLDXgQbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4+qqYPiFtCTEKS4N4fRl+iza4JzAmgDIQbjScspdDY8=; b=m6tTdznqEjfDtkjH9iywXW1otSM9BT1ZUoRgveTSRgz9/LzeSJZfnX+KkVLmSOdjuxXSoPno70XOVVVbMswGxddWENQOrY5Y6OHMQD/sTsxusQMpaTMaDSaQTvk1hyhxeUD+vPZUr5RiDlnrmnfte5VoAyUFgeNXTPW5jjDn67sgUZfK8/ILL+3VjK0mOwPGhj9dUfmyg0Ar7TK+cIHm8iugY7lbWawKoi0TCc9QOSXtnw4azZOgfjoQ2JeaCX3YH4e/ErsIi7xDCLq4E2ypeEcytiA3mGQ6LRi0tLIPaBvZPTn4OrTNgZtKggmWkPfWHDKHBIGXKefUKVO1URpp9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4+qqYPiFtCTEKS4N4fRl+iza4JzAmgDIQbjScspdDY8=; b=nrqOzk8VlLd4nCMy0h4NDZYYNFGmykYOzDT+5wsPqCizAZxJ9Emc6smOW6qO7Z7m1qyPWGQBnOaj8TOu+vsBfQJCU7JTI/iNHG9a3b5TSFogurSVIV7hHc17BTxCIU+u50sxEdCM8kpAvOsGcra6kihNnD/EdLCbI2GBxgMuE5V5T30nB1XBqawODu1YplDSZZWB0BlrX5FnIm1LOua9oa8lyN4eXOYAFgN74gLu/30Q5+BBF8lGxqdZFsrY2uZhONpwwT4UOmkFrbIHTdi9hRVlyCDBfo2ZgsMFnoT1WvN7I3JybPvquv93WDEPTfqX6rlGokJU82lBmy5r9AkZJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8306.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Mon, 19 Sep 2022 09:14:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5632.021; Mon, 19 Sep 2022 09:13:59 +0000 Message-ID: <56fc56b4-5e36-5225-3bc4-25b548d6116c@suse.com> Date: Mon, 19 Sep 2022 11:13:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] binutils, gdb: support zstd compressed debug sections Content-Language: en-US To: Simon Marchi , Fangrui Song References: <20220919040115.31326-1-maskray@google.com> <15fe4352-79e1-acd5-5a71-fc40e19047a8@simark.ca> Cc: binutils@sourceware.org, gdb-patches@sourceware.org From: Jan Beulich In-Reply-To: <15fe4352-79e1-acd5-5a71-fc40e19047a8@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0507.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8306:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e693975-8f9e-463d-079b-08da9a1f49a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uHuBy2pxolq99MYl/6CfAdV217sNki31bfekcaqe4CTcD/DirLgSddAc72IP9z04PRXkZUZk6RbNUxSeWi3XzdH3ssKCSkkR8VXBvHN4nDvmcgXTlbWWWI5E4Bk8g+bfJO5dpQ7Vwc+rkeyuO4lZrQcr6j78qHOtbm8keEoBOoxJR3/2n5hW8RQ9aBR5fRSq07SWSz/63OGmBkWQO+zZChP/WbgFh63eaTYNvXAXK1xtlUfWjeCO/ifL0jeeJdAk87KP1P4FQ4SY9cxod1H7uc0Nmx4iaNmIglZyDeyo8ECg6O25B9fIlGnp+UGg/zRSQhZFKZKoMcPN57GYr9hbViT+a7lmqiIzNhywyOs+3YbWmYS2lI26SAGGnOC3sTBUNYcyP7a1QMBBrAl2cQhURKl15mX36KC06c3nonuo3Pz0TsH7+jkfr2NnSb+al4H4ZyzRpjXaAkZ3ADHbmXbboIeRmACnOpmoxzHwM+wVmNFs2dKDN9E3Z7a9uFmtuhNlGGIJu1LrcLykVJCd4LkfWOmFOwuDxuSM7n+n1HmX0nrqAbnZ66P0klThV2+WT/HXEckbolo5Wy25mdzrF6ePxi6QIwfUOHOMUDJwk+eh2XS82Y++mrd7HTtR3FQhuTf1sEKhGjCQjmtHW/z6CU8YWzroMJahyxJHvW0q3BFykGuv/Qp+FWW4Sj8/3gyfN/VAUvWRL2s5vRMN3dRy4ZIdrKyHqYB6z0t7TBVNdApKjPGcQVehgV1US5jdAT0xCvGSNgD0t+nm5Tid6jphDQbHjInLZfdDpUqfHKlvPMOiXP7nO/9Ubwqe+9XWIp0ekZxj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199015)(31686004)(36756003)(2906002)(316002)(38100700002)(66556008)(8676002)(5660300002)(4326008)(66476007)(66946007)(8936002)(31696002)(86362001)(110136005)(186003)(478600001)(2616005)(6512007)(26005)(6506007)(966005)(6486002)(53546011)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmJXOUlPRmJrWG9QTWhDcFF5dnNpS1ltRVVMTGx2MloxNlVWem95Mm11VzNp?= =?utf-8?B?YlZFMWpwVklDTXpaRUU0VWNGMUlMeFJmbm1MVU1zZ201MlRNaEpyK1JvMzJ6?= =?utf-8?B?aHkrWk1vZEVVZ3N5OFVvQU93dDZDMmk0dTduUFIwRXlOVE5tZDlJTVFhTWtQ?= =?utf-8?B?Z3I3dnFxLzlPdDRIMFBiSW1IT2JmM1FGYTQwQlZudmhOREhPRlFpdWd3ZDJ2?= =?utf-8?B?cDJ6T2Jwb0xlZ2RoTnJSclBDc0FlM3FUQXFLN1ZRNE93eWZMTHFqU3VVblpM?= =?utf-8?B?bWJGZlNYZFcvOVY3ekJvZi94aUY2KzJhU09rNXVLMDJrUndCUU9Zd2VRelpT?= =?utf-8?B?Njg2bWJuLzd5RXRKS3JyRGtRRUJZM2pCcjk3akpGRTJNQTRoaHU0dXRNQkUr?= =?utf-8?B?WHM2VHJFNkxCdnBicDArU1dFbS9scDVrd1dWZDRRR2YrN0lLanEzVXVBUmpE?= =?utf-8?B?ekYvbFU4QktSdTN6N3FtOG5zQm81cHIyNkpHcktPK1NxL1NtdWlYeFpQeWNQ?= =?utf-8?B?MzZ3RVU3akU0QjNBNkxRaFhqRDFja3pFQkFwUDdTWnRYc29ncnEwMjZtMlYv?= =?utf-8?B?bEg0VDljOVdCLzV6djZ1M3lrc3N6UndnaWtrUTJzMWZnMVhOcGZkZmdNR01R?= =?utf-8?B?N0tFbk0za3ZxQ0thQ1hxN0JhNWQzTkxORFNvTDdocG94QVd5bTZYcEJpcnVC?= =?utf-8?B?cG9JS1FxWmlTYmRSYjhvdC9WTER2M0xxaVY5VFZJb2tPQ2RENzF6VEw1RlBm?= =?utf-8?B?c1BVK0Q5bzdKTDg0dG03bUd4TGY0eFRCd1FUUCs2SnhzMVJ6TmZxSGJFdDgw?= =?utf-8?B?N2VWZkdoQ2MwMDJRRlNpWnRhRUk3RFlPMS9UZ0pWZG9ndXlCeC91c2lya0ll?= =?utf-8?B?Yk9ERHFxWU5oekpLMU1LNFlHWEcwWlMzd2hCb1o1Sm5PZ3hSTjNWTzFVbGor?= =?utf-8?B?YzZRays2V3lpVkxSanU0dEJGTGVDUmJjZ3JwV3BrV1Uwa0ltTi94emNWS2Nl?= =?utf-8?B?SWhNOXh2cFUzaFJ4Y28zUFRhR3dFb1dvWThUR1I1VVhWQ3o3b2ZuTkdJYmJx?= =?utf-8?B?Sk5OaWFvS1VHTFI5V2g2TVgyeE9jU0pMRjFiWDJDeHZmZEUvcTJmUXRRdlVt?= =?utf-8?B?blZ4T0oyUlVDUndKOEZUSGpEdG90OVVwRWJxT1BLVzVwM2EyOTZlMU8rV2tX?= =?utf-8?B?VVZCUitjZ21BZzM3V0J4Z3l1dXN1ZHJFM3VzbEh5VEFMdFpTYXdja3A2b0Qr?= =?utf-8?B?YzdhUWZKTGhrNjJNYUJEVXB2Zmt4cGo1ZlgzQlRxMGJCSFQ3RHFBVXlQdmNx?= =?utf-8?B?ZThRV0hGV3pKQjEwZmloWkNta3lFZlNXVE91K09BbER3KzBWbTR3WWNNSUFx?= =?utf-8?B?UFg3U054SmJjZGFmTURqZDkzWDNtc1daWGhCZ1NScWNaLzNYVzl5eFA3UXBD?= =?utf-8?B?U295aTcwM0dCTGwyeUUwNyt1bTNsaE1HRVRiRUt0QU81MG51a1RiMkFzRkZS?= =?utf-8?B?RnJjbG5RKys2MmpnSnp5bVJPTlhvNEJXRUpPak4yY2NjV1hQUWxFSVhZWXYz?= =?utf-8?B?NjYyaHhHTEJQbEN2cGZheHpqSmR2RHFVeFkzOHVYR2YyRE5QUFNaLzk1VUVC?= =?utf-8?B?b3dZM3l4VkkwWmtucUpZdGVlYTlhVVF2cmt3T2trWGZHT1RNUm43ZmwyK1U5?= =?utf-8?B?V1U1cE1HQUc1TGJ4SVJOdGc0RTZ1eGVmUkxJQzF2bERVNGEwUVRIblgwYzVq?= =?utf-8?B?NWNFVzdlRzlKUXdRTHIydTJvL25ld1RGRklZZ2ZCNUpaeHpRVWtBM2NxVllB?= =?utf-8?B?TVpCakpuaXNFNjEybGpaL3RuaVplTnNqb2dRMmpZUjZvemZxbHZZWmhPczlW?= =?utf-8?B?UmpNOGIxL054SnI2b3U2V1BGT21vYUNieEw0QmNGVlN6ZDFGNVhPQVRyc3k2?= =?utf-8?B?Mm1BbVVlek5OZEFVa1dtdXdYbUJlWFE3YWpHLzZUZE5LNDZ0NURad2pPTmo5?= =?utf-8?B?T0s1NXl5RkRQeEYrVFJnbTBEZlU3eWlmOEVjNXVYVjRLMEE2aDEwdjZKUHc0?= =?utf-8?B?YlE0TWVwMitRdUdhMWZLcE9RMkxwUk9qRk9WSEM0WE85WTl3c2pXbzZPM2kr?= =?utf-8?Q?uYeCgQAOHncHQlRI1Yv0oyNnB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e693975-8f9e-463d-079b-08da9a1f49a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:13:59.7524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gSF+O4AOE2xrEHbiTjTpJllbDooW64ZnQd4+DJR1OZ/n3rf9Pc4Dh5ahXLUnnk2b15HOIpKO1gTxWzLbpn6WCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8306 X-Spam-Status: No, score=-3036.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.09.2022 08:55, Simon Marchi via Binutils wrote: >> diff --git a/config/zstd.m4 b/config/zstd.m4 >> new file mode 100644 >> index 00000000000..b8b3a199730 >> --- /dev/null >> +++ b/config/zstd.m4 >> @@ -0,0 +1,12 @@ >> +AC_DEFUN([AM_ZSTD], >> +[ >> + zstdlib= >> + AC_ARG_WITH(system-zstd, >> + [AS_HELP_STRING([--with-system-zstd], [use installed zstd])], >> + if test x$with_system_zstd = xyes ; then >> + zstdlib=-lzstd >> + AC_DEFINE(HAVE_ZSTD_H) >> + fi >> + ) >> + AC_SUBST(zstdlib) >> +]) > > Hi Fangrui, > > I understand that you did this by copying zlib here. However, the only > reason we have a --use-system-zlib is because the binutils-gdb contains > a copy of zlib, which is used by default, and --use-system-zlib can be > used to prefer the system version. Since we don't carry a copy of zstd > in the tree, I don't think we need --with-system-zstd. > > However, since zstd ships with a .pc file, my preference would be to use > PKG_CHECK_MODULES to have pkg-config find the right flags, and have > --with/--without-zstd. Same as I did for the msgpack library here: > > https://gitlab.com/gnutools/binutils-gdb/-/commit/2952f10cd79af4645222f124f28c7928287d8113 > > I am not a binutils maintainers though (just GDB), so in the end it's up > to the binutils maintainers to decide and GDB will probably follow suit. FWIW I agree with the comment. Jan