[PATCH] make a few variables static

[PATCH] make a few variables static

[tbsaunde+binutils]

From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

Hi,

They are only used in one file, so we might as well restrict there scope to
that file, and theoretically this might slightly improve compilers ability to
optimize usage of these variables.

built crosses to sparc-elf, ppc64-elf, and nios2-elf, ok?
Trev

gas/ChangeLog:

2016-04-13  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-nios2.c (nios2_as_options): Make file static.
	* config/tc-ppc.c (toc_reloc_ypes): Likewise.
	* config/tc-sparc.c (native_op_table): Likewise.
---
 gas/config/tc-nios2.c | 2 +-
 gas/config/tc-ppc.c   | 2 +-
 gas/config/tc-sparc.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gas/config/tc-nios2.c b/gas/config/tc-nios2.c
index bf37ff7..d207758 100644
--- a/gas/config/tc-nios2.c
+++ b/gas/config/tc-nios2.c
@@ -98,7 +98,7 @@ typedef enum
 } relax_optionT;
 
 /* Struct contains all assembler options set with .set.  */
-struct
+static struct
 {
   /* .set noat -> noat = 1 allows assembly code to use at without warning
      and macro expansions generate a warning.
diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index 1d2c57f..8bfdfdc 100644
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -207,7 +207,7 @@ ppc_cpu_t sticky = 0;
 unsigned int ppc_abiversion = 0;
 
 /* Flags set on encountering toc relocs.  */
-enum {
+static enum {
   has_large_toc_reloc = 1,
   has_small_toc_reloc = 2
 } toc_reloc_types;
diff --git a/gas/config/tc-sparc.c b/gas/config/tc-sparc.c
index a51ca1f..b956131 100644
--- a/gas/config/tc-sparc.c
+++ b/gas/config/tc-sparc.c
@@ -758,7 +758,7 @@ md_show_usage (FILE *stream)
 }
 \f
 /* Native operand size opcode translation.  */
-struct
+static struct
   {
     const char *name;
     const char *name32;
-- 
2.1.4

Re: [PATCH] make a few variables static

[Nick Clifton]

Hi Trev,

> 2016-04-13  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* config/tc-nios2.c (nios2_as_options): Make file static.
> 	* config/tc-ppc.c (toc_reloc_ypes): Likewise.
> 	* config/tc-sparc.c (native_op_table): Likewise.
 
Approved - please apply.

Cheers
  Nick