From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71701 invoked by alias); 13 Apr 2016 13:34:36 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 71672 invoked by uid 89); 13 Apr 2016 13:34:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:elf_arc, MOD_AND_OFF, mod_and_off, TLS_GOT_ X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Apr 2016 13:34:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA35D85366; Wed, 13 Apr 2016 13:34:32 +0000 (UTC) Received: from [10.36.6.221] (vpn1-6-221.ams2.redhat.com [10.36.6.221]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3DDYU5I002408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Apr 2016 09:34:31 -0400 Subject: Re: [PATCHv2 2/3] bfd/arc: Rename enum entries to avoid conflicts To: Andrew Burgess , binutils@sourceware.org References: <8181b22162809916157ac2d6d38f50840371d3c5.1460458691.git.andrew.burgess@embecosm.com> Cc: Claudiu.Zissulescu@synopsys.com, Cupertino.Miranda@synopsys.com, noamca@mellanox.com From: Nick Clifton Message-ID: <570E4AE6.7060409@redhat.com> Date: Wed, 13 Apr 2016 13:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <8181b22162809916157ac2d6d38f50840371d3c5.1460458691.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00198.txt.bz2 Hi Andrew, > bfd/ChangeLog: > > * elf32-arc.c (tls_got_entries): Add 'TLS_GOT_' prefix to all > entries. > (elf_arc_relocate_section): Update enum uses. > (elf_arc_check_relocs): Likewise. > (elf_arc_finish_dynamic_symbol): Likewise. Approved - please apply. But ... > - + (entry->existing_entries == MOD_AND_OFF ? 4 : 0)); > + + (entry->existing_entries ==TLS_GOT_MOD_AND_OFF ? 4 : 0)); You need a space between the == and the TLS_GOT_MOD_AND_OFF. Cheers Nick