From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101182 invoked by alias); 14 Apr 2016 14:45:34 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 101158 invoked by uid 89); 14 Apr 2016 14:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Apr 2016 14:45:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36F6F7822B; Thu, 14 Apr 2016 14:45:27 +0000 (UTC) Received: from [10.36.6.41] (vpn1-6-41.ams2.redhat.com [10.36.6.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3EEjO5g014975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Apr 2016 10:45:25 -0400 Subject: Re: [PATCHv2 1/3] opcodes/arc: Move instruction length logic to new function To: Andrew Burgess References: <570E4A76.5020504@redhat.com> <20160413144058.GB5531@embecosm.com> <570E661E.80908@redhat.com> <20160414124011.GH5531@embecosm.com> Cc: binutils@sourceware.org, Claudiu.Zissulescu@synopsys.com, Cupertino.Miranda@synopsys.com, noamca@mellanox.com From: Nick Clifton Message-ID: <570FAD04.7040801@redhat.com> Date: Thu, 14 Apr 2016 14:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160414124011.GH5531@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00215.txt.bz2 Hi Andrew, > opcodes/ChangeLog: > > * arc-dis.c (arc_insn_length): New function. > (print_insn_arc): Use arc_insn_length, change insnLen to unsigned. > (find_format): Change insnLen parameter to unsigned. Looks great - please commit. Cheers Nick