public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: tbsaunde+binutils@tbsaunde.org, binutils@sourceware.org
Subject: Re: [PATCH] add casts to avoid arithmetic on void *
Date: Thu, 21 Apr 2016 10:38:00 -0000	[thread overview]
Message-ID: <5718ADA2.9040006@redhat.com> (raw)
In-Reply-To: <1461214254-29707-1-git-send-email-tbsaunde+binutils@tbsaunde.org>

Hi Trev,

>         Unfortunately most of the
>         argument types come from virtual function interfaces so changing the
>         types to bfd_byte * isn't trivial though it might make the code clearer.

This would certainly be worth looking into at a later date.

> 2016-04-21  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* elf32-rx.c (rx_set_section_contents): Avoid arithmetic on void *.
> 	* mmo.c (mmo_get_section_contents): Likewise.
> 	(mmo_set_section_contents): Likewise.

Approved - please apply.

Cheers
  Nick

      reply	other threads:[~2016-04-21 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21  4:44 tbsaunde+binutils
2016-04-21 10:38 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5718ADA2.9040006@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=tbsaunde+binutils@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).