From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by sourceware.org (Postfix) with ESMTPS id 7B1EF385B50C for ; Fri, 3 Feb 2023 07:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B1EF385B50C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDix/3NQrZaTHyCHZ20wW6vXFc50ZKA5ZWTL2ArRhviS+UHZXmdrxDtxEWVdSxH9ZKWH+lemVEqPq7FwJG4vIcOZnbgKMC8OIRsTVEtbgFUgTkkUwAQIpPwAkp8iHFcgcpQ1/7ga1DY9THems5ZBxHdoS6JWa28UsQzWGTt4IHCV/aRxE3qIlffeV667+4TbJtKyUYTSbSCrwrdl9qwlvxA9U1DzreGbrKyxgqOPpBaTSLwjj6588+mLaWzPB8PWfH9KG5mDTN6WnAALftYVyo69+/QJvFjCP+Nju3ViuLo7ZgKt4PQqgXcKEnOUUbBtvt7IB21Lijk4PRwdy9bvEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCHxp+DjIKoLfl1bU4MbuVcEMgjkkb5Q+rcLg5/9+Fc=; b=Sj4PIQ71OTJDpFo9/Kl9uXipGrn0g8NcUMNTprqD1KBxbL9juPVSNpRWyt2Vz7LgXGvpM6tx3FdMLt6wMN+QTsU2Kg1xRDbitWOS6x/y7DCwi3oqUTcTlsg2FGyf4Sruh07Jlc5CaqyIeCQlJfQeUEmiuCypcK19az3o/+WUKlQDxNkgn8s6gw9M02kOiLYg3bst10zCIsr3ZaElmmwb/2hitcriwHTfLASZgjaXe4LXBaUwUUAa5L0X5D0AMx5l38eTAMFjO19hKAug8Z62FllDLmY0yufUzWVGc9R73SYDQhzFLFRmVkwKHn0512L5tGJfRBmctq7vYC74fhTlag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCHxp+DjIKoLfl1bU4MbuVcEMgjkkb5Q+rcLg5/9+Fc=; b=CFd9b+e7bMFYRExfO6GDIfMRPf/rUPAPwgqV/wSAUZbRTFiNtyWjYC1ttBIuR7NH+thULj5ONkov6amxmoP8QSILadvhazvX8oOJybzIxuTVJd/CsuRR0Pqw0qbyrodKlhCxd854D1LB2b5mQldLxYdqiZkiEqttNqCA1rWYPk+01/9mIkYubknmjpbcKRS2hSQvtfJ7xpqky2D4AXPaQ+uNewTrGdLC+ZdZir/YRiKZV/UvILoh4bcP5CuEz6/3BRaDgxpex1QCTtZqaTAVLRtbWuX7TwSu5zlrDcE0blEcpuo43XP1Vmqx3a/0w05Scc+A2pNuDIXnmVO4Zg+hhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8165.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Fri, 3 Feb 2023 07:44:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.024; Fri, 3 Feb 2023 07:44:58 +0000 Message-ID: <573dd630-a3ca-52c6-846a-d7d18a7e3d52@suse.com> Date: Fri, 3 Feb 2023 08:44:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 1/3] x86: limit use of XOP2SOURCES Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0201.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8165:EE_ X-MS-Office365-Filtering-Correlation-Id: 32ba7b00-d267-4b07-0c28-08db05ba8c39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: boZxX4cSOBF1Yj8xqJo8yLRotdNQnz0W34BLaCsl82SWHShuGDJQIdoZ9Wn6An+UTuyNTjl9HrreoYA0t2yj4Q+rUW5clLEu+pEWckCHiJKXfH7wGlRin6phsVsxKE9NGAM0UvY2O3uXqjnj2R47maJJWZKFoiVsXwk7bflaR9n6n2Dab1JcYObMAJAnWUst7mxFJSHeLeAzFepXrsJ5F245OZ3HJbQD28Kp72LFcGtGr/rXWYUzlrPAaNU1+FVCDOdF5eFzDD/xhNHrFIYxk889dD1KFAr6KMreOb9Ij34VVW6nfvMV4OxyB7gXWHy8t2Md6He9xqrrzMhpZH1IkhWm8f9qzzu/UBl8DUqXtJAYJAzSEpxOD/DOn2wS8D6BnFlHARzPV+bhAkg2LSmEHyBes/5taHul2h5BKxsRnKf65ki8GHRQkA43DgzGIKGNINiE6i18u2SyqRhv1RwIr9rvbhJCm1TiEhgQfzOPx62fitPoU+iREgQa5maz/GYFj1+b0QqetTWOpZg5pXogCVXGrYcFSaZAcLWqYh37xIP/yivkdhLZqrfQ4efUKj911Rfy1wkXgwd8ZgyuU4Jbsv2pTFmH4M2JZgYevDsmM++juNw1bZKJf3oSAkJEQ0iXnl1VF2O/wUoJueTY+LB9yjALLB0/UI3f2WeSxn9dfY6T5uNFoMeJTsQkPtY3bwZcltvgk5P5pRp5Jxv6EHv4TWxvF44j+uHz85PKh7sVSlw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199018)(5660300002)(38100700002)(478600001)(86362001)(36756003)(8936002)(31696002)(6486002)(41300700001)(316002)(2906002)(186003)(4326008)(6512007)(31686004)(66946007)(66476007)(66556008)(26005)(6506007)(2616005)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkdIOWdOOEFrQmNrYVZmS0t2UFJPc0dFOXJvTTdpSFJsMkEzMWpZKzJLNEV2?= =?utf-8?B?d3YzOFVSMDNQYWUxOEZkbzBBMVJqWSs0ZC9kVUJNN0dDa2VIZHBVRlVjVjFm?= =?utf-8?B?dlhBczNPRVZKSE5UeDhZNkxCbjVIaG1udHNCUC9HWHRYbW8zN0hOcTRmb0FH?= =?utf-8?B?MlhIQldvclpGYVZBdWFxM1I0TC9hWk5vSVZMbDFTSGRiS25OWUJSV3Vta3hW?= =?utf-8?B?WDh3a1NXZ3Z5ZnU5RmhDSkZjdEVyNVVEMXlaUVBqbERZWG91TEtwZ2g5NXJj?= =?utf-8?B?RDFhUWlDODlleVRibUpYOGZDVmtEVTNnVGlHaC9VSXh0SUx1NGZXVWVzeFQ1?= =?utf-8?B?aVpuaDE5dkNCVkorMGd6KzhSVWNLVnVVK1pHbWZNTXkyNCtpeTBYSmxMTkFI?= =?utf-8?B?LzliMktaRHhCdjcyemQvaWZjTnJGRkpyakFJVzRSZllTdDlaOUNIbi9aSHdT?= =?utf-8?B?OTdHa0xNZEl2RU9nMkpXRFE5SDA0Sk9xRXhnTCt3Y3BKTmpRQnQ4TjhDbS8x?= =?utf-8?B?cCt4b3lOM2I5NE1yT2pFTHFoVmhCN3FYVEgzNUw3UlZZWnJUS1VFdjUvK3Vl?= =?utf-8?B?bnJxRnJFRFljRFRIN1hjZnBNR1pJb3hnZ0JnM3lsSzlFOU95L0VtYm1CN1hF?= =?utf-8?B?OHhEcElmZjdick0xL3NxQ3lYdC9haGNFYVpoaGROQzhQTUw3YjVHOGJlc1o4?= =?utf-8?B?cmhVZWRaMHppaEFxWmZZcDFialBZNnd1WHhiS1Z0VHpVVFhBTFR1VkdZTEFK?= =?utf-8?B?UElvaFB4SGxaNDdRN2p5dDlzWm5TdGFCNDhJeEU4enpsdEtMdHkrMjJiYnM0?= =?utf-8?B?dC90OTZpT2VJTXF5NHh5ejlLTXA3algxU3BBRGYzeXd6UlhIQ0hIazI2NWU1?= =?utf-8?B?M04wZStOSXBJWlFLckZjMnZpMTNKT2ZiVWRjTmV1MFljSm5rTTRFbWlhRitQ?= =?utf-8?B?Vnp3VmtpVVZvQ3hGMjJvU2t3bDR2aGczM3orRnVMdnNlM01ObGN1a24zRGNF?= =?utf-8?B?Z2dvUGlCRmNua3RyQ0VhSk5zMDFJZFFsNmNsWnk5Skp2azBVWWtoTjVScTcz?= =?utf-8?B?VUJnQ2s1QUdHYnF1SmhzZWFBQUVwcnJubTllUFNuLzFkc2YvZldPOWVmNEky?= =?utf-8?B?KzA3RTlrd1IxaTJpZGptQlQrdytwSnc2cUVDaUhOaHA1bVFQbC9IckxkWGE2?= =?utf-8?B?SUZpa3NmWWJBUjBFTkp5TndPYVM2T21IVlgyMWxRcThCaWZnNE9sVlhZTDRG?= =?utf-8?B?dUdRQzczcWF6Y01pbjFlUDRHM1ViUWFPOC9CNWs3ODhabk5IVFpkY2dhMyth?= =?utf-8?B?UXF1QW1TRUMyRnVOc0IwNmZjeHA2L0Nxc3I1OXNqQXlvK0kxVHpMZGRhQ3dr?= =?utf-8?B?bWlLN2tNTk90SHpLODJSRXhrbHk1SXZJRENRL1hxN3lRYnZmK2QwbStPYW1F?= =?utf-8?B?alVFOC80dnVhNE92ZDFGOW1ESGxZN21sZzNxWjRZQ1YvZ2JHdTZHTXNPRW1s?= =?utf-8?B?NFpBQVN0R1NTK2VieGlTaXBTK2RicmhqN01pd2tCaGMxbW1ZNzBjMjZ4UHp0?= =?utf-8?B?ZzltdjMxOXdnKyt0NG1ibU1jL2JURCs1MktEM0RDaDRnWUk0TFNoUE1sa2xk?= =?utf-8?B?bFMreGEyTHo5WC9WZTNxeC9MVzhVWVBST3AyRXdTM0xDT0Vkdjh0anJsa0tx?= =?utf-8?B?QnR4dHMyT2RkbWx4ank3ZWs3L20rSHJ5cHhtQ0wrWDB2U2h5QXJmYlRsd0h1?= =?utf-8?B?cjlLbFk0UGtMQzJ5dU5UeGpVaG5WYVQyVjhlVHF1SnZPbWhoS2liRXh0cGhQ?= =?utf-8?B?RnRrV1BxSzdqUW9zN3JuTEJQMVpNVFluQll6UDRmanRzUlg2UVNoRUdjQ0Ra?= =?utf-8?B?QzhtRmt2R3pLRVIxRk1jS1lhdDM1c1hWSURMNkhKRWRCS2lWZnNSTXVUZ1ZX?= =?utf-8?B?bGhFaDJTRkNmd0ZSdjI0aGNjd01NNTVndWlFMStGNG1qMzE1R1cyYThkNjRx?= =?utf-8?B?ZHpFUHVUNkxrdWJDZGVWbm5UZjFQVTYrbVB5Wm9rT20yNzh5WmNpL2V1eHpu?= =?utf-8?B?Z1ZXOWZzMmF0ank3YTJqOVVNQk1UV3ZrdWJ2YzY1blJ5eGQ5OG5SYnNQdkhH?= =?utf-8?Q?uO7jVh4h583QIVIvW+Sh1hTH7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32ba7b00-d267-4b07-0c28-08db05ba8c39 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 07:44:57.9380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +INNGZOeDKn1bXLlCyzoRgWNTKxgqp1AsnroajzUYC3XCbqkKy3MgB5cpl3jK3wnY/JAiZSjpoJea+8u0hZnBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8165 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The VPROT* forms with an immediate operand are entirely standard in the way their ModR/M bytes are built. There's no reason to invoke special case code. With that the handling of an immediate there can also be dropped; it was partially bogus anyway, as in its "no memory operands" portion it ignores the possibility of an immediate operand (which was okay only because that case was already handled by more generic code). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -8620,17 +8620,11 @@ build_modrm_byte (void) if (i.tm.opcode_modifier.vexsources == XOP2SOURCES) { - if (operand_type_check (i.types[0], imm)) - i.vex.register_specifier = NULL; + /* VEX.vvvv encodes one of the sources. */ + if (i.tm.opcode_modifier.vexw == VEXW0) + i.vex.register_specifier = i.op[0].regs; else - { - /* VEX.vvvv encodes one of the sources when the first - operand is not an immediate. */ - if (i.tm.opcode_modifier.vexw == VEXW0) - i.vex.register_specifier = i.op[0].regs; - else - i.vex.register_specifier = i.op[1].regs; - } + i.vex.register_specifier = i.op[1].regs; /* Destination is a XMM register encoded in the ModRM.reg and VEX.R bit. */ --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -1877,7 +1877,7 @@ vpmadcsswd, 0xa6, XOP, Modrm|SpaceXOP08| vpmadcswd, 0xb6, XOP, Modrm|SpaceXOP08|VexSources=2|VexVVVV=1|VexW=1|NoSuf|Vex, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM, RegXMM } vpperm, 0xa3, XOP, D|Modrm|SpaceXOP08|VexSources=2|VexVVVV|VexW0|NoSuf|Vex, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM, RegXMM } vprot, 0x90 | , XOP, D|Modrm|Vex128|SpaceXOP09|VexW0|VexSources=1|NoSuf, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM } -vprot, 0xc0 | , XOP, Modrm|Vex128|SpaceXOP08|VexW0|VexSources=1|NoSuf, { Imm8, RegXMM|Unspecified|BaseIndex, RegXMM } +vprot, 0xc0 | , XOP, Modrm|Vex128|SpaceXOP08|VexW0|NoSuf, { Imm8, RegXMM|Unspecified|BaseIndex, RegXMM } vpsha, 0x98 | , XOP, D|Modrm|Vex128|SpaceXOP09|VexW0|VexSources=1|NoSuf, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM } vpshl, 0x94 | , XOP, D|Modrm|Vex128|SpaceXOP09|VexW0|VexSources=1|NoSuf, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM }