From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by sourceware.org (Postfix) with ESMTPS id 3DD5C3858C66 for ; Wed, 2 Nov 2022 09:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3DD5C3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDPl4y4eNzLQu41fofNq8F9PSstn5za4V68iLVT8jlesQcKwChem68n2cKvexh5GXBUwUiA71wRiF12mmxVIR+PDtDG39TI4qtpEBLw+PosZ1uxY1UC2WQ165raX+Wk7/KqBMMFnPSiX3D6SHeDgyvm6k6B+PY8g9AwAmYQubFRNkYVTCY2PLanjRmHJSV+tYww87ix9UKYPkRhycpq+a8aV6G2G9Z7VSt7fIca/4O8oo+Q19KCVxmXMmvToM5h+kfD73zR1tBRpKfTPNDVefTZP7mZ3SKJXbmXo9w6BY2AksPTbEDKHEO7J5xj75tddv7l+PvXHaVOsma7f+vc9PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=puuxG7JfNy8zeetvmx6gY6ud+JeG+MS56FQp3vKFxLw=; b=lE5gzvPWjrbQRrfpYwqHRaUH2kXaYHha19iqE/eLz4nApwmbgNsLRq5VaTXvfWZgz806+bQkjI58UfqyNHomAOrLGgouDimKtU4JlpatI0R4TOOrbpRNk6VouhVWc9D5z6TMmJMzzi9z0W0DQyyncCUhek0wc/L72rqwvgLRrIGComaKWSW7KU3VZ5bmL3/JPPVgFzLHC33oD6Ix/1Zpm2JWY2Y8hWmWb+p2RTYwHu4vOGgbL0baBbFRvFYGWfvPFO/UUcXMvCLjhKs3EQNvtumfBYMTK8TKPRSakxiXK0HMAVt6s3tqki/CqrjoQwFlkANV+CaHZCkp6zWFtbcS5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puuxG7JfNy8zeetvmx6gY6ud+JeG+MS56FQp3vKFxLw=; b=PsbvjO8RPLvZAUAJBB81xO+Pl0/LUfyqh27jmTrgcEDPL0IGMazbqcb93WUFsfTAb2Q2zdPQ+JmMVuHcWk2JWTmBibIEMSzFw50AXD6QOEPqUIl6MrsmecSmO7xfGtYA3a7W+7bj+EIEJ33rxa8XYMZTWz/SoOUCxyiFRhWvFLn0/aAf9qYa/lOyLbTJsUXgnue0MZPUKZHmtlbtdP6VuVBodoZRelw2SjlDZOFfbUyBtI5ZY0w7MvPE+Zn0TLigIo+Ln8KbB+rC6CA0I2A5lgfGsOxtpZMXwUNsVCOgaIjGsw1PWh8AspupGf55f5t4bI45u0t/VLDy3eNJ/01ORw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 2 Nov 2022 09:53:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:53:43 +0000 Message-ID: <577a33b2-060e-5d27-0a77-764b096023b0@suse.com> Date: Wed, 2 Nov 2022 10:53:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] Support Intel AVX-NE-CONVERT Content-Language: en-US To: "Kong, Lingling" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221031060601.38460-1-haochen.jiang@intel.com> <20221031060601.38460-3-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9185:EE_ X-MS-Office365-Filtering-Correlation-Id: ce24289a-7054-478f-880d-08dabcb820db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oZ9Rp8pJeSSux1q29I+MoRoGUnf8Fd8gQIHiTmEbxs9QoaCqNSKSCTTdvCpD6zaQoN/ENNBgLVD52TdgdOZyBvXPyRDiHks10eW1cYP0OPRSQciZKA5WjsK4jf0Hd9gbb+AgYMuKLSuV1JMYH35UCqHFUcEen4SajkubgY8aa3WBUEcy4CDFzMJ2FsWAbyHaw3C6eta7DNBhqEI96I8nap00TkoQgPIFffICAUzbUZhV1JjQ+NmzB9YMhUP9uYy9Mg394LvkwnGUxP69YVkxlXbmkT/O5Vv24Lo0OvxBspKQEjcgV0cSJz7vLP2YekfTvh+63XYUr8pprdlSryUPRt9/5zdNEjhoGbHY1pLNUW0YVdBXW1ru8+N424xExoPQ+54tsw8oym9CKvJYrl75RwFTZx0+d9ZsCzjLhAIkbIN5EYB1cNtMuemUDI29AvSCHvDS5A03+Vujbt3/cyepKAqRei57RR9gbgaxwXH4WcRjMxWPlML1Yy1yXJRNqCD0WVsPYqHdDaKRuU8YWlgoqziLKFlSwJ+KSOC7o6zBnKBogM02hbYlEZRLqeb19e7BrOeHfKNoP5bywubBrg7HchVDUuIuM3lRuCb7MNtYLZmWjoH2WyjHv8swQWtvxH7uAKSP06CuHtgKdGqeeanT1WCd4nQG+KUi7GpQiqCCvI9huggrGU+aRu+mmWAOB5lS1IzYLdbECh/BHJqoIizMt6FHUr0CByATOyiy+VyGRI6gINPzlcSfIW0eFS04zDXtf9F0p8GVR94Lbo+G6selbdlyEAzL6OkdG3Mj5lBa01Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199015)(8936002)(66946007)(66556008)(66476007)(4326008)(8676002)(41300700001)(6916009)(54906003)(316002)(86362001)(31696002)(5660300002)(2906002)(36756003)(38100700002)(6506007)(53546011)(31686004)(186003)(2616005)(26005)(6512007)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THVvNVl1Tk10dVpNMjJhbW1RQjNWc3NZbEF1NzAyMTg5SkUycmRGTEhYVThI?= =?utf-8?B?V2pFMHE4VlNMKzA1M0Z0T0Z3ZmdVOGFFVVpHaVl2VFpTWEtQVklVeUZhZVZE?= =?utf-8?B?bTFUWGQ0TkpuUjBjSmpxcENxcWhMQ2ttZVV1T09meWhaVUIza1FqT1VhQmNq?= =?utf-8?B?NmJxNk5lNnVRTURxTWViU0tEZGM3S1pGaFlsVEQ5N2szT2FNdHlvNGZrVG0w?= =?utf-8?B?MkdBOEJibERJYUdjQkcrUzFvOGxwWEJXd1BKam0xWkF2SmpVWm5DZGZ2L1I0?= =?utf-8?B?ekFNUUhNamZYbjBialAxUVJianc2TndMRnFkSjhZMDg3UEduRytrMHhVeGpC?= =?utf-8?B?a0ZibGpQM1pIdldVNEZkQlNvL0VLYnFRSXlpWm50MWJnQVBqeXNGOGRBcWZl?= =?utf-8?B?ZnNzbm1KR3dwSTdVbnVnekVtQk1hWG5qNGNON0hoT01HTSt6NWFSSzlCcGpp?= =?utf-8?B?VEFCVmtoUkNnc1JEK3dsc3crQ0FUaW1pS1J3VW0rT25HQ2tmVFQ1cFB2dDMw?= =?utf-8?B?dXVMUE5KS0JPbXRlL1UxM2dZNForS0Vrb3JBNy9kRmI2Z3lBd2Z6aHJiNnZT?= =?utf-8?B?N0tvMlp2YXRMc3kzRVFHUEhzbzFPR0hCWWxOVE8zSmx1b0ZiWjRwNFdXKzBX?= =?utf-8?B?VEk4MldyZlZSQVY1U1NSdFhEYzZsRktIbHdrM2d3bG9DV0pyUVVWVHZCeXpH?= =?utf-8?B?NEtxcTZMSFkzT2Fpc2NpVS9nbmcyRTRiRmV1eHRBcXhhWVNNY0hqc0NmVENO?= =?utf-8?B?ejY3clVJZFZVSjJNZzZZT05ScUlYdVgwUndaclJqcjZXY0tIcmtLOXZrRHYv?= =?utf-8?B?WTZzVFBUNFRYUVdDT0dNVVJEblE2QnRUV1hEcml2NnJPaStDQjdhVit5SllP?= =?utf-8?B?OUFXbC9SMHV4cllOaTloa2xpbXlrS2lTTGluRXVEL1hSdlIwYlRsZHlCM0d3?= =?utf-8?B?UmlBeldEZlpPcWtVSUtJVi9GNXNsL21iU2ZNUU51VnF5RXBCY0t1eUE1MlJn?= =?utf-8?B?YmJ6TGpDemg2VWtsUGdBR25hMVFSdUdnUUVaQ2pWOVIwNjlDY2VxL1JVUHFH?= =?utf-8?B?ekVJRElxZVlzbDY5WFFKV1lkNWJFeHNzR29yUU1rWFRPaEtsVHNjdVhMZjNW?= =?utf-8?B?NnJHOHgvcm1qNitlOUJRcVVLQVlPMHU4TW1JUURDb0RsbFBaOVMyK0hTTU1G?= =?utf-8?B?cUVqckM1bkd4Yy9lL0NBUVZVTUNteTVTa1FrNFZiaWlIWjhpRG80L0gvVmts?= =?utf-8?B?anJCZGZOc1BXWklxUE9BTjVOekhKcEc1L0YzV21NNG9Cekw2dDJ5dDdSTWcw?= =?utf-8?B?RkJXRTh3WHBqL2VZZGExQjlVRlJaVHAzb29sTkpjdVl4ODZzaGk3OEltVDZS?= =?utf-8?B?TTAwbFdGbEF2SDNLdXRmd0gvY1gwdkhVcXc3TGVMQ0Viblc5aWw5czJEczdU?= =?utf-8?B?ZmJuK1k2a0pwQ1RJZnVsMnppZWN1TmNBczlJMWNZdmlkemNWRVhlVkxKY1JC?= =?utf-8?B?OEZTMk9IenNaTjhaMU9ZVVR2dkFRYzJqRjRqamZsRHZ2RlZaaXV0L2F1MEZ0?= =?utf-8?B?Z0FlaGNHSU5iWE9mcDhXY2dJeTR2TmV2TTZXY1JUMy9kRU9uRStnMU54OTFJ?= =?utf-8?B?R3dKUXFLVVdpUWRqdmJNUDB2VzRrYnBGUjdtTnlGZXRCK0k4WEg4OTFob3Bz?= =?utf-8?B?V2F0bmN4cXlQLzRRUlp1R3JHd3czWXVxTk5mSk92T0FBSStjbHlpRm9vTzVU?= =?utf-8?B?dForYnpxT0R5WGhUdi9ab3RETXVUdUYrMHVYcHpSaW8yRE1lRFc4VmJranor?= =?utf-8?B?RmszajJ3M0Q1VnFibjdsS1Q3SGd4RncvRUIyQXUvSXR5cUZ2VzdITytieUVO?= =?utf-8?B?OEVkUTdhMHNmZzkxckp2Z2lzbFR4VzhOZmFuRzdIOWhHMlhqUk5CYXRGVjlD?= =?utf-8?B?QUZhTk5VelRWTjA0VWZma1BEUE9pcytqN0VoWDlDSUtXOTExbHB0UE1jc2NU?= =?utf-8?B?dTZkeDYxaDFUbXprZ2psa1JmdXcyQXlZc1B5cThJaUZkZjBnaHF4L3htYnhX?= =?utf-8?B?ZlRGNWFTeDFNNzZaMVdMSlNRZXdReGl2RkhocTFSRGRjMXV1cGcxRXFNbTF5?= =?utf-8?Q?V1bA4i1ibn4VxCpnEWV7RsijR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce24289a-7054-478f-880d-08dabcb820db X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 09:53:43.8702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MDGh14XenpzUVuOhPPjp8TR3rCgDrrTZMTdhyGerEOn9p7xqL/ELwjYY0GaTIHsYFcJ8i8xdKBgM+wXbpGlg2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9185 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.11.2022 09:50, Kong, Lingling wrote: >> On 01.11.2022 10:04, Kong, Lingling wrote: >>> --- a/opcodes/i386-dis.c >>> +++ b/opcodes/i386-dis.c >>> @@ -942,6 +942,8 @@ enum >>> MOD_VEX_0F385E_X86_64_P_3_W_0, >>> MOD_VEX_0F388C, >>> MOD_VEX_0F388E, >>> + MOD_VEX_0F38B0, >>> + MOD_VEX_0F38B1, >>> MOD_VEX_0F3A30_L_0, >>> MOD_VEX_0F3A31_L_0, >>> MOD_VEX_0F3A32_L_0, >>> @@ -1140,6 +1142,9 @@ enum >>> PREFIX_VEX_0F3851_W_0, >>> PREFIX_VEX_0F385C_X86_64, >>> PREFIX_VEX_0F385E_X86_64, >>> + PREFIX_VEX_0F3872, >>> + PREFIX_VEX_0F38B0_M_0_W_0, >>> + PREFIX_VEX_0F38B1_M_0_W_0, >>> PREFIX_VEX_0F38F5_L_0, >>> PREFIX_VEX_0F38F6_L_0, >>> PREFIX_VEX_0F38F7_L_0, >>> @@ -1556,8 +1561,11 @@ enum >>> VEX_W_0F385E_X86_64_P_1, >>> VEX_W_0F385E_X86_64_P_2, >>> VEX_W_0F385E_X86_64_P_3, >>> + VEX_W_0F3872_P_1, >>> VEX_W_0F3878, >>> VEX_W_0F3879, >>> + VEX_W_0F38B0_M_0, >>> + VEX_W_0F38B1_M_0, >>> VEX_W_0F38B4, >>> VEX_W_0F38B5, >>> VEX_W_0F38CF, >>> @@ -4093,6 +4101,27 @@ static const struct dis386 prefix_table[][4] = { >>> { VEX_W_TABLE (VEX_W_0F385E_X86_64_P_3) }, >>> }, >>> >>> + /* PREFIX_VEX_0F3872 */ >>> + { >>> + { Bad_Opcode }, >>> + { VEX_W_TABLE (VEX_W_0F3872_P_1) }, }, >>> + >>> + /* PREFIX_VEX_0F38B0_M_0_W_0 */ >>> + { >>> + { "vcvtneoph2ps", { XM, Mx }, 0 }, >>> + { "vcvtneebf162ps", { XM, Mx }, 0 }, >>> + { "vcvtneeph2ps", { XM, Mx }, 0 }, >>> + { "vcvtneobf162ps", { XM, Mx }, 0 }, }, >> >> With the use of Mx here I see no reason to have decode go through mod_table[]. >> And then ... > > Yes, Fixed. Thanks a lot! > >>> + /* PREFIX_VEX_0F38B1_M_0_W_0 */ >>> + { >>> + { Bad_Opcode }, >>> + { "vbcstnebf162ps", { XM, Ew }, 0 }, >>> + { "vbcstnesh2ps", { XM, Ew }, 0 }, }, >> >> ... this should also engage OP_M() rather than OP_E(), removing the mod_table[] >> decode step here as well. Obviously you'll need to add Mw for that to work. >> > Good advice! Now Changed Ew to Mw, and no longer go through the w table. > Patch changes as follows. > > Subject: [PATCH 1/2] Support Intel AVX-NE-CONVERT Thanks, lgtm now. As usual I'd like to leave it to H.J. to actually approve of the patch. Jan