From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46350-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 15502 invoked by alias); 11 Jun 2006 00:28:03 -0000
Received: (qmail 15494 invoked by uid 22791); 11 Jun 2006 00:28:02 -0000
X-Spam-Check-By: sourceware.org
Received: from mail-out4.apple.com (HELO mail-out4.apple.com) (17.254.13.23)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 Jun 2006 00:28:01 +0000
Received: from relay5.apple.com (relay5.apple.com [17.128.113.35]) 	by mail-out4.apple.com (8.12.11/8.12.11) with ESMTP id k5B0QP2e028224; 	Sat, 10 Jun 2006 17:26:25 -0700 (PDT)
Received: from [17.219.204.120] (unknown [17.219.204.120]) 	(using TLSv1 with cipher RC4-SHA (128/128 bits)) 	(No client certificate requested) 	by relay5.apple.com (Apple SCV relay) with ESMTP id 1F1AE324002; 	Sat, 10 Jun 2006 17:26:25 -0700 (PDT)
In-Reply-To: <20060611000745.GF12079@networkno.de>
References: <4488A29D.5040100@avtrex.com> <87hd2ukeb2.fsf@talisman.home> <20060609154619.GB12079@networkno.de> <87hd2um83b.fsf@talisman.home> <87pshhpaf3.fsf@talisman.home> <20060611000745.GF12079@networkno.de>
Mime-Version: 1.0 (Apple Message framework v750)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <580DB08B-162D-4820-907A-281E56B14BDC@apple.com>
Cc: David Daney <ddaney@avtrex.com>, binutils@sourceware.org,         Daniel Jacobowitz <drow@false.org>, richard@codesourcery.com
Content-Transfer-Encoding: 7bit
From: Eric Christopher <echristo@apple.com>
Subject: Re: [PATCH] (version 2) Change MIPS linker stubs to allow for more than 2^15 symbols.
Date: Sun, 11 Jun 2006 00:42:00 -0000
To: Thiemo Seufer <ths@networkno.de>
X-Mailer: Apple Mail (2.750)
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00159.txt.bz2

I usually prefer this style:

> -#define STUB_LUI(VAL) (0x3c180000 + (VAL))	/* lui t8,VAL */
>


To this...

> +  /* Fill the stub.  */
> +  bfd_put_32 (output_bfd, (ABI_64_P (output_bfd)
> +			   ? 0xdf998010		/* ld t9, 0x8010(gp) */
> +			   : 0x8f998010),	/* lw t9, 0x8010(gp) */
> +	      stub);

-eric