From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60070.outbound.protection.outlook.com [40.107.6.70]) by sourceware.org (Postfix) with ESMTPS id 66AFA38D799E for ; Tue, 28 Jun 2022 14:40:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66AFA38D799E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6S/qFgUdrGS1jvywwP9tDJ80+PbDGRVIiU5Xbv6tfDyfazCCFonMf6A8VVQDXSXEAyR2UTj3WYKvx+70ASW8wgXcrVhRhfc/+63z9qyQYGEfckRloiEvgumVoPXmfWMOLzu4BTc4D12f3w01THK1Ta6a0O+fEFvUrb0u7rUoPQg6OIeNwcCogJgdagFOgngRguWxowwTcP+Ej6yOa2EBgdrBrloaUraoS7EGQkjgIedXl80kwMPqcUdWUUN7vn60JUcRlTVrqt/OAgriiBfoNM8amcA+8oXFFL5kyzQ0Dg/lDMWCSr5mZyZ8a2UaiZKK6Id3HhNu4ay/3BSsKpyEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YEqhSjFcPkJNeA14N3YEidZMQxUZo+sIYal3Nvbg2Ic=; b=OYtBbKGmL3+5aZ37B82Zltb60hGadWq4e9S7BIjwgXMlw2PgPIsd/whi5tCZlJUACygrxkEv5PcXMCdKxsnzVUPTLNRZ2z9usNo6tEVtYz+PQKATBjuqqN061ar4VGcDr3Ge2BaZvi+M0HWjzwaQyQ5+wdcKSCNsV37/J949Hy0LxsCoeHmTr/uap9XBDGma/iDyoInNJdi9289C+qtR7KzDQ7LjtSba4JfIeg+aTPJ+dhnaXzLPFQm9Ww/c65NTXdkreFPvm4tQbpNekt59lKM7P7IiIpY0xP+qJykCgmsl+UU+1tlZFk2Kig7KpwW34pAiTMKWf15SMlU6YALOIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2640.eurprd04.prod.outlook.com (2603:10a6:800:4f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 28 Jun 2022 14:40:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 14:40:53 +0000 Message-ID: <582cf5fa-766b-9103-35e1-8e40d1acc3f3@suse.com> Date: Tue, 28 Jun 2022 16:40:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] windres: add quotes around preprocessor cmd if needed Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: binutils@sourceware.org References: <8f8b421d-7cc5-1b4f-7e55-5f4b41716b4c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P195CA0015.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3d45763-8aea-4f48-dbc8-08da591433ec X-MS-TrafficTypeDiagnostic: VI1PR0401MB2640:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eGD7rNZTqObwmHSxEF6TfvbVncOdvgQzIzz8uPA/NA9VUVmBIcUZXqvxrRExnL1nlkw4KbPUMkeD7coA6ZsdTwna0JIdr/eB9bpsoytdZbSe8yJwWVa53lsnnmRz3NsQKNF++IV8ptwbauccekG2iKFxbIu4d82PNxUNUj7Wzu6/bDJDUKWTyp94DqSqNaV8QVNTx3eUzY7aHvxCvhOF4NgElXInSOKKUPoma8/TUxiItKHbXzMSLsxYYsBBiFbuqeR1yio9fmlZ79SwOQl3TStZUyKJuzMKH1CFOkGJX6xxxYxRJuHxt/BhwCCR7fx+Z3xtdd6yXQ7B1y3pIzOkryH4zNWicPJczj1ZCiMGpzvOFf+uQrrGjX6GQE3MtmsZsbtvuxf2ux85dug6s5b+xa2W9ntlWA3Udop4ke7hwG2QZdTi154P4Mg8PglbKdypbpWXE/dHAzC/dedErSG849JlonyLm3sqWnZsIhZFlBxNPw48roCFxhoTohr6tejNe6GIfMcC7BMyiKty7jOn2p0XozGiuPQ5ZVMj5EDnoVRyuwlO6SR4OVybD4cAcbGLGz4qesBu2bUiS35eRl04gDRyXPgTHfvHy0tJvQb/ADWdYmfgKDQaVccHJahAygwI5iD7KgaKuWD1Mdpnl66JzfTeWCybA/ci6c9HUO5Oajg7fcu8Fu8johlVZhcx6Wws/6Yrk3CWAIZsiClHAeFO2ixyoLg8sap/pF+me9yxz/OY3m9od8EPv3XRwDEa7jWjW60VE46D0c5eSeoqc0fSun4DZTc/wNFP3Kivjpk0vpxXi62HlmvsQze4JHSlK0hsxpFdCzDs8q0xp7ftiOjEqBatvaAshqRrc3ip5xbgkWo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(376002)(346002)(39860400002)(366004)(966005)(66946007)(66476007)(66556008)(36756003)(38100700002)(4326008)(8676002)(186003)(316002)(6916009)(31686004)(2616005)(6486002)(41300700001)(5660300002)(8936002)(26005)(66574015)(6512007)(478600001)(6506007)(53546011)(86362001)(31696002)(2906002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWxxTXN0cHpMU2w1SG9tVTlYSWp0blJ1Q2lUbDBJSE5SQkt2U1J5dFZFa1F5?= =?utf-8?B?M1gxcjFIYWRCSGgyT1VyUDQrbDkvMUk1VGhlU0NIcXJQclNERzdPdkFtMkdt?= =?utf-8?B?T05GNy9xU0hDeUdZTTJCbVpCRDF3S1VVWXIyTFd6Y3YzSHJ6anNGbXhURmFQ?= =?utf-8?B?V2g3d3UvRUFBNldWbCtMVFhPakV3akJVYjZtYmlVNVhVdEdpVHQ5VSt0bm0r?= =?utf-8?B?QWRzcGs5OWcwMXNnSW5sSkhyRU9iSkhEbUx2Ums1TmFHN2J1dlZJdStlTTFR?= =?utf-8?B?L0dENlB4NFhCRnhqVUM3aWlzSU1JbThqcHJFb2ZyYnhvVWp1TDgwZ1RjcjZ1?= =?utf-8?B?dzhicmFEQVJKLzBmaW5OSUdtY09lek9zc2xHSU14aVg3L21kVCtwZzhHWVo4?= =?utf-8?B?MUI1ZXFpMDZwYm1WNXJCMzZKeWZlTGV2dFdCVUFJWi9HVVB1S3E4Qk5aVnNa?= =?utf-8?B?UFJzL1FuWW5FZ1JKM050ZzVJSmNTYWdETlhvb08xV1YzUXF5ckVHeVFxMVNG?= =?utf-8?B?aWIrVHE0dW1va05vRlR1ZlphUVUyMm1kcWsvOHdGWElnMHF0VXNZcTZHdTdt?= =?utf-8?B?R0F2QXQwQ1NieXJ3WTROUzZOaWdVVXZBeEhhVVRZOWYzMkdDSFpJb3lJUnZK?= =?utf-8?B?MnVVNUR6c0pZZDNVcmt6YVJSUVNkSndnd3AzK1l2OC9yQ2lZRUZxNTc5OUta?= =?utf-8?B?bnNZU2JMTk5vYVJHQ2RUL0JvUVFrd2diSUl2UWp3eTFKUGR1aFZDd2dsdEFq?= =?utf-8?B?dWZwdEtPbFZBSjlDU3BreVV1OFBOK0h4QWxWV01tODZCRGtKd2FPSnhFRGZW?= =?utf-8?B?K2NOczU4TFNwNEJPVk5JOHBkQUZ4UmY0MEI1dHFHK3lRQ051SXhGbXUwMUZI?= =?utf-8?B?U2NBOGtNTVpMeEprQzR1cUNyNWM5MlRDcGU3V0kweS85aGtQbnRha2ZCU3hs?= =?utf-8?B?ZzVvYkQwZnB0aFF4eE1najM2SUYxVm1xYmdWU0pZelZQOXp3Y3gwdHU3M1hl?= =?utf-8?B?Wjg4U2lXZUgwTGN6UVMzeFA4ZHVkd1VOTlRUcTBSRjRlcnc3VERaRERCQXo4?= =?utf-8?B?ODhhMW1oeHRDaEs2OWhTQmhhakpxZUorc0FaTENHYmVzYjdiZmhQdjhYWm1N?= =?utf-8?B?QWVNSTdDNllRUDVSdTdxZW0rMnQ0WmwzaGVETmdEcERkcWFDZ0UvNDJ1bzRC?= =?utf-8?B?cTZXellOdXZFTjVseWYvdWpRUkc5TzlqZllwUENqbk5OM3cybU1QaVhQbGZK?= =?utf-8?B?WllGMG1pMzEvdzZKeTQ2UEVmU1IyYXRDRW5YUE41RitUMGRHVUQvWURJbXdE?= =?utf-8?B?eXlnNVZPYzB6UjZwbUM2MlAxVGM5RkhNZzdNaCs0clM5ZVFFd2hVL2hVWVJV?= =?utf-8?B?Q1l0TG5yU2JBR0RXVmtjcDlFUjYrTUZOdlIwZ1NVcm5WRE8xNm1MT0xBbmd4?= =?utf-8?B?UVpMNjk3SmxScTFiQkFjcmp3TFh1RWVEOUZEOStYdUJzMmVlazVIQTQwcDdh?= =?utf-8?B?OS9kWEZrZWpSVlpaVEZZajNCN1BBWm5SdFhVQmg1RmR3eDdqY3RSeVpTbG1q?= =?utf-8?B?anZsVW9WZ2NQR3BBTWZIZ1U1UHZvandqTGZPR2FXSkRaVTQxTDJjN0g5VGVV?= =?utf-8?B?SXJaWFUwSldaQ1BSQnV1OCtETUF0ZlhFWW5EMkZTUzMzTStnMUNaM2pzakJq?= =?utf-8?B?OUZUUm9UYnhjaFZsemFUWGxEd3A5MGs2UXVZUHQxMUk2dE8ya1dmNTZxUnJw?= =?utf-8?B?ZFg2ek5yTlZGQkpPZ2JaNmNTS1NTWEF0Q1ZPU3Vmc04yT1VhZjdDV2NsK1JZ?= =?utf-8?B?Z1JMUy96dU9lMXJxbVlaZW80aTRKc0RNbS9NUENJeXpkWFRXVDJlUW8vVDlB?= =?utf-8?B?dE56WnhUdnlMQWVidXJmRU9MZElRc0I3OWwveWZlSU5jUjIzc2JjcTAyUnE2?= =?utf-8?B?T2xPeDM2U2dxam1zUG45eXlYbHdINzdJUm5rcnRiVDZOMEpmcktuWWhhR0JH?= =?utf-8?B?TEZsd1FpNXhLMGN1QW1BMGg1eDB0T29qS0FmOWlkaFBwS2xKc3NaOE5RRllU?= =?utf-8?B?MmowL293M3VuSlJMNjRKVmxieUlCclBEZFN6azZuR0tweUlPZkxmbG1meEtw?= =?utf-8?Q?X6vlFnVhp9q750g05UAXd8Qnm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3d45763-8aea-4f48-dbc8-08da591433ec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 14:40:53.2818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iqlW4JMqDWeM+QUQds9Ht5iwI7ovVPk7LLm6vUOdagV6irPbVUTlw7vY5WQ8005bMpG1peXbfhN67nc2hWxH6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2640 X-Spam-Status: No, score=-3030.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 14:40:57 -0000 On 28.06.2022 16:18, Clément Chigot wrote: > On Tue, Jun 28, 2022 at 3:52 PM Jan Beulich wrote: >> >> On 28.06.2022 14:26, Clément Chigot wrote: >>> On Tue, Jun 28, 2022 at 11:37 AM Clément Chigot wrote: >>>> >>>> On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich wrote: >>>>> >>>>> On 28.06.2022 09:35, Clément Chigot via Binutils wrote: >>>>> Shouldn't you also (optionally) quote the pre-processor string >>>>> if that came into read_rc_file() as non-NULL? Everything else looks >>>>> okay to me. >>>> >>>> Yeah. I didn't run into this issue but looking at the code it should happen >>>> too. Thanks for pointing it out ! >>> >>> Actually the space issue is already handled by windres.c: >>> https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=binutils/windres.c;h=4df821ee8451bda70490d6626707c2bdd66eeb5f;hb=HEAD#l887 >>> It's not as complete as it should be. But apart of "%" I'm not sure >>> any other characters caught by "filename_need_quotes" can happen >>> in a folder name under Windows. >> >> Oh, I see. I'm not sure I see a strong need for dealing with %, so >> I'm wondering: Are you intending to make an updated patch, or do >> you want to commit the one you've got (which I'm okay with given >> your observation)? > > Honestly, if this patch fits you, I would merge it as is. Feel free to commit it then. Jan > This issue is already > a corner case, but as it's hidden inside windres code and because of > the existence of the "Program Files" folder can be problematic. > The other has to be triggered by someone explicitly passing "--preprocessor" > with an unusual path. So honestly I don't think it would ever happen. > >>> Making "filename_need_quotes" more global might be a good idea >>> anyway. >> >> Right, but that could be a separate change then. > > Agreed.