From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id F04643858D35 for ; Fri, 14 Jan 2022 13:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F04643858D35 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-gZfLSsdNOYeqFAWQUk9FiQ-1; Fri, 14 Jan 2022 14:40:17 +0100 X-MC-Unique: gZfLSsdNOYeqFAWQUk9FiQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eOYDyfWpIOjcvnTqUjwFpgXLTPQvPKZ9T86kdcCbuyZSOHdFeuGs0A7PzAxGgHpsVZLIo2GZlnnPeNUBk2+7ynBf1rMsWW7XfNM5C+ewmTKBWR3DVZQnrmhrU9Vque9RAFb5kpn7jUo5nfzQop6ZAuTlbU07srS3OnrqYFA1wM8/2ABUDniXu9oFiBUtT5aCac1sdySZ+MBxwxLfTWvL7TqnQO4GAr758z1myh6LLP5h0TZeQdav7qKmvj95EvPYrz7qXQXh2ri35dWQ6pv6bUkWR713f9ahMpHscjWBGni7TSa+WFLmKHItklwk75DqxSden5iCapU6SrKYqp37jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQnkbuin6ELQ/gQB5XeDdO+2XpDZH0N5RnYbWaBu3XU=; b=FYKjyFlshU0VhljHGacv/CvoeUJC1q5NlPcHfisMZ16aAAl0NrhRJD6/ZRYZdu3ADLONpJdhf1k0dKV5Iyl+aFUS41+hfTYrdM1bfdI38H1pK15GWfAbeynvw5SpuYcMEUclwh6dPuF8r6e8An+RCKniE4SRaviejxV+DrbTWR/FtE1+WmvUaAGzOPW/rpYG2aqy+vGH6XE3Bc1VLSxQV7nHlL98+ZYUD4giRNNOUK0hGPlTbmq8QhXlMQL4dEju3Ms6akjfL11tz5Lq0UomgB6y7Liswk0jABdUHoICpqj4EbM5Ek/skIyojnjnQ6cq0p5CA7jvW/9KSFVPJfXxBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Fri, 14 Jan 2022 13:40:16 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4867.012; Fri, 14 Jan 2022 13:40:16 +0000 Message-ID: <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> Date: Fri, 14 Jan 2022 14:40:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20211229193949.146079-1-hjl.tools@gmail.com> <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0016.eurprd05.prod.outlook.com (2603:10a6:20b:488::7) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5378a625-6270-4439-8372-08d9d76365a6 X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:651; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y0rAhaM65fWzC6RZPmjAX21L2Q5P1rMpz1NGXcF8cbZh9OYcaW9GuHXI6Cd3PIZqB8Nx0uPmJF+9H91FCpwSjTxVnSyUGAhiv826QWBwgtqpMx57wZipYRkzgKMvT4kRyaWdURd6FkBNRF/wa4lMcAs1PdPNAYdtzlXLFuhyw5kBM0BoFAUEAoXf1CSU0BTwVp9fu/YO2q4anUGLbvW4YzDgpAZLUHmob9X9na4Vbf2RRksffe+DutrGvGf/EA3z0DIWmkCJSCUH5aD98Dz3YrL9RI8egbhfw9BZH/RHAP8abD4m/FlAzpBrwKzSBqJA359bQhrNvdqxGjLVg44F5R4Ro6rrYyb37dbl3BbxJj9sjkDljF/T70sJ83KILyyeR3HbBmtDHvEOM+sZNUI+SFsqerZMiOe9L4r1LZcwBD27FrgYvdkcfybBXOlr5U37EDJzeR3fkU3CVG7CsZJFDAG3taXn1uqySeQM2n4/fyJIRzVrpKF0J1xkKKtGNBChiVL+/o3jbuBkR5e8uebBgBTj/M0/nKySx+2z9LwVrCCqihsDd07PKoFmDC4qjkmvaMmZDGv9i/gRgphxq4EhYB14Yl/KIsrvSFkKjeRfQaxmheDVHWdl/BI6pbvWXbmY1SRMuPASEum2Rj1nK5kRX+ONF8LGjO7fhQyjFItU0A9xryg3CXWUrql0jbjJn2szOMSDtclpYNW4q+n/2TbIRUTMrssOlLuczikuVLhUNio= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(83380400001)(316002)(6916009)(53546011)(8936002)(38100700002)(31696002)(5660300002)(6506007)(31686004)(86362001)(2906002)(508600001)(36756003)(66476007)(66556008)(66946007)(8676002)(4326008)(26005)(2616005)(6512007)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm8zb1pQL0Rnd1VtcmlQTDNKdXh3V3ZIVGc2azlBQ2FnaTdrRnBRQUtYZmNH?= =?utf-8?B?WTVWRU9IZXJ5elZTdjNlQVA5RUJUZGRVK2J5WjVoMVVybWorenhQWnZzUW85?= =?utf-8?B?V2xuaHpOTWNCeEs2RWYySk1DMUZCakdKQU42aVNNK2c0SUpxOG5GR1R1anJT?= =?utf-8?B?WW8yanZnRHhBelo3NFlNYkhpdm1yMk5IVFdtMURMM0dwOXVXQnZlN3c2RjVj?= =?utf-8?B?WDF4Tk8xZmFTR2x5ek5iK1hyOHk0QVpYa21wcFBPN201RUJiM1luOVZKMG1a?= =?utf-8?B?SlpvNlZGcld0RjBJL1h0ZUVXZXFCdnluVVBEQ2gwVzUrZlRXZ2tSSzdNYmhw?= =?utf-8?B?cm1DYlVuSlExa2U2bUNRMkdTUUI2cjhtcDd4SllYYjA0K3BSNGFsT0JDdVR1?= =?utf-8?B?WGowUDliWERVdnZUbVF6dlk2eWdobEIwVWJ6LzJrQTJlSWI4N0grSDZDYmFD?= =?utf-8?B?WjBaNXd6d0hwb09qU2UwblhuR0daVFlYdnVMUzdic05iS0VkWW9wdTlBZTcw?= =?utf-8?B?clNnaGlxODJZVW5xaHJlRmdnMmJOYWFRd3BJUmRySEZYZ0I4WlpTTmU5OGFY?= =?utf-8?B?Q0FpdzFYaXR1SHhvYmc5Mjk4S0lQMEk5TXFnNlZ2V0NoMC8welFidGEvbVZq?= =?utf-8?B?Q0RnUUdkRm9xOVAyU2FuM3ZUMGkrUVBzT1l2RDB1bzZ3a0NYNWhQa3Nnc0xW?= =?utf-8?B?bEV6Q0Z2VVBDc1hPSkoxeng3Nzl3UVJmd21uc3lLMzFHNDFWeDVmMHdzTmQw?= =?utf-8?B?WWR2Nk9OVFBaWXRKWjJTdEt5aWVVdlhCdEJ2eW0wTzhMWjZCWjZ3bHRrcTVJ?= =?utf-8?B?SUZUUXpYN0tJUnFVRi83T2pwVzJGTmwzNHQ5d2hDK3RJYStLT1dPWU1Ra1FW?= =?utf-8?B?ckVCNm9EVXVaek5oNDlOZGRjWFpCeTdkWHFnRnZjelZYUy9JMHZ0dHdGb3B6?= =?utf-8?B?UU8rMUptZFhGYW9tdWVud1NPSjdXMlRoUEdNYW1xUkpibmdiZU1YU1NaMHVU?= =?utf-8?B?N2QrVElIVVJDbWszMFFMNmNGUGFlbmI5M3NzeG5takVmajZnMEF0S0JaaGoz?= =?utf-8?B?WCtXdGFGOGh3NkU0RGxXZ1BwNmlXdytTMGd0L09uMkw5WmhKSUg0SzlETDFS?= =?utf-8?B?amY0aDhYQUIyUjh5d3h0UFAwUURnb0NFQW42L2hudmNTNEZudENCQXp3T2RO?= =?utf-8?B?d2FBY1lVODhLU042MjNXQitpQUc4aThYYTJKMy81QWRid0Qxd1hITVpzWkYx?= =?utf-8?B?elpKS3pmMFVPTVd3TWltWXdMRld2UzBuVVNNY1laaGdCVjJJTXBoU09XZFNH?= =?utf-8?B?T0xPcXR1VTlBZFhLd0YvS2xRU1B4U1E1bzJiUTZ2d2h4QnYyciszZE40bEd0?= =?utf-8?B?TkxGd2toMHlBbUlmVkU1cmZaL0UzeDFUTURQRy9YVFYxUmU5ODQ2a0xUWFBS?= =?utf-8?B?S1B4RGJrWnRJVVBYV3V5bmQvQW9XdU90eklpanM5RlpPTFMrN21jbnNsUXVh?= =?utf-8?B?cVRvM0duS2I4OERFQ0ZTZkduL2tERXpvVnZQNnJxeWdmenZZOFNEMDJXWm9a?= =?utf-8?B?UDBUVHpibHQwSlBmY05qLzBPa1ZRcDBRTytUVTVwT0tkL1BxcklWcVpDTUVP?= =?utf-8?B?K3U2VVRKQUVBdHh6eWlTU0xSYjNLTTZFUWFLeHY0ZlNiSG1IbURGSXNtS2RV?= =?utf-8?B?SnFFWlg3QS8veGtsdlRhZjVkaXZzSG5JbElIQ1RBQmF3a0RsNWNBVmw5Z09E?= =?utf-8?B?VWxtSVZ3dkR2T1lqTGlJT1h5TGJMd3FvM21mWHZyZTVJU0xrYXhwdU1QYks3?= =?utf-8?B?alFYK1RTL2xFYXpJbGFvNkUwakxWSmFjaG1zSDFCVkM5VythRHhsUmtrR0JU?= =?utf-8?B?NkFKbm5ZYVZKZ2VWSGpUcExONms5Ym9LaEs2OFN4N3ZuUE5aWG0zeGQreGZv?= =?utf-8?B?bEh3TG9sVjhZSnM3YmxvaW5jT1RuejIvUUNWdi9jcXlHSTlXVWtoamNnQjNT?= =?utf-8?B?S1FFSlVHUG8zNHpIV0s4Mm42VHlXdEZ5KzllVHIyNEUyMWhUQ2dCdXlUVGs5?= =?utf-8?B?eEM2THFhb2VZbGJHa2tCSmNFbmVpZG03cGF4ZEVsbksyalVvVXRIWVZPejlG?= =?utf-8?B?Y0NqeUNDbmcyOG1Mb1RXeWFhTnJaSzF0VktqczBRS09LUTBPc1hEUnBIUXll?= =?utf-8?Q?RQpqGXgggIPv2VuIQPRGs40=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5378a625-6270-4439-8372-08d9d76365a6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 13:40:15.9589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2J2GrsSC/46ExoCWZMi/79srI9arP+JiCx0o1CD4sO2qbx+Tl2pfDoQ3Pj9ak4uPb4CUeDpOxQGVNVMJ6/VYEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 13:40:21 -0000 On 14.01.2022 14:03, H.J. Lu wrote: > On Fri, Jan 14, 2022 at 12:27 AM Jan Beulich wrote: >> >> On 29.12.2021 20:39, H.J. Lu via Binutils wrote: >>> --- a/ld/testsuite/ld-elf/linux-x86.exp >>> +++ b/ld/testsuite/ld-elf/linux-x86.exp >>> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \ >>> "" \ >>> "tmpdir/indirect-extern-access-2.so" \ >>> ] \ >>> + [list \ >>> + "Run p_align-1a without PIE" \ >>> + "$NOPIE_LDFLAGS" \ >>> + "" \ >>> + { p_align-1.c } \ >>> + "p_align-1a" \ >>> + "pass.out" \ >>> + "$NOPIE_CFLAGS" \ >>> + ] \ >>> + [list \ >>> + "Run p_align-1b with PIE" \ >>> + "-pie" \ >>> + "" \ >>> + { p_align-1.c } \ >>> + "p_align-1b" \ >>> + "pass.out" \ >>> + "-fpie" \ >>> + ] \ >>> + [list \ >>> + "Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \ >>> + "$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \ >>> + "" \ >>> + { p_align-1.c } \ >>> + "p_align-1c" \ >>> + "pass.out" \ >>> + "$NOPIE_CFLAGS" \ >>> + ] \ >>> + [list \ >>> + "Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \ >>> + "-pie -Wl,-z,max-page-size=0x1000" \ >>> + "" \ >>> + { p_align-1.c } \ >>> + "p_align-1d" \ >>> + "pass.out" \ >>> + "-fpie" \ >>> + ] \ >>> ] >> >> The two PIE variants of this also fail for me on glibc 2.26. Looks >> like LOAD segments' alignment isn't being honored there, at least >> not if it's as big as it is here. >> > > The PIE alignment needs the kernel fix: > > commit ce81bb256a224259ab686742a6284930cbe4f1fa > Author: Chris Kennelly > Date: Thu Oct 15 20:12:32 2020 -0700 > > fs/binfmt_elf: use PT_LOAD p_align values for suitable start address Well, then the test needs to be skipped if that fix is not in place. After all you're testing binutils behavior here, not kernel or libc one. I'm running a variety of (largely up-to-date) kernels on all of my systems. But it looks like our kernel folks decided against backporting this particular change. And I don't think you expect people to remember to run the testsuite only on top of "certain" kernels? Jan