From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 875C138357B0 for ; Tue, 15 Nov 2022 11:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 875C138357B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-x633.google.com with SMTP id ft34so35157262ejc.12 for ; Tue, 15 Nov 2022 03:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=41E4j2thxx/chOqpdlrPLS7shXN3ISq4siftPSO7kvg=; b=Ke+nt2deEvR+hDj1RnMpuOi5sk3OtpACsVesiKWZiglQp5O7+eqPI3Z1jX9vtScffO dPkFOaohN/mrqcX9VJMbC6sSSUa7XNUy0dguJbDfCTfS5l3li3gZvYnyf4s1MAfk7ksN AdH+A/uOrFCPEDjrq24ly1SnHeaV2mKzAiVK99Epa8kqfq8+uaW9CZksMY7QyW3ck+ht ifcDLdQF5lpNhMWaFL8iMKU1RkPTneiAoDjz2ih6RoC9RMIm76U7MCxlvekTQXAdG6jp meR39dVb02RKp0XCA+pgAZEE5tHEBFBGzN3nEgH0UvClSrbizxCP8o2xh2/1ETg1ZqpX bJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=41E4j2thxx/chOqpdlrPLS7shXN3ISq4siftPSO7kvg=; b=dBjJ2Jb5PMAtFAi+scEAiGVNCpJgNfYwM7lFVI1OKajoowbsjh2PE9dX+9XwpeDEQ+ tNlfUCwMXHvNqS37UpfYAQmelLIntNL/gCJKDNRhEXk5urRHneHI1sraf99VNF0wvSNJ sgerm9hEM9E2wSEDAeN+VG26oqkfADYfWxVzsL7Z0VMc74aKXBwbfQJd+FLufVCkzQK3 5MhF73DIYjJwGiyOh+xAA/aw7CPJUx9pOfjD2hkPFb3kpDydMIrjQ3SCdOtXaLoKkj5r lwyKJ/9FAMBQSmtYAdwyshASJ3Ve08kIoj+3/R1xe5Tyo1ZtZSSBAL7eMceGqthmHmfr U55w== X-Gm-Message-State: ANoB5pkzWS3hy75Zn739BCPRMvJtsUKUU1klpopYCoMquexC7Bs4t6iR 6cyels75+1lUoLkGnNzaM+AT9fIYsbN08Q== X-Google-Smtp-Source: AA0mqf7rMWHFvOlgsITlpO+Fw91BgD7NlUkos7A93vYyFya1l6qyT4ZVDUoV4aouVQNwr0EokMdZow== X-Received: by 2002:a17:906:8d06:b0:78d:8d70:8bf8 with SMTP id rv6-20020a1709068d0600b0078d8d708bf8mr12928754ejc.15.1668511392229; Tue, 15 Nov 2022 03:23:12 -0800 (PST) Received: from [172.31.227.58] ([94.230.145.250]) by smtp.gmail.com with ESMTPSA id g7-20020a056402320700b00463c475684csm6075957eda.73.2022.11.15.03.23.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 03:23:11 -0800 (PST) Message-ID: <584ecd9c-7876-8e2f-4610-8b51cab366b8@linaro.org> Date: Tue, 15 Nov 2022 12:23:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH V2] GAS fix alignment for aarch64-pe To: Nick Clifton , binutils@sourceware.org References: <1fc98550-06e7-284e-3f1c-dda991bdd0e5@redhat.com> Content-Language: en-US From: Zac Walker In-Reply-To: <1fc98550-06e7-284e-3f1c-dda991bdd0e5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Nick. On 11/15/22 11:50, Nick Clifton wrote: > Hi Zac, > >> For the aarch64-pe target various values of '.align' causes writing of COFF files to fail. >> >> This version of the patch differs from the first by using the write.c implementation of SUB_SEGMENT_ALIGN. This means there was no need to modify md_section_align or aarch64_handle_align. The change is specific to the aarch64-pe target. >> >> In my testing generated aligned code was correctly padded with nop. > > Patch approved - please apply. > > Cheers >   Nick >