From: Nick Clifton <nickc@redhat.com>
To: Pip Cet <pipcet@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] [WebAssembly] Skeleton support
Date: Mon, 27 Mar 2017 10:22:00 -0000 [thread overview]
Message-ID: <5861ab5f-02ab-3d32-f874-96681ab8c319@redhat.com> (raw)
In-Reply-To: <CAOqdjBcbL8-_KwufBPb96V6d0hh_QT6Sx2-tdWXu==qbUpRRZg@mail.gmail.com>
Hi Pip,
>>> + {
>>> + if (bfd_get_error () != bfd_error_file_truncated)
>>> + *errorptr = TRUE;
>>> + return FALSE;
>>> + }
>>
>> Why is it not an error if the read failed for some reason other than file
>> truncation ?
>
> I may be misreading the code; the intention is that *errorptr is set
> to TRUE, indicating an error, for all reasons except for file
> truncation, which indicates EOF, which is not an error if we're done
> with the last section.
Thanks - I misspoke, or mis-typed if you prefer. The code does make
sense now that I am thinking clearly.
Cheers
Nick
prev parent reply other threads:[~2017-03-27 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 23:21 Pip Cet
2017-03-22 12:55 ` Nick Clifton
2017-03-22 16:12 ` Pip Cet
2017-03-23 2:56 ` Pip Cet
2017-03-23 14:51 ` Pip Cet
2017-03-27 12:44 ` Nick Clifton
2017-03-27 10:43 ` Nick Clifton
2017-03-27 10:22 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5861ab5f-02ab-3d32-f874-96681ab8c319@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).