From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17936 invoked by alias); 27 Mar 2017 10:22:20 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 17789 invoked by uid 89); 27 Mar 2017 10:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:618, skeleton X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Mar 2017 10:22:18 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C9AB0C04B938; Mon, 27 Mar 2017 10:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C9AB0C04B938 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C9AB0C04B938 Received: from [10.36.116.228] (ovpn-116-228.ams2.redhat.com [10.36.116.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42C4A18854; Mon, 27 Mar 2017 10:22:18 +0000 (UTC) Subject: Re: [PATCH] [WebAssembly] Skeleton support To: Pip Cet References: <6ba7849d-2475-587d-d4a9-6e67c7df550b@redhat.com> Cc: binutils@sourceware.org From: Nick Clifton Message-ID: <5861ab5f-02ab-3d32-f874-96681ab8c319@redhat.com> Date: Mon, 27 Mar 2017 10:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00336.txt.bz2 Hi Pip, >>> + { >>> + if (bfd_get_error () != bfd_error_file_truncated) >>> + *errorptr = TRUE; >>> + return FALSE; >>> + } >> >> Why is it not an error if the read failed for some reason other than file >> truncation ? > > I may be misreading the code; the intention is that *errorptr is set > to TRUE, indicating an error, for all reasons except for file > truncation, which indicates EOF, which is not an error if we're done > with the last section. Thanks - I misspoke, or mis-typed if you prefer. The code does make sense now that I am thinking clearly. Cheers Nick