From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6112A3858D32 for ; Thu, 7 Jul 2022 10:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6112A3858D32 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-489-9FNlTMSBNTq0JsJVzt6ewQ-1; Thu, 07 Jul 2022 06:53:37 -0400 X-MC-Unique: 9FNlTMSBNTq0JsJVzt6ewQ-1 Received: by mail-wm1-f72.google.com with SMTP id h186-20020a1c21c3000000b003a2cf5b5aaaso603778wmh.8 for ; Thu, 07 Jul 2022 03:53:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ud7Lg63wPVsUp5fwbNfmSqcon2Yw7ejwHJO1L+AyDHo=; b=5HjpM9lu5eg1AsY99JLl/vPUdTbNHLwHXqDKNDu+MAn731C0ls7TunXL2b71o6XvGn m+JLDMvJ68U/JFPDI0f9KFoZVT8/Iu2DWqw9r7L1N2S8Lpul1kfTcAOaxlTAb1aWwtyV i2P9IsWtFYhTNEOM3ci3ZlehDVOByDKFCS15FViNjVbwSyC8JkqoxKmBIGv3aLE2BSvL cWDWDJV7nSmtD+pcmJ4bHUspFFTK6WYKLFQYZcNW+UyeGQl7vtdr60Q24kI5l6mlIx7u Cz51/U9svOZSe1J6w9K9hAAZx746tRqI9M3m7jUpeSbm0teoOX1u/alw7dud1KggN8EU EUKg== X-Gm-Message-State: AJIora+HCOXut7x8DkhS97AXA+ucDVNxzBCicyp5YZ3j4NRRd8v8Hs8i davR68wybKabEVuyC+m3vDG0dH6LFPD/JcL+c5nzuyASISNvtodb9C/8dSgH2C/80+k3tMrmvmq TOa0xQnvVvQ8V2qAHdA== X-Received: by 2002:a05:6000:1a89:b0:21b:83a9:aa6f with SMTP id f9-20020a0560001a8900b0021b83a9aa6fmr43327526wry.33.1657191216591; Thu, 07 Jul 2022 03:53:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1teYbpfU3SW3/EEChfUIfAZz8sH7m5vPo77ybw9ku/OML0u1iqa72vqEaMZbWMvif7Z0wtsLw== X-Received: by 2002:a05:6000:1a89:b0:21b:83a9:aa6f with SMTP id f9-20020a0560001a8900b0021b83a9aa6fmr43327512wry.33.1657191216448; Thu, 07 Jul 2022 03:53:36 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id i8-20020a05600c354800b0039c4e2ff7cfsm26022751wmq.43.2022.07.07.03.53.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 03:53:35 -0700 (PDT) Message-ID: <5870a0d3-3d7a-a1b2-96c7-a387a895bb7a@redhat.com> Date: Thu, 7 Jul 2022 11:53:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] libopcodes/s390: add support for disassembler styling To: Andrew Burgess , binutils@sourceware.org References: <20220707102509.1267936-1-aburgess@redhat.com> From: Nick Clifton In-Reply-To: <20220707102509.1267936-1-aburgess@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 10:53:40 -0000 Hi Andrew, > This commit adds disassembler style to the libopcodes s390 > disassembler. Don't you also need to set "info->created_styled_output = true;" in opcodes/disassemble.c:disassemble_init_for_target() ? Cheers Nick