From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by sourceware.org (Postfix) with ESMTPS id 18B6A3857371 for ; Fri, 30 Sep 2022 09:41:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18B6A3857371 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWvQAvDyzf3crT3VBCOXikFyQ/aKtmD59Zxh45hihZ3xD1UGb7xVC5nQuA/4i5KkW4StQd9o0UqLAm8PueYQu2BxIZ6eT4nOkqpmPd9uJZt8wgalTpC1Fv0FcsLdyFSYtKTmOb9XLJGOEWOc+ya0GK7xc0I7mSciv4k/fi5CntPesrUq/BACTN7EMVdpghZF7CXN7iktzpynYIax943d5v5RGunNkLpqSdyBL47/wMWEpLHSoBSk3na3lUebpI8/WUN2gbpektcfHwrGgzL0+7rCShaMJfAp/5cfIzaQm4gc3W4L0JPaP0pIkujrWeZDWr3fCM21VkqglVLGJJZ6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H17wHmjwDAEMf/LDrzULoccWoRSmpjt5+lcLsrD1CUA=; b=B4h3l1bxFll6RDiyB8pV4YhxqIvFiPYfs2UO5XpHQm3gn0FAFT9xfdxRhwP1CSPqQSBMxwdGexscSt7WwL6//g13ir5QUyXN9HivsAUAEqYaLRZqx3PrBj/Uabn9GRkfy4SqssMH3kSMhBPqEefdH2xszqN9EKBMWoo3zOILn3QRhXFqJJFqJJh2KxkW5y87qPyFxecUMapY0vFZRFLebnjjEM+F3FSVcJgUAPF/GXur+OWWWe5mSfimpnxqOA4+nT3A9DTPrJBBxmFPMxiqBPgBjxRZRh8Fw35u0IiCFYjfMpyCZd+3PuekDLVdnbw1B4rSj22piydjvN9mABzeOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H17wHmjwDAEMf/LDrzULoccWoRSmpjt5+lcLsrD1CUA=; b=pMi3WMc39F9mxzsNh1ZNWmacN7rBTg6/8kLHQEp1M/FkLMPmWVWXagxpvsHS6HMf+ujBIU41St/Ed+fZSWZwUi59ABjvTufF+gHUcbuDPt/bJ66ng4JtZpr3t5sZukYyxpg9ER0yN9kkt273xICU/b+Sx/6NwXXdxLps06r4Nkw+V/iHPupRk9wkt+b5ZIcXsGbuBUsN57exPZK/ILVv7Pizf/ukiHQiwmamWBEZ+KTtj9CHsl1QGlu0fQARSW809R9GSateivQzRDxoRcw2QfkWzlU2g3J8KCEg79mpYcio4nGSE92H/5NV0JVTlEGy9/N4r8zrDw4wNUInv3hLaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7795.eurprd04.prod.outlook.com (2603:10a6:20b:24f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 09:41:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 09:41:30 +0000 Message-ID: <5874dd79-0cf5-d65c-7ea2-13adfc799c0f@suse.com> Date: Fri, 30 Sep 2022 11:41:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 From: Jan Beulich Subject: [PATCH] RISC-V: fix build after "Add support for arbitrary immediate encoding formats" To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , =?UTF-8?Q?Christoph_M=c3=bcllner?= References: <7cb92a0b-d1ef-e3db-4773-0b6cd5183272@suse.com> Content-Language: en-US In-Reply-To: <7cb92a0b-d1ef-e3db-4773-0b6cd5183272@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7795:EE_ X-MS-Office365-Filtering-Correlation-Id: b62515e1-bc49-47d6-75cb-08daa2c7f42c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7tJhETuof4taJCywRTErigiGlfIg7+w7ssc6M1WCKNtZJzfBc5aFZBYLH8qC8vVdtTrqnxsb81UX3PbRrjRc+SiWvng9wz0dZ6lzciNIftXMX2gOV+0PWojoD6TM5lJl5JZXaEpyq+d5dDZcDGFOuZlOV1+89v+yn7kbPeXm4pnRD5vUzolmKEDEMHZW5Blu+ZYmzBjasn6+P/nfg8GU3W30REPwtcQNBpP/jW5LbUVGhvmGa9ZKUUIWT+nOWwOJdqyuwAy/zvSfWHhuuCer6qXCSMi8mZiGJdPOFOOde2m49fG83mzUc1p75LoGJAi+N1X9ae10yO7Fu1yFWFEHFyR4wjxO7gM4zFMdRU3Z1y+MRatt/JMNSaczquwfcNmZm7SqDVjog0eHdnuaFx87RePsQZ3mXTffCsHy7MTnGx/wgA0XsUqPQhOtgDyipGoxHbIvCAIRCN0Lz5reQjxq7z+FSEa633VfOqgrc0uB6JTwnN1x+P38nq/GDKbidcYMv43iOQNIkF+przEPtr8cfvZRzCZVodTmM4iK6P2kfNUyiQJo1npcZ/tCbL36COvAiP4R+mhKqeSAfWb3tpW6oEL1y9qMzmhmkxxt2z3LXvbGSmfQSluyoO0D7mmjnpUVBbyycxFl6lchTJEo9vWh6tTwYNG2CtHTzpkJarGQZlN0W56+z+KlKd74Jf8nXfOt1Pm/2Z81eF47nA2FYvSDyNWT+jErhvUm34RjLMdE547iIReBXKceeXK+hR2CGCCePYMwaPYyGy6JbyU2rmJ7oWkD5LrS2F0rdwwzxrO6cFS8aPQ3/XoApH4NR1aArV4RFvOCn17by1ioJ6TEluSUFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199015)(83380400001)(2906002)(186003)(2616005)(86362001)(31696002)(36756003)(38100700002)(31686004)(66556008)(66476007)(66946007)(6486002)(316002)(54906003)(478600001)(6506007)(41300700001)(6916009)(26005)(6512007)(8936002)(5660300002)(4326008)(8676002)(14773001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUlzejR1OGR4bitKSFpQR2toczQwbGVuQzhwS1d5V1ZvQmw5Uzk0d2ZJVXlD?= =?utf-8?B?YTUzR2ZmeG5leUplbXBpZFVmUk5rRkl1Yjhva0xQdCtLc2hZcUNRTG9CQ0Zw?= =?utf-8?B?NGtDbkNjVys3akEzVWNqR3V5WTRYVHIxQldET2ZzdzZUY1lMdklZS3JrdEt3?= =?utf-8?B?K2lDRXJDQktOcE5hOXpJVXZHMjhBS01rRUJBSXZhM0w4T2tvY1BpTGVpTDVZ?= =?utf-8?B?M2tINUhyVEFFMkowM0VxUnlSSFgwZkd4NUhhTk1OaXUrUDB6Y3NVbXlJOWhm?= =?utf-8?B?czA5ZUE1NENkV01aRklPcUlIUG1ob3I5WjVzZ2JneDZ5ZTlDbnJzdXdqWnBZ?= =?utf-8?B?SzZnRE1NWmpsTnh2aXBsbmpNR2E3bkxBMHI5SXM2S2s1WERHMmF0Tis2MDNT?= =?utf-8?B?S3oyQzlxZ00yZjh4ZHplZTdMWFhWbjZ5WkluZ0tuWVZsWEhwbUIxZHJXYU00?= =?utf-8?B?bGxoRGhKQzRUNEZCdzFOUmdOQVNJdHVkM2dzczNZZURyWHJuS0MrdnAwVlVL?= =?utf-8?B?cWpMK3VMczNHempFZEV2SStjTmMxdHcxWExLZGd6aXZRYmxIc0RCeUNjV0hy?= =?utf-8?B?OFVKcDRTV1hSTjIyaFJZakpzNnkyd1UyQlpVMFRabEhDZEQ2T0FVeGJMQURz?= =?utf-8?B?T0VkYzFxVkdDUUdDWlVrcnBCM29rU0U4YXIzZERNZm1BT2UvKzJNbWNuWXVF?= =?utf-8?B?U1lTTjdCM1VmRFFFK21hR3NLWjJxbjU0dENHL01IcURNTWl5SkI5ZVg4TmF6?= =?utf-8?B?bnllNldzaFUza3gxVGxsUkdsU1Fabm9PRitzNFBKdFMydk1yRFhqaCt1U0dE?= =?utf-8?B?c3UweDhpa0t1bGpMakJ3STVteWdQU2traU45a2FUOXV0OWNPVmJtWnNKWE9U?= =?utf-8?B?N1BnbmpqNWJDL05WSG1WeGVLd08yc1A0NWhlaTVUZ1VidWlGNnF4ekx0SFpW?= =?utf-8?B?SWtMU09udlk5UWt0WFd2aUFqOUN3QUFwbFFjcWtSRXFPamVoVDJ3NWtiRUg1?= =?utf-8?B?OXY2WTNuWW1xSFluNnQ2NUVpdzFlY3ppTEw2Ny8zcU9IdUx3MXJlQlArTElH?= =?utf-8?B?azh0QmcrREJzKzVWNnYyYnJmMnJsbCtoTlEvUUMxN1lOWjNjVFp3d1NQQ0Fn?= =?utf-8?B?NGpYLzZPVlB2NWxyVWQrQ0hwdGJDaVl0N0pGTEdEbVBMRUlINkE2YzdFNlE3?= =?utf-8?B?NnhzdWRNVnZaczFrUzNBeFh2U2x6Mm9EdkxublQ4MEZjdzRZSDRvVnNHeE90?= =?utf-8?B?REFaY00xOUovU25yQ1dXVm5hWE4yNmlVUmhwNUc1NjJaaERGNDBVSE52U3BS?= =?utf-8?B?THVFWHo4VVpNVnBaY0M2bmZVTHNEZ3QvZEJDWFRrL096NktpQndWK2p0OHll?= =?utf-8?B?ZDJZc1VhdHZCVENRRnFMOVAvU09hR1RNVGZtVWNPeXBjS1lvbXpZRDlGR1px?= =?utf-8?B?elNzYTlaVTV1QzBUWngra3pDUW1uK3JZcFlPbDlES3hpeDJtbGNmbGZNc3U0?= =?utf-8?B?RlhwVDYrUlhwKzVmRWV1azN0NmsxV2FIclVYek0rODJTUUZTRzRSbG1hSlZB?= =?utf-8?B?U2Q0ZXRxT0c5YXhRTFpYcGpPeStsQUM2RDJHUVRMWWc5QmhpeWZyZzdEM2Ey?= =?utf-8?B?MlBONlNBL1hVcjBCbVNUWnpWazJYcFRPWEx0TGVpT3U1cEFaTENSc1VJZTZu?= =?utf-8?B?ZTZ5UmlvVzEwVitvM1JwUEgwYzdFc2F2VWh6SEFWRXdFMzc2bXNUWjFnZ3d3?= =?utf-8?B?MnRXS2syc1daTFRqcVVpZmhxcmVtenNVeHg2TjRkK05kSnMxanF1WUtHNmVL?= =?utf-8?B?ejlPTXk5N3U5WElmWFNuMUlNQnV0MnFyN3BFZGRCTCtEM0lQcENoZXB0NS85?= =?utf-8?B?UytxWkVkR3FkVC9HSU5wZTBGVEJjSDZUVitkc1ovQ0UyczZwRlA2bkNuTWVG?= =?utf-8?B?MG1Ca3pLekxtSlF2MGp2OUw1WmVYcytDamt1S25RQW82MzRJYmlzUDFocVZD?= =?utf-8?B?R2d0djFJSHJDbW1vSjNweGRNL3NmVG5YUkVXQzVsckNrRS9nMmI4T3VJbGtp?= =?utf-8?B?RCtmN3Q4SGxpNkFFVmVFOWE2Z1R0NjBsUXdYZDdzMjdhRnROdjkwWDFySVpI?= =?utf-8?Q?VrBx7YA/MkZ3JX9LFIPC4k0w3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b62515e1-bc49-47d6-75cb-08daa2c7f42c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 09:41:30.8217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jUjOsZPA2b90H/jWXy4sYl5an8uWABb63zQ27/gl8yBWIc0FnLdbY5MsoFGDJWT4BuljphGPzRBBABPPrG1lTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7795 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pre- and post-increment/decrement are side effects, the behavior of which is undefined when combined with passing an address of the accessed variable in the same function invocation. There's no need for the increments here - simply adding 1 achieves the intended effect without triggering compiler diagnostics (which are fatal with -Werror). --- Committing as obvious. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -1287,10 +1287,10 @@ validate_riscv_insn (const struct riscv_ case 'u': /* 'XuN@S' ... N-bit unsigned immediate at bit S. */ goto use_imm; use_imm: - n = strtol (++oparg, (char **)&oparg, 10); + n = strtol (oparg + 1, (char **)&oparg, 10); if (*oparg != '@') goto unknown_validate_operand; - s = strtol (++oparg, (char **)&oparg, 10); + s = strtol (oparg + 1, (char **)&oparg, 10); oparg--; USE_IMM (n, s); @@ -3327,10 +3327,10 @@ riscv_ip (char *str, struct riscv_cl_ins sign = false; goto parse_imm; parse_imm: - n = strtol (++oparg, (char **)&oparg, 10); + n = strtol (oparg + 1, (char **)&oparg, 10); if (*oparg != '@') goto unknown_riscv_ip_operand; - s = strtol (++oparg, (char **)&oparg, 10); + s = strtol (oparg + 1, (char **)&oparg, 10); oparg--; my_getExpression (imm_expr, asarg); --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -586,10 +586,10 @@ print_insn_args (const char *oparg, insn sign = false; goto print_imm; print_imm: - n = strtol (++oparg, (char **)&oparg, 10); + n = strtol (oparg + 1, (char **)&oparg, 10); if (*oparg != '@') goto undefined_modifier; - s = strtol (++oparg, (char **)&oparg, 10); + s = strtol (oparg + 1, (char **)&oparg, 10); oparg--; if (!sign)