From: "Jan Beulich" <JBeulich@suse.com>
To: "Nick Clifton" <nickc@redhat.com>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH] gas: require an operand to .startof.()/.sizeof.()
Date: Wed, 22 Feb 2017 17:12:00 -0000 [thread overview]
Message-ID: <58ADD489020000780013CF01@prv-mh.provo.novell.com> (raw)
In-Reply-To: <87o9xu2nmq.fsf@redhat.com>
>>> On 22.02.17 at 17:31, <nickc@redhat.com> wrote:
>> gas/
>> 2017-02-21 Jan Beulich <jbeulich@suse.com>
>>
>> * expr.c (operand): Handle missing operand to .startof.() and
>> .sizeof.().
>> * testsuite/gas/all/err-sizeof.s: New.
>
> The cris architecture is not the only one affected by this new test.
> The following are also affected:
Hmm, I had thought powerpc would be a very strange exception,
rather than the rule.
> Given the large number of targets affected, maybe the test itself needs
> to be reconsidered ? Or maybe split into two tests, one general one,
> and one for targets which do support the difference of two symbols in an
> expression ?
Thing is - the test doesn't use the difference of symbols. There
ought to be a syntax error long before that expression would
need evaluating. I'll need to go look again, but perhaps best is
going to be to remove the problematic line altogether?
Jan
next prev parent reply other threads:[~2017-02-22 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:31 Nick Clifton
2017-02-22 17:12 ` Jan Beulich [this message]
2017-02-23 10:20 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2017-02-21 10:15 Jan Beulich
2017-02-22 6:48 ` Alan Modra
2017-02-22 13:23 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ADD489020000780013CF01@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).