From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by sourceware.org (Postfix) with ESMTPS id B59223858D32 for ; Tue, 23 Aug 2022 14:24:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B59223858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mm1ZjbSDOB2+ihbMxCnQ08KoGqEOGRfWIE3RmxkpEcdiFHltguIkzLDPM0xZlmvoh9BUMAHgzeJ2zCFF47FtQ6IWNlXaVbDN1GgLxFCevMC5WXa9lMQtp2AfemwIPseHQFwvUS/LwnPqNQJTh1qHeQca2KSmIThQ1koRvJGXOnyLvzS60zxVlxUdbL7u/by3JV3vo/vhxUA75fB4nAtoHI2mE+LlSuFO++scYNbzs3XQlTy2tHgrS1J/RKE2N/ZNQ80p656BaIbbZKDynoAmzsipvz6wpHOE/GDHTjYnJU3jY3xGosNEvEPCbqnXXnV7E1oLfMP/U7+2Ybc4mP/S4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLFu0EDUxjzZfN+urEBMuhNtbYC4ICPtoxcxo4OQQ10=; b=OtvRd/5SuvFBRme3pAG4jc3G3n1uNc6TIAHO6tUPH0z/dXMfywES2Tb3Fa2n9pdB7jZ7IqyO8vq+p8q43HuUPjiENyhEh+r7aMaFCMzaCNx/WEyR8uEyNHv8aLlHAF8ssLm4ov3HPvyRk7TN+SjHx30EUKAGtIuFGYLo3FnS60cLCbbwnrMlZJfhrVs9/pQ2h+XAZ/N64DWrmREn9hg3CD2ycUvKSMtytdTYY2k789t65LsK1zU5E4BiduxD37tE+OG7lfO8009nddIgpF3SLbRziXcu7t0ZWudUPlVfgKW/my5S6E+dpAtAErBniidO0Ye3g5AZR7oxLTbmqEUpvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7775.eurprd04.prod.outlook.com (2603:10a6:102:c3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Tue, 23 Aug 2022 14:24:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5546.024; Tue, 23 Aug 2022 14:24:01 +0000 Message-ID: <58cd3a02-08bf-972d-c4e0-f39622d849c0@suse.com> Date: Tue, 23 Aug 2022 16:23:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2] ld: Make library member file suffix comparisons case insensitive when cross compiling too Content-Language: en-US To: Nick Clifton , =?UTF-8?Q?Martin_Storsj=c3=b6?= References: <20220823130606.1659316-1-martin@martin.st> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0399.eurprd06.prod.outlook.com (2603:10a6:20b:461::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b31fbfd1-9e9b-4e07-3e05-08da8513200a X-MS-TrafficTypeDiagnostic: PA4PR04MB7775:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kwj+QqI1ZA+b8KBus+kWIRoMY+gwgNlDM2hCjDpuEtChQKiQ8wX3X77dYZaX8Vg5ezFH7ogRCIBDUtLvTpTtuacjmtlmG0leEdiQGqmcPvJ6TLcdyZoP+M5BRkTZGSKlDDBQc6yk5bOEmwKgwvHregg0FeSrWK/Z/Z/mwnVOqNEMiF9Tzb2Ub+NQke1VaMQZm732lEXVvXdXRJUdzSjzqisNp8Au5y1CTBnSn2OTop91BiUVSzapEUSTCmm0wvukgLjlkNNVM17nhATDKvEa3eIEY0y3wweJoYU9Kuj+EbaVXNVbQwjdJcL84xdZ2vd9yBc3rKMOZrMvVzNSoQrW06HohjIA+4N+XwhTQKWB45j6Mh3I5DiQwDxX2nZaYWFJgHuykjFT38vl6uAYzAm6FntGCEyzuydFY4wJoDDW+pGGjmPTVK5nBg37KUjE1KRw9WAT1I7yE6gcLwjizgIEmYYO+aF1QVW6XCGEXxNpvt9l03ByeIKcOZ/Ospw8Fkd9lvk2jmN5c5YiJUAvXc4Ni/zisWn2o6jXUJ42pmwMS6YkjRmtBAmwQz1IKd3ksn6upesjNys59ZMWzIM5leY+f/EyGO/W5yVQjHHJ/IqEmCkY78Jpk+lwLbmlss6C7mhJsuGppphjTiB4Vrsq+OappT18/mYGpj5cpLVTLPWFvGvrflUmXMBbDioSn6m1T7AnHMdFrGbLl0C3zNqdTHwlgYQK4OiPDr/0kWemksPWqLpqHDqSFETjw1ig3iNBYmPlC/k38ad4bZtQsZvQfR051V1Y2Ucxvcb3v8snYCZkQHM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(136003)(376002)(366004)(396003)(6486002)(4744005)(8936002)(478600001)(316002)(66476007)(66556008)(53546011)(186003)(31696002)(36756003)(2616005)(2906002)(41300700001)(6506007)(26005)(6512007)(86362001)(31686004)(66946007)(83380400001)(38100700002)(4326008)(8676002)(110136005)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnQwM0lxQmlXKytkdzRabVl0NWtkeWlYdFp4d2RQZDJLQUg1T2pvZlNFUHVQ?= =?utf-8?B?M1NHdjZYM3NnWHVWWWZkd0xQSXhlanZoaFNZMlRteEdIcDV2QU0zRWJvZ1VS?= =?utf-8?B?STJDbzhURHY5K3JmTlNkRVVPckhNNG43Uko3T3pGU2hnWGJ6SGJCc3VVazFK?= =?utf-8?B?QmhhY25qWlhPQ2t3N2ZjejZxN3RvQjZyVHU2WjZCTndyaUJiVFJSK3pYY055?= =?utf-8?B?dkh3YXVXRVUwcnNRTWFrZjl0NHhnMVZzY0JqRy9OQXdibE5BeHZ6MjFaSzB6?= =?utf-8?B?ai8yS293WG9UbE5HTU0yLzNrVkdsaTdURWRiMXNMWUd1ek1HbEJzWDZFbm4w?= =?utf-8?B?aGw2aUVMcC8yblREdytFa3NRN1o1TUNJTkxGM2tzZWVZUndvNHFPbHFaczZH?= =?utf-8?B?N2N2MjlCZXZmVGI4bEpBWkZIVmhzaHAyb1Jmblh2OGExODY3ZlJ5VFJBMUx0?= =?utf-8?B?aDZrLzR0TCswY1RhMlRUNS9LalZ4QTY5SnA1NGU1Tk5oWG1mRWlaekRYN0FS?= =?utf-8?B?L3luai9PUWErT2VWQkZSS25XWHJMWVBGVmxiQmxIanV5ZjdMZUdyeldZSHFU?= =?utf-8?B?dFZBTFN5WlRpWWJ5MGxnbmE0REZ3VzJlaEhyeG9ackVrZ0JkUFVsUVMzSkhr?= =?utf-8?B?ajdEY1I1M3BFcGRTYUpEU2h3TUlLZ2U5OTVoNjZwMjZZeExGMmZKVzNrWWow?= =?utf-8?B?SzhtWHk2Rmh2cFZmWm9RU2Y2K2orM2tQOEdGMEs0RUNWWVRlQjcvSW9xdkRI?= =?utf-8?B?OFZVNmh6c1FHYzNjN1NBTGVFNTh0SThYQ2JPL1Y4ckVwRlRXL3JsZUNkRVho?= =?utf-8?B?VzFpcXBCKzFyMHIzUXFLMENCQVlQZ3NSd2V0amlQbGRrczJSd2F0bnFDWlFG?= =?utf-8?B?dmVZRlprZG5tUUZZZmduT3hwa2M0QXNNOHVSdzlrajA2dTd0aEF5LzdVeEJ1?= =?utf-8?B?K3haTEVnUmNoUWx4QldDdlM2bStjTGwzL1dtQ0NNRUJ6Q2NwelBqMkUrY2c1?= =?utf-8?B?K0NaTkZyQTdwcldRc00rbHlZRUpXUDI1U0xHeDB1bjU1ZkdyOGE0UUVud3l5?= =?utf-8?B?dzVjSFdCOTJmeXd4MzRXd01MSjM2ekhpUGhRb3MyMGZHZHVqUFoxV2tCdTFx?= =?utf-8?B?OFRxTTRReWZwcnpObW5uZmxYKys0bUtDNUthb00zb0tVRWNzeU8vVXRESWNL?= =?utf-8?B?UnpVWWtSTDVoNVEwRTl6WWhPZG9XaTU3RGR5V1I1L2c1OEVsOE5NVzl4dU1J?= =?utf-8?B?aTcxaVVqS2g1YW1PYUsrQzFrby9ZMlRQSVh6clZSbmhOOVRTbFFoNzRSZXBE?= =?utf-8?B?d0JLUDRVVGlsZXNGclI5dmtvd2JrNmNuODAwUXJYckFpSFdDazQzWTg4bGgr?= =?utf-8?B?bTJsZkN5d3Y4UUJJYU9DcW41bG5iT0UzeldhRDQwWHNwUG1LZnJ0SnA3VW9m?= =?utf-8?B?RFpmNnJBTmI5MXk2eXNUK014cEFkbDdid0hqZ3dpUlR3b2VoSVRPczRLeUNN?= =?utf-8?B?dm13T3BNTEVKb3hLTmdpKzFib1R6blp5bm1nRTQyemZzSS8vT1F2Y010YW9D?= =?utf-8?B?cmMvUjJsdjIwb1U1ZTZ4aVpKcGtWa3JLMUYyT1NZZms3UXFTOWNFeUlzT2Jp?= =?utf-8?B?dkFKRGgzeVkrcFFzNllNbXJKSGhDTGlWQnpOb1dPcWE3NmhZbnpZYnpCejZ4?= =?utf-8?B?M3I5aTF4NlI2eWVZb2xVR3YxR3BwQk9RbmhpR0lldmRoMDcvRXVMai9HVFVQ?= =?utf-8?B?dnVKSmgxeWZ1Q3R6eW1MK0Nva1BJb1dHZ2FZaXplTHZzMFBySUVGMzgxSGp3?= =?utf-8?B?TzJqdXlNd1VUdktxc24xMUc3L0FNWkFZdXoxMUM3bWFYOXcwT2ExU0tESVhn?= =?utf-8?B?RFRXSlNLbExUNTRCaEYwNlgxL3BVaVpjSzc2ZzE3V1lydXI3WXVzZWI3ZVZa?= =?utf-8?B?N21sbzZKa1ZqZ0p4V0t1ZU9uUXFSSkRkVUU0d1lVWVJGOGZqaWh3bHI2dWJx?= =?utf-8?B?azBGY3FmbmFMa21aZDlkTnd6SlBGc2l0dWRoeW8rRktBR2JpdC9pRENkNVN4?= =?utf-8?B?VHdkcWJsQUd1U0liQUYrSXVyU0c5NHpma2xROVNjckNSNlpDWXFZV2RCeGtC?= =?utf-8?Q?XupTjCple4Snj3X4nugNZO9Jk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b31fbfd1-9e9b-4e07-3e05-08da8513200a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 14:24:01.6323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VR4UJWJx+fg1ebPWaf7VoHrLpjOjTxpAXJ2hcUypsQ6jfnEvhSwZO5hAFWZ1/YlcfFu/SXmZmgZGMue7v3CZDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7775 X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 14:24:06 -0000 On 23.08.2022 16:01, Nick Clifton via Binutils wrote: >> +/* Hardcoded case insensitive comparison. filename_cmp is insensitive >> + * when running on Windows, but when cross compiling to Windows, we >> + * also want similar comparisons to be case insensitive. */ >> +static int stricmp (const char *s1, const char *s2) >> +{ >> + for (;;) >> + { >> + int c1 = TOLOWER (*s1++); >> + int c2 = TOLOWER (*s2++); >> + >> + if (c1 != c2) >> + return (c1 - c2); >> + >> + if (c1 == '\0') >> + return 0; >> + } >> +} > > The implementation of filename_cmp() in libiberty also treats forward > slashes and backward slashes as the same, on DOS based filesystems. > Shouldn't this be carried over to stricmp() as well ? Well, the function is used on filename extensions (.dll and alike) only, so that shouldn't be necessary. But I think the function would want to have a name expressing this very limited purpose, and the comment ahead of it would also want to call this out. Jan