From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 1F3E03888C47 for ; Fri, 18 Mar 2022 21:40:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F3E03888C47 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22IIW8gg032727 for ; Fri, 18 Mar 2022 21:40:12 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3evpuudb6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 18 Mar 2022 21:40:12 +0000 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22ILdAJY030813 for ; Fri, 18 Mar 2022 21:40:12 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 3evpuudb6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Mar 2022 21:40:12 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22ILdKeV020301; Fri, 18 Mar 2022 21:40:11 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma05wdc.us.ibm.com with ESMTP id 3erk5amw9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Mar 2022 21:40:11 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22ILeADh26083704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Mar 2022 21:40:10 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AD95124053; Fri, 18 Mar 2022 21:40:10 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A680112405A; Fri, 18 Mar 2022 21:40:09 +0000 (GMT) Received: from [9.77.152.28] (unknown [9.77.152.28]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 18 Mar 2022 21:40:09 +0000 (GMT) Message-ID: <59d3dea5-efc0-8b3a-b231-31173c741d65@linux.ibm.com> Date: Fri, 18 Mar 2022 16:40:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] PowerPC64 extended instructions in powerpc_macros Content-Language: en-US To: Alan Modra , binutils@sourceware.org References: <20220315234059.4142748-1-amodra@gmail.com> From: Peter Bergner In-Reply-To: <20220315234059.4142748-1-amodra@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 15d4832hiPWyTBv_BlJiv0oiFh7nnRM_ X-Proofpoint-ORIG-GUID: hw-aY1b8u213CZ9X7Clnn7vo8_xj9iGy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-18_14,2022-03-15_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 impostorscore=0 mlxlogscore=756 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203180115 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 21:40:14 -0000 On 3/15/22 6:40 PM, Alan Modra via Binutils wrote: > The extended instructions implemented in powerpc_macros aren't used by > the disassembler. That means instructions like "sldi r3,r3,2" appear > in disassembly as "rldicr r3,r3,2,61", which is annoying since many > other extended instructions are shown. > > Note that some of the instructions moved out of the macro table to the > opcode table won't appear in disassembly, because they are aliases > rather than a subset of the underlying raw instruction. If enabled, > rotrdi, extrdi, extldi, clrlsldi, and insrdi would replace all > occurrences of rotldi, rldicl, rldicr, rldic and rldimi. (Or many > occurrences in the case of clrlsldi if n <= b was added to the extract > functions.) Very nice! I hated the macros table, especially because we never did get the rldicl extended mnemonics in our disassembly. Thanks!!! Peter