From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH] x86/Intel: reduce ELF/PE conditional scope in x86_cons()
Date: Wed, 26 Apr 2023 15:15:38 +0200 [thread overview]
Message-ID: <5aebce50-8b8a-26ee-b452-d9164668c145@suse.com> (raw)
All the Intel syntax related state adjustments apply independent of
target or object format.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -10506,12 +10506,12 @@ x86_cons (expressionS *exp, int size)
{
bfd_reloc_code_real_type got_reloc = NO_RELOC;
+ intel_syntax = -intel_syntax;
+ exp->X_md = 0;
+
#if ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)) \
&& !defined (LEX_AT)) \
|| defined (TE_PE)
- intel_syntax = -intel_syntax;
-
- exp->X_md = 0;
if (size == 4 || (object_64bit && size == 8))
{
/* Handle @GOTOFF and the like in an expression. */
@@ -10558,15 +10558,13 @@ x86_cons (expressionS *exp, int size)
}
}
else
+#endif
expression (exp);
intel_syntax = -intel_syntax;
if (intel_syntax)
i386_intel_simplify (exp);
-#else
- expression (exp);
-#endif
/* If not 64bit, massage value, to account for wraparound when !BFD64. */
if (size == 4 && exp->X_op == O_constant && !object_64bit)
reply other threads:[~2023-04-26 13:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aebce50-8b8a-26ee-b452-d9164668c145@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).