From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 0FEE53858C5E for ; Thu, 23 Feb 2023 15:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FEE53858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A7995C5DD; Thu, 23 Feb 2023 15:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677166109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YHODLdpGptf9afmSKxF6bFJMY2ieqdbCLjHhUQtM5uE=; b=CIHxy5lGLDXm588L/09jAU40ohtz2ES4vZ/9TPYJDl9ILsueN4rhpJ/JjyZld183FxEqi4 0PzJDEzTtoM0PR3e55rb3r9s6buCb/lqFmpBJ/3rxwECFVpY3VPFDvZMUwm/UfhA3Gpcli UF8clhMMa3jXJ+JWs8zZM4G86lQ91QE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677166109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YHODLdpGptf9afmSKxF6bFJMY2ieqdbCLjHhUQtM5uE=; b=/d2AJ710aRf02LEtBBfULvjzGFRosHarTT/pJjLgQ/XwYpOAB3VK9gV0e9qtbPqpd0VAcl IlzRwZRyc1wgL6Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 002CF139B5; Thu, 23 Feb 2023 15:28:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O3N8OhyG92N9PgAAMHmgww (envelope-from ); Thu, 23 Feb 2023 15:28:28 +0000 Message-ID: <5b23b6c1-e447-d3bc-8534-8f12e80394e2@suse.de> Date: Thu, 23 Feb 2023 16:28:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] gas: Add --force-compress-debug-sections Content-Language: en-US To: Michael Matz Cc: Jan Beulich , binutils@sourceware.org References: <20230223124519.4228-1-tdevries@suse.de> <7dcb7bfb-f65d-aed8-78d4-944211ef5127@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/23/23 16:23, Michael Matz wrote: > Hello, > > On Thu, 23 Feb 2023, Tom de Vries via Binutils wrote: > >> Or instead combined: --compress-debug-sections=force,zstd. Harder to parse >> though, I suppose. >> >> I guess this last one would be my preference, because it makes it clear force >> is in a different category than zlib/zstd. > > Regardless of the outcome how to spell this on the cmdline, can the > force-mode please be explicitely documented as doing stuff "even if it > increases section size", at least in the .info docu (not necessarily in > --help output). Because, knowing users trying random options, they might > be tempted to use the force-mode, because "it surely will be better" and > the remark would hopefully deflect this. > The submitted version ( https://sourceware.org/pipermail/binutils/2023-February/126284.html ) contains: ... @@ -718,7 +719,8 @@ Begin in alternate macro mode. Compress DWARF debug sections using zlib with SHF_COMPRESSED from the ELF ABI. The resulting object file may not be compatible with older linkers and object file utilities. Note if compression would make a -given section @emph{larger} then it is not compressed. +given section @emph{larger} then it is not compressed, unless +@option{--force-compress-debug-section} is used. @ifset ELF @cindex @samp{--compress-debug-sections=} option @@ -738,7 +740,11 @@ using the obsoleted zlib-gnu format. The debug sections are renamed to begin with @samp{.zdebug}. @option{--compress-debug-sections=zstd} compresses DWARF debug sections using zstd. Note - if compression would actually make a section -@emph{larger}, then it is not compressed nor renamed. +@emph{larger}, then it is not compressed nor renamed, unless +@option{--force-compress-debug-section} is used. + +@item --force-compress-debug-sections +Compress DWARF debug sections, even if this does not reduce size. @end ifset ... So, do you consider this insufficient? Thanks, - Tom