From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by sourceware.org (Postfix) with ESMTPS id 1D5CC38582B6 for ; Tue, 18 Oct 2022 09:23:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D5CC38582B6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cY1VhymHwpCz77XM8ud1G5jufW4PqFXjsqBtRBlxJniTK+8HFk+QQIrSLIreeQKh1GsDsLWmiVBuPl+MxX6aobM9ksw06tVKwtkuIO1Lv93BW3+uiFxfgybV5h4uIp1ac45+RX1nbx0IG7D1fYOnIWmepGK4XpOLrGj/oudqatH/q7xQrg2lZhxBT2dKs8MVLHxhz9G1tvyQORFOLTOqHC2ITx62wjKceQshgaCj5ffnSpDhhgmwCEfmP3SAenhzR/Y83IoMLRLzifTA01ORaSZCTZ+eHYYWPw9rE5SpsTIs+/vBk4ZCKsbT/D2S8I+EFwOfXbBTBPiPlt7pfR4Phw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=poBEq34WuVXl8b0ByO2CD/VVCxUpYKgP4xmbJXy+dfE=; b=DrXoEDStlJocQ3JG9I2HtI3FaBxOGaGbcXdgBQHSttoa43D+5782//KJHDGG4/GlUn+h3XWVFGfPOMJYksCP8f2pz5g1Zd5fUIHYavUuTxEw0P2wG9nUman++QBjj4/YcZv8JSufNDf/Jm7El3OQY0ILfZrf3kZ6Iuge59niBMjjMYFY1IONJuvagLPqfchprQmYB+na1bEuSTqfuB7XsSbgsCzVAs0t1+O+pNKnj6F9EPwtmSiFq9VTkNsX9ElMsBC9trJ035rci3Xseq0naXdN4afC5+qmpNklDSxd95CqhFr3kh8mc5/zUTCtRME6p+mOYWWfhbyES6CUWkqUtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=poBEq34WuVXl8b0ByO2CD/VVCxUpYKgP4xmbJXy+dfE=; b=Vgfu5I+SG7qqPJb1EH0uadSQaUbwGgTTYEWxmHOJdeyIZWShtyCqG9Ph6FFPxEOxoCrBdbmVUmjMsAv1NNfiENX5YdNCgJ9fP15OFzn37e1yly2gxKA1YMgak45f5o4br+k8RF4yfB6xoHeiYsHfZlmUPz4X1nOWaufuQZrluBQBnEhZJuJNE70t2t+QGhJYaTxXhsNsnqzMk3EcHCgzAAqM7AsRFtKWMT4SLrKlmIdP73NWiAzAC/as0Vez1UlznKZMagWM+uaqum768W4RxbJvww+QlaKyNhP8HnDZthGPuU4omwtqIRlolzGK9GsnVdxouKAacfYKHdDvopfJiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7350.eurprd04.prod.outlook.com (2603:10a6:10:1a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct 2022 09:23:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 09:23:34 +0000 Message-ID: <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> Date: Tue, 18 Oct 2022 11:23:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7350:EE_ X-MS-Office365-Filtering-Correlation-Id: ae21af5e-ef7f-4709-0c99-08dab0ea6df2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 99ua1gnSatscUn/CwY344hwQDQnHKbnVAhqp/ThLPhPjiQTsJyRqS0zu/L9w+RhLqbxLAU4y3ZYlfujoWe5dvENW1RF5tWfGmecjYcVTOhreqkQNuJsH4lJEd9fMybffKAbMqKaXS6IGIi3KRPYmYdS3BoT3tIWnBXIKJ+aYLo9X4kglrRMOyPHEciBJuctzrcUlrdfqWCwQ85uLiGOZrkE0/b6WfUL39VVsmSgLe9ccdNtAmcfNWPZb9heSfZh635S+qs5UOxUgltDdfxy3QEi0JicX3sYfpb4sjQO2ZAMn7ztaQX9/ny5LSQnzQ8GZBVeRHi/7hJ0RJzNRPnekbQDbLkgdP9Bv9jQ4lu68dZSjWwVG+64rEjMjNohn6cjlxrBlfajDxKJixxyAx2WHbAxaG//tNdF5uEzBUFUjwosD4FEL56P+W5Vz+jY3fBh7gMkIB8VD3oPUkXrqtHLitHr1g4wJ0laRkQGTOvuT/50fuw5Y5o8kJuJ/iiYzufGl6qk/V0MuMSNSAlenA2iEVQwmGYWFmhktaV6cSM3avmSZSXbPSplOXcD3bKIi18ILKmaaYvAHi8JMZ+euLNQEUgkTci/WKETQjVn/DDT7cjH9j7RCYqc7HZ7jZ7BsI6JwVGUa2O17y/P4WM8fye9FEUZCWNGNQdkc5Ipm96DftsS5p2fqGNmt0rFcn71/M6BOjlvYPZwP5J+4ipybDRzPdPChd2XfNsLL0QMySCZk+M4wt8c9SAyDHpnRGGpWCwF08wxg3/yZ+QncFnT/EOGCNzpQ8uKi/TMC/C+qclNkFZs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(376002)(39860400002)(346002)(451199015)(2906002)(31686004)(5660300002)(66556008)(4326008)(6916009)(54906003)(8676002)(316002)(36756003)(478600001)(66946007)(6506007)(8936002)(41300700001)(6486002)(6512007)(53546011)(26005)(66476007)(38100700002)(2616005)(31696002)(186003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXY1T2RrV3FwUGpUVitSbkt5aTFrdkJRaXJpQSswQitvUmFOWFB1OUtaL3B2?= =?utf-8?B?SzY1NFNIRzFXT3V4U2lhRFoweWdsTnFMTDdTaGpqaTluM1NZeWVVcXhMejg3?= =?utf-8?B?R25YdFpoU2NodzU1dEZiYTZsMDhkRTlWVjcvTlliTFc1dFBJNWFlTDVOa25L?= =?utf-8?B?aFN4b2cvWmRhVndmT2ptQ296bUNUNmRDUjE4azJRQkp6SDhOQ2NtVHJKMThK?= =?utf-8?B?RTJBbGRXOGRaVXBSbng0L00ra2hlOCtQQnM2ZGY1ZWR3S1lBd21zUkdxdlRt?= =?utf-8?B?c215SXJ2ZW44ZXVGNC9BYWtsN2Z6WStPMUE3QWovV1hjUVQxZFZvRzBPSTJ5?= =?utf-8?B?Q3lzYjgzeUgvUDVQWXdpNTMxN2pXWkFTYjRWT2lVcHdtc3Y5T3hFYlFIYlJV?= =?utf-8?B?UldlZGpReDFib2pqNnI5RW90MHhXeklyNVFpbHdDNkw1My9YNncwR3Zyam1W?= =?utf-8?B?ekRjd0g5Y055dWJ0azhhTWlXdGlRM1hTZzZObkc4Y2NhRnJKZWNtZ2JhRmVw?= =?utf-8?B?V1BSK3lGNDBENHdWM0V3SHlETVlXN0JNRFYzRXhnQmNtUHBYY044c3lsa0xB?= =?utf-8?B?WE9YbjRabnU2YXhabGMwNGkyTklvbGdXV1pScGlPZHNmd0F2NjRpRG8xWGh1?= =?utf-8?B?dUNucnFHN1h3d2c5cHJqRmgzNTE4UXRqdU94UGVidXpQUWEvbzg3amJIcXBy?= =?utf-8?B?bFB3c01Gd0ZBOHNnRmppdFBBMklmT0s1ZG84YmZIRDE1OWs3TERQZjB1VXVW?= =?utf-8?B?bjY1cGhTQ2E1WVpuTHJVMXJEUUx6bXd2UytCR1c2bUdlcGYwa3p2ejFncHo3?= =?utf-8?B?M3U3T0wyL0JsSFV1RGk5cDJBY2UxMFJuWUFhdE5BODBhNEZ6Y1N5MUVUSUtE?= =?utf-8?B?akZxNjJaQVdHblZhYW5vNUZpUUdhb1lZYUY5ZmhUdkZZRlpPT0tEOTdTN0dp?= =?utf-8?B?cjExU2NRcFkrMTVOOEQxVHFHRkVqMWc2MkxRcVhhS1lyTVlYVjhxNlJRem9U?= =?utf-8?B?SEg3TGFMQXVmL2lkbWxGQWVlTzBiUnhEeWZrdlRUa2lFcXpBcmtKTHA2T0Fi?= =?utf-8?B?R2xLOFdYckRvenhLMVRrQU1QZ21tajdZMmRRakJzMWpDMUQzVlVKRUd0eW1n?= =?utf-8?B?UEFrckJodjk1K2RIOXl2NzhtR3JrbmhpcWFtYWdsc3J3dCtVWWw2ZkRxMHpS?= =?utf-8?B?Q2E3RjBLQUh2M1Myd1VCcXNMWTBydHQ4QjFDZjVPV0pRZEo5bG14WEFCT2JJ?= =?utf-8?B?YVJUQ0djMVRleTRLMmZ1NmRlaW5RQlo1WEE4Y3JhZUtQcndzdGhMRGZzYmVO?= =?utf-8?B?ZVZRMlJwdWtQUndqMm4yTzdJZlpFNjY2bllHanFpQ1FQNU41Ri80S2xtQlJL?= =?utf-8?B?dDYxRGpNRTkxVkNyWU80UklVMFlQdlA4cUdVMEIzdS9UaWpHVTE1M2N3RFRU?= =?utf-8?B?YlhrOFJsNlhXWng4aWRnTlJIdlgwUGJhSUFpaHUyUy9JSllJUGdiVW9RK0NF?= =?utf-8?B?Y2JESFltNGtZb3JPVGFXR1Axd0tTd3pwSzRIMXJnVXpxcHM1eUxPMTFSc1Jp?= =?utf-8?B?elVoUWZTUHp3NTdlVzR2M0kyN21pY21SRzNzQnZIaFlwS3R4ekhSMElTNlRD?= =?utf-8?B?eTZyWlcycC9wRlB5Q1pIeXg1eDhLRHpLZ1liUjVoZXhTb2FhYkw4TUUzYXJ3?= =?utf-8?B?SS9PTWdyZkJaTmphd1BnUlJXMk00WjBXUU5qdDU3TlJGY0JWdkZ0M2JsK21C?= =?utf-8?B?NENjVjJ6cW41Z2Fnd3g0d2dHd0llYjNyeWpqaHhzTVFxck5qcXdMMTMwajh1?= =?utf-8?B?NUZTT2p2b0E4QTV2MTN2TjZMejM5S1lUSHFqS29YbWhnL3Iwd1V2N0k1T3Rr?= =?utf-8?B?N1lpaFJ0NkxiVzh1eEVjS2NMaEZFaTQ4Z0p4M2JyeVZWMENnQ3BYczBWQzFw?= =?utf-8?B?dklWNWsxRXJMeXlCbXh1TjN1K09TcVdkaGxRQklkcjBMWWgwZS9YdTFhTGlW?= =?utf-8?B?c0hmTWsxN05Lam5kTlNNUUo3aU5qOTdjcDhUMjRnK2ZwWkY3aDI5WENGVUxt?= =?utf-8?B?bzloNFhVTm9sdUEwNGc3OFkzZ3NQTVE4QStUS25ZemlOU09IdnBONXRYdjNC?= =?utf-8?Q?mPWnyWk+aMKq1Y2kNAatOzakg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae21af5e-ef7f-4709-0c99-08dab0ea6df2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 09:23:34.2105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WWOG56vY30CwtJcj5gM8AMflB5QIByxn+Xs4DhM7oevNKqHbAMdoLTw7NK92v3FwUo/0qfTzu7zYNYF3i1mtCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7350 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2022 11:01, Cui, Lili wrote: >>> + { "CPU_AMX_FP16_FLAGS", >>> + "CpuAMX_FP16" }, >>> { "CPU_IAMCU_FLAGS", >>> "Cpu186|Cpu286|Cpu386|Cpu486|Cpu586|CpuIAMCU" }, >>> { "CPU_ADX_FLAGS", >> >> Can you please insert next to the other similar AMX entries? Seeing the flaw >> here, I'll be making a patch to address the lack of CPU_AMX_TILE_FLAGS in >> the similar pre-existing entries. When you move the insertion, it'll be easier >> to keep things in sync. > Done. > >>> - "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16" }, >>> + "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16|CpuAMX_FP16" }, >>> { "CPU_ANY_MSRLIST_FLAGS", >>> "CpuMSRLIST" }, >>> + { "CPU_ANY_AMX_FP16_FLAGS", >>> + "CpuAMX_FP16" }, >>> }; >> >> Same here then. > Done. I guess my comment here was a little misleading (I'm sorry for that), in that in addition I was expecting you to consider the comment regarding the need for the *_ANY_* constants that I did give for several of the patches in this series. I think the question applies here as well: Are there dependent features known to appear? If not, there's no need for the extra constant. > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -1101,6 +1101,7 @@ static const arch_entry cpu_arch[] = > SUBARCH (raoint, RAOINT, ANY_RAOINT, false), > SUBARCH (wrmsrns, WRMSRNS, ANY_WRMSRNS, false), > SUBARCH (msrlist, MSRLIST, ANY_MSRLIST, false), > + SUBARCH (amx_fp16, AMX_FP16, ANY_AMX_FP16, false), > }; This might also benefit from moving up, but I'm not going to insist. > --- a/gas/doc/c-i386.texi > +++ b/gas/doc/c-i386.texi > @@ -220,6 +220,7 @@ accept various extension mnemonics. For example, > @code{raoint}, > @code{wrmsrns}, > @code{msrlist}, > +@code{amx_fp16}, > @code{noavx512f}, > @code{noavx512cd}, > @code{noavx512er}, > @@ -247,6 +248,7 @@ accept various extension mnemonics. For example, > @code{noraoint}, > @code{nowrmsrns}, > @code{nomsrlist}, > +@code{noamx_fp16}, > @code{noenqcmd}, > @code{noserialize}, > @code{notsxldtrk}, There are no @code{no...} entries here anymore, as of earlier today. Hence no new ones should appear (and you need to re-base in any event). Jan