From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by sourceware.org (Postfix) with ESMTPS id 78F553858C2B for ; Tue, 24 Oct 2023 12:02:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78F553858C2B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 78F553858C2B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.59 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698148944; cv=pass; b=YIt0E0EBPNS4Ag8M5H8ooaPq8IKwEGVVf1FSBPkW6uz4XfMF9E2JBp++zIdjqsKB0POFUEmTDF0tpWjHWU3L/DTb0tV5wVUyFhpvghpbANhaxvtSv56rZZfYK0xSjknUwzpu/btrWHE7MRP3o8cg//wBqP47cT8LSG5kKnLoJbo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698148944; c=relaxed/simple; bh=JlATBKjJZdx47kEG2SbQVmTf47AKtR8xhftg7Wy952Q=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=em6L8w2pbasf72KWciUIIYAS212FLCzXg6eJsoGnohFRM8l42muZMkq9zXoyEyCfvd1xMptyy3AopNteQ9r4R4IdaJ8/JwE1ap1hzkY8nfEjgT4STI5kayz+g7RFO9Gfd3YwmzG0cmVe2gyrJ5bBdeVjhzMSFdEbQ5oJYA6TlvA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0SosvqXwybm/Rr1ys72ZyHPKG6I3hy0dCZ9dJH9O6QbgsHGqzxmbi9NS9Db4omDNnTxM2pOsR3chvWhW+UJXU7nYdb7dvSQ60uboSv04lkH3xX998IYD4ktbnQ0gOnDJ8eEjXEZe8IZx7iX68+FUeic1+DhiEp9dYl0NLlmlaeSVDk0dJhmX4q3C41WO7SBjrhDC5erGZ4gqKYBeDYJlcbosJ4WqVQ/HFdSMSEEutrSi1VjUT/ggMAOxPqk4nAQNt4AWKk8t3lZLhHTVKnr9xwmQyFfWgvOOwbA345mKicBTkPVMPIIbsgy/5bdtxFDSlGcsOIq9RTRVvVeDpDRVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRAuddBnc3aP0pDxcpKtj8ug3lluUHR6WQsoXc+sGkM=; b=K7WvaSGDktSwzYUbvuLbK7xTiU19dLnUC2T26+ktrI02iLVjloEtI+UG73yAgXMnCakkIu23HA7cN2Sv/BzxW3S85l4s2qRjw19p0zhjpOoxg3H1cX2sVIq7ID5jriyKoPCQ1nAO+3+diXZGOH3duFeBqPK5oyEEFCpB8R8R9lWreB7FkvSrpjYsjrTHAKlVgisyvIcP/h9yG299csE+cjH1xhfrFtOQ49KasokyrvrZFj0B6lGzeIGd9rDT2snpNnmhx89do8yAf/CvRWNCxhR+Zcse/vyVYNcmARSmBGfOBb38lh45Q19Cj9ttsO5rJP7znYO/ef4EdBGCl955Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vRAuddBnc3aP0pDxcpKtj8ug3lluUHR6WQsoXc+sGkM=; b=h6UDW6CXkjLQoqgq5x3jEQe6IZjlhM5vAEIdxxnnNyb7OeAjB5juyHdPndrmFSb+ECCDZs1QzhOEJINWgbB/CgdQdgaD8MijvApc2gxd6ByvqKuZuCI3r+BLrNbL99kbqpXuNAIfSUq1BPLba6Rd7HQvAUDoCIMiBT7cYn4Dd1Yei7urCWWQFfWO86Xjq95iNO1Up11bjAtF63HCvv8bpqgKenA3gz3mITDs+J7/fUfq/XOzpq770AiLHbSS5NZyOoE3cxyWwNUGdpNO1Y/piB4NbtSXNv+UqR2ALHtgqY1SyZVN7Ba8uluBj+ZmSgTdedt+gJ7xggtP4c4zFLQD9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8702.eurprd04.prod.outlook.com (2603:10a6:102:21d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.14; Tue, 24 Oct 2023 12:02:17 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6933.011; Tue, 24 Oct 2023 12:02:17 +0000 Message-ID: <5c3a3d73-0f73-1941-ab31-6ad95050210e@suse.com> Date: Tue, 24 Oct 2023 14:02:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] Support Intel USER_MSR Content-Language: en-US To: "Hu, Lin1" Cc: "binutils@sourceware.org" , "Lu, Hongjiu" References: <20231010072401.1383177-1-lin1.hu@intel.com> <3504781c-a806-335f-a9df-615ed3565e5e@suse.com> <1760f135-7d53-7922-17b9-8e44c1296247@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0323.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:eb::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8702:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fd1616c-17ef-4e43-c590-08dbd48911c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h9nBfh5kQeQVVli3eiL8SV1PsJgq3eNfv71PifB0DZrCDJY7DgO/KOT2EsfcQ47h2/61ICvRgo3xYRI5Sy12VdrEoXeU0lumOujSnM7cSfMuBRTxBk/HSdVbOonL78GKXSyMDYMx7Fyh9t+kYXlJnHu3rtwCsTU1D7Z/bTKHPRrDfATP+e7ZSEjBMgBRVrXLidBwp+EOjXOGkHmjYFB7pthufxNIcehqNJDxGYdpI3akinN0cnwnEH4eD+vcJADO4UzTf5w4VxCOoB3ckK0rn3h0Id7BHRypfVIR+nIcj3OSftE9UR7Z7r7dh0w9eZHUcp2dQX4N3I/Ri8uX8QbJFttFvJ6BpkVUlgG2rsPW060N+H4PJ0xYU/eiMW+uWqZBjGU4dx6xh8uZEkE98U4ztuGJU1K6av4PkxW857R8XtTh+50RryEw7E6bMWr0y035HYV1O8By538DLsJFG4ODKenHKHnYD1AczeK67Vl8dv2dw8mlKQOEaoO0OgwVEJceKWDdQ9WA6nY+VLRa1bXiZiAMmybQlu2EHghEdRvWbmyywZ69UQEqEiIrtx+F+6Q3Q1WB3PNnA2MF6fG7HqPHJT9dc0CpdtC2WSkVnPmcEj/QXqBUPgNmsea2VuY5sWrjwDAmAMTzEVmsn74aeXKVQw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(376002)(366004)(39860400002)(136003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(4326008)(8936002)(8676002)(41300700001)(2906002)(5660300002)(83380400001)(53546011)(6512007)(6506007)(86362001)(31686004)(36756003)(31696002)(38100700002)(2616005)(26005)(6486002)(478600001)(66556008)(316002)(54906003)(66946007)(6916009)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZMK0g0R05sdzNGbk1FWFFMcjlMUThUVkJ0cCtSZ1hYdEVacTEvSFByaXNi?= =?utf-8?B?aXBZRWNneEllZG93TU9sa3JYeWlDYU9iRmtrWENnT3VqM3BhUEh6aWZxL05C?= =?utf-8?B?OHFWeWczNUJqdzJCREFsVzJyVkVJMVVSUGVxNVk5dVdrbnU1Z0JJeFlzRWhI?= =?utf-8?B?T1pLMitDT0RQbzBRZWxIQnoxMGdDR21oSHptVnpnTHdwbHltdlJuYy9EUUcw?= =?utf-8?B?dU9KN3JYcWtqR2lCOURTMCt0RXhMS3JCd2drb1M4WW44N0VIcERVdDZLRzdi?= =?utf-8?B?aHBDdnFqUmZwZFFsOUtGbnNtMXJobHBuNTJacUxyemNHYWRDaVpWT1pDenR3?= =?utf-8?B?RWEzYWNmMjFZejUyU0JkNnY5QjR4MlJSTVhyNTJOcUsvMFVNYXp2bG5tMVZF?= =?utf-8?B?OHl4VEh6SGxIYjBNVVp3ZVlTM3lULzd2MkVhelZ5ak5FQUxiVEdZSzZHQ0lB?= =?utf-8?B?QjFvL1dLZ3hHRXdhdDFSYzZ5U2srbkxOUVVjeUtHRmZ4VUVXNE1YeGxlWEJQ?= =?utf-8?B?U2F4K1orQ2UrRXNTYWpCSHFBTzc0QWJZRllPcnhzZ3NSVEZQRWZpL1hOMWtD?= =?utf-8?B?VzY0akNSb2RPZllaekozdlBIa3pRc0VHTVFBU0FCajFQNGJaeUE2OXd3Ylcx?= =?utf-8?B?SHQ1Q05hMlB5L2RsNDhDVzBmNnlIbVF2QXhFZHliZXdlK3JnSGk5Y29GVWdr?= =?utf-8?B?aU9ZMGNJUlVJUXJlK0lYbFNVRzdQczJkQ3FMQkpGR3RvZzNuRlZ4akxGM1Ro?= =?utf-8?B?YW9QbTdLTkhZYUxOang0Mi80RmRNTk1TNE1obGxwNlh2UUppVHNqdUNKTk50?= =?utf-8?B?UUFPeGFVd05tOUMvNXVic2pZbkhBMkFocExOUUw5SVFiT01tdTBDU2ErNGM3?= =?utf-8?B?ZGYrRFFORnNDUCtaR1lnaWNBUkRHWDZqbEZIQ1FtZFVsM2d2LzBFZFhRZHNj?= =?utf-8?B?cXVjSG1VR3RmMTZremZCV1JwTTBoaGxSVjJ2MmJiNVNITCttWGU3a2RkSmtJ?= =?utf-8?B?eEF4bnp5ZE5aQ3BYQkFhOXFQbExGaVlHUzNBSGV5aXlJRi8ySU92cFVqZW4y?= =?utf-8?B?UkZ3YUdwd3FreWlUdFJEVWFMM2RvQmdGMHdiampmQ0VIZGhNZW4veVJzYmdh?= =?utf-8?B?QTdlNElIcEk0WnZrMTQ5N1dTUCtuVjNrWDJtbjByZldRdGdVR2ZQRmF0a3lm?= =?utf-8?B?dHVlV3FYQlJPVmVBUzV5U2xreVFSVDVsM1lKS01TZkpvWm95OEdISitMaERR?= =?utf-8?B?NVdYdGk2eGNBTHZlT1dGK1ZmVEQvc2MwZmlhT0hxMlpPbitSN2Zqa0dDQ3Fy?= =?utf-8?B?cW5rU2xLQzQzcUVvR2phaVpTV2RCckNNZ0NCNDZITkRBZzlDS0kra3NYY1hO?= =?utf-8?B?MXZ6OFFUM1FDbjdsNHlSUlc5NHdzR0VWQkRTUlg4dVpyYlhqei9nSUZwejhO?= =?utf-8?B?bGZXaVJXbGsvK09jUExVNTVVdDJIWXNxaUJKNE5TcWVTbS9mNXVFc05yZTZj?= =?utf-8?B?QWw3aERsc3Era2VoM0JSQ1NVWVh1ZWdsalF1clAzenhXcURSTms5WjMrYk10?= =?utf-8?B?c0NnSk5CM2taYTZoQk5xMUZGeUJBVnF1MDh1dm41ODFiVm9xNHY1TDFWVXR4?= =?utf-8?B?eTB5dUFYM1FWY3lHRk5yN2grWm1wZFA0aE03UlJKNjI2RDZURWRPaHllUHBa?= =?utf-8?B?enFaRzZsTVVBTFhhcW5tNEFSS3BPTnhIc0Q2UGhvbmZ3YlVEbTFZUXliZ2p0?= =?utf-8?B?QURORDNyK2JSL1dsRkJTTDROZUhEWHBIcysvNzlXbXJlSmxFbllWN09vYTdU?= =?utf-8?B?VUxWcWEwRERHRDJxY3RtR01INi9SckVtQVpvQmk2alJMWjNySnh1czhORHhQ?= =?utf-8?B?VUxNTlRWM3hPM0pnS3hyZ2IvR21GWFF3UTVXb0JscXA5YWg3SDBjNFIzOXAx?= =?utf-8?B?N2xuR3NPR2pwVWl5bkhtVGtPSHFoamQvQ1FMM1FNbGRzb2lBRlpVTHZIMWF3?= =?utf-8?B?K0NIVVBFUVR2SEJjZ1pzT3d2em5mczYyQmc4VS9KM1daMVpLWmEyQURPYTA3?= =?utf-8?B?eGNWbUl0ZnNZbnBGSytUN3ArTEQrcllaalRGbnlEcllCd3FaMVZXOEEvY2RE?= =?utf-8?Q?eZN/20ZH87GHQK5uqz9enqTJ6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd1616c-17ef-4e43-c590-08dbd48911c3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 12:02:17.8069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /SMJletPiPMlvJCuY293/gTfXbC6GUUou7iJPPgFJ5g65LkFS88ouq9tBltVhi8TX7E2KSp1kk/pwIRQyJo1aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8702 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.10.2023 12:01, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, October 24, 2023 4:56 PM >> >> On 24.10.2023 10:38, Hu, Lin1 wrote: >>> I've thought of it so far is I can use a Fixup function like >>> >>> static bool >>> uwrmsr_Fixup (instr_info *ins, int bytemode, int sizeflag) { >>> if (bytemode == d_mode) >>> { >>> if (OP_Skip_MODRM (ins, 0, sizeflag)) >>> { >>> if (OP_I (ins, bytemode, sizeflag)) >>> { >>> ins->codep--; >>> } >>> return true; >>> } >>> } >>> return false; >>> } >>> >>> Then the uwrmsr's unit will be { "uwrmsr", { { uwrmsr_Fixup, d_mode }, >> Rq }, 0 }. >>> What‘s your opinion? >> >> Hmm, not very nice, but I can't exclude it simply won't get any better. >> My desire was for there to not be any new fixup function, and for >> OP_Skip_MODRM to be used directly in the table entry. (In any event, if you >> really need to keep this new function, please combine the three if()-s into a >> single one, helping readability quite a bit. >> > > I have another idea, can I have a new function like > > OP_back_codep(...) > { > Ins->codep--; > Return true; > } > > So the uwrmsr's unit will be { "uwrmsr", { Skip_MODRM, Id, Back_Codep, Rq }, 0 }. Well, the main thing I dislike is the decrementing of codep, no matter where it's put. In case you don't think you can get away without, I guess I'll try afterwards, aiming at an incremental change then. Jan