From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C75383858D20 for ; Thu, 28 Sep 2023 14:10:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C75383858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695910231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4ZQ2FIaTyGK+1NfAFLpRAXiWwXb7rzppFyjsHUt+Oo=; b=bS57krogdYQ41zYu5ip0TpO6AHznkO1YnlO7LgJ3LWDgqL0S0bxEnvQfv0yh56fN2MUN8J no4QerOfLg+Y2iJvaB+oFbqP3TvUt9x+W1K1FEjeyqbATkLgJsbQjlvuyVK7VAA8WDsknO b2OQEHK80/Je/sFfr2T28L9kr7igOp4= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-9rHzO5oZMz2UcrenkTZMcQ-1; Thu, 28 Sep 2023 10:10:30 -0400 X-MC-Unique: 9rHzO5oZMz2UcrenkTZMcQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4181f033fa9so111643051cf.1 for ; Thu, 28 Sep 2023 07:10:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695910229; x=1696515029; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O4ZQ2FIaTyGK+1NfAFLpRAXiWwXb7rzppFyjsHUt+Oo=; b=qnR9AmoeRbXUjiu3Co81zvh4LS/phjjfvepCobDmzyyoTL1ArM090smcyhFSJDNjg+ BA+lJe9Z6K2xrHiMuuUVOFOrvIL8EviVdJSFqYHTM4rpJuJkYfOBADYNRlbVxM5rtysx oBRrJK1GEYr+pZYxeV2gQ3t/Zw7ZYyQi4yuMzyT9fUVJ2hfyF1qd6AqtCygc+95TCbMT ah6QyIdgQj8U95OdCSlvgZPoAwnMk1MjD81GKfyhFPxsLKoSHsg95eCE12XxA4lzWu09 f9X5+f1ZqYKtlRpzx/gNLnjg2Lthqqq8FUV2US2yDPI5ScEXjZC5C6J73vVBwPA8QTGc XNIg== X-Gm-Message-State: AOJu0YzP0dgDGSkMTCYk6oOlmfVRB96GE9JsaopfWBq+CoeEgnO+6DM+ ZNmEfIrVo4GMbpjyrB+g0SZPtZ41ETv5t4CkbY5mr0D6e8AxbuDBmU6lw2A16dfC4JwpaCwf5BI wWIGKghOWvHnPLcpW9aSDOwBIDg== X-Received: by 2002:ac8:5c46:0:b0:412:2d22:2aab with SMTP id j6-20020ac85c46000000b004122d222aabmr1703376qtj.53.1695910228880; Thu, 28 Sep 2023 07:10:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGw+l5fefHMo+toASC58H77r6K2aJFN3PmiAw1fYeL2PwPXwvn7+8hZtyPFHPQt+HwDnLdzBA== X-Received: by 2002:ac8:5c46:0:b0:412:2d22:2aab with SMTP id j6-20020ac85c46000000b004122d222aabmr1703340qtj.53.1695910228523; Thu, 28 Sep 2023 07:10:28 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id kc5-20020a05622a44c500b004033c3948f9sm4945008qtb.42.2023.09.28.07.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 07:10:28 -0700 (PDT) Message-ID: <5ca08037-f429-1ef1-adb1-a683a4fb40e6@redhat.com> Date: Thu, 28 Sep 2023 15:10:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Indu Bhagat , binutils@sourceware.org References: <20230920230401.1739139-1-indu.bhagat@oracle.com> <20230920230401.1739139-7-indu.bhagat@oracle.com> From: Nick Clifton Subject: Re: [PATCH, RFC 6/9] gas: dw2gencfi: ignore all .cfi_* directives with --scfi=all In-Reply-To: <20230920230401.1739139-7-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Indu, > @@ -806,6 +806,12 @@ dot_cfi (int arg) > offsetT offset; > unsigned reg1, reg2; > > + if (flag_synth_cfi) > + { > + ignore_rest_of_line (); > + return; > + } > + I am concerned about this behaviour. I understand that mixing synthetic CFI statements and real ones would be a bad idea, but I think that silently ignoring the real ones is a mistake. At the very least you ought to generate a warning message letting the user know that their cfi instructions are being ignored. Cheers Nick