From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id C358F3858D38 for ; Mon, 27 Jan 2025 16:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C358F3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C358F3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737994417; cv=none; b=qpIZybj5rlYA61pRYLcJAlliU72WGfXuVZkKCX9yDqAEb0PMtqgtyb+cjbGjlwXOupA2jEOqKbiqWVDlNnev6nSexxPdp0bB+qc2d9JqzBsfR3qk/o1KJJTZ2Ohtf7WaIC/c9/dRwNTPla1YtbUEOUq2SJ2pk407sHc4Un/SSvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737994417; c=relaxed/simple; bh=XfASDrEa5hDnrdqpD1ncF7HyRbuTITE8vBLViT0oQbk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=DcV0zP68QmDFR5bMyLIYzTZotcJcc8MHdQ19W0DO7zFzfViS6N5iaCG49MRnLkhYYMW6LdcveumLtBGd8TXSORbrDC9j8IyYw9LqB3aL86wH1N7guEJ9BROyjqNg/8m0KCLL3By51kpNhNBxZho6lKhtjzAKFXAmL3meU8cxLhM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C358F3858D38 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=ZyQHobIV Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5dbfab8a2b0so9190722a12.3 for ; Mon, 27 Jan 2025 08:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737994415; x=1738599215; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n8TMxuVodxKvyp53+A1zvcAY8fPptgyg14hEMqgHt8k=; b=ZyQHobIVs6CKYbw/xm8jNB+q0s1H0IXbcxW4HgnLcGwDzTzzuERGjTnYkOFC98ceXe YUlNAFz1/xO3OZyizQVnloT7x3yGpfm5qzPWkpD8U9o8Kzy4u8Swk0Wkj4iTTxRj4VIS DeU3u5M/IL93mrENzh45crijy1+R8k4O1u4DJQmdptCFP/Tct8T2shM7KssE+yPO00iN cFxTkFjx42hEv2GIJOjiVZOtidfL6KVkPZd1vq3eoOKAtvBBWK9++V/tnPt6ITwtfxIG 4jgqm5832OJb6+U+X1uA7+NN8YQegNX5SOOQv9XzUZofP7VMP+KBhBPYsypVmQQkeYa5 2uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737994415; x=1738599215; h=content-transfer-encoding:in-reply-to:autocrypt:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8TMxuVodxKvyp53+A1zvcAY8fPptgyg14hEMqgHt8k=; b=F1GbE7UfKU5hOgA+9icVm1R2RkRcUvyRHKiNkaLsu7b/FuWnrk1sXb/7ctEAN1UyQs wSUe2t3ZGoXxlVqZvrLkYhQtCjdVEZthcdpyCRPxOCzaCxw/mBhqMEm7+UhxB4amT4ZT ZIs5y9McZOXTED9+Dy+E07UnXPpfPKtNM/In4lKYzlRU/nL/6K6a6iHl/t7gXGseZFP3 cJMUSr4w0Pr3C/ODdz4vI07v0X1fan6pt66UXf8lADQmFDDNjVpBmNxS47Kxa0NIh2XZ Yh4fOBdvr3/kCvHwZY/xM2m9aBpI2qZDxXtVnmQj30dhSs1wTLOa3zZB5ZDChADLz99J E2Xw== X-Gm-Message-State: AOJu0Yxl+w+WtnGLuGJMvXbS+VJy6Xd8jBrpn7p3QTNIdzTpl1uCXPu0 YhTXNr50ZUaj9vYDsl/hrq8OTCDyeJv1ZahI71a3jmcF9me7udrur3NRwKn2Q97ynkP0+4CBTnw = X-Gm-Gg: ASbGnct5pzTVBl0+VE/gw/JcqTpEAladU3u7K4QDE2X65r/ubIuF0t5G9vp4JOJpAFv ExuB/ahqz3gv7MeSUeuz6tLKIt/JzLVx+jlMlJXqo1pG38Gz6QFZJVwJikKYGw/yT4HWhriE7jM xa0R8DzKMa5ruOefIKysHnd7atzQNnYd6MCfrMjDC0DGR5g+wA/jL04npIJPL5wf8OWnIwm+hlR RB74iU5HnxGqsfGW0J8yRxG7Mnr4XC4f0csas6BOipJKda5eaNuWQok8il/FFgmBQX8EqxNONBV mMtkQ70fVhzjEWmVNZSPTSBOINg+7NbFGFFxfMW3sKMpuC+HnE8JWEMPVnOx4Tei5Q== X-Google-Smtp-Source: AGHT+IGNAgXLD38mCBx+N6+pL+ugPK5jTe1KZz1OAUmPzc6sJFq0vsXj6Ev4nU2nR6lr5nfwYwsM9A== X-Received: by 2002:a17:907:72ce:b0:aa6:7df0:b17a with SMTP id a640c23a62f3a-ab38b29b08dmr4537839366b.34.1737994415356; Mon, 27 Jan 2025 08:13:35 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e64dc9sm592755466b.45.2025.01.27.08.13.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:13:35 -0800 (PST) Message-ID: <5ca15954-0cfa-4f27-863b-04aa866bfb60@suse.com> Date: Mon, 27 Jan 2025 17:13:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 13/65] C-Sky: use is_whitespace() From: Jan Beulich To: Binutils References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Cc: Lifang Xia , Yunhai Shang Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Wherever blanks are permissible in input, tabs ought to be permissible, too. This is particularly relevant when -f is passed to gas (alongside appropriate input). Also switch ISSPACE() uses over. At the same time use is_end_of_stmt() instead of kind-of-open-coded checks. --- v2: New. --- a/gas/config/tc-csky.c +++ b/gas/config/tc-csky.c @@ -2287,7 +2287,7 @@ parse_exp (char *s, expressionS *e) char *new; /* Skip whitespace. */ - while (ISSPACE (*s)) + while (is_whitespace (*s)) ++s; save = input_line_pointer; @@ -3325,14 +3325,14 @@ parse_opcode (char *str) char macro_name[OPCODE_MAX_LEN + 1]; /* Remove space ahead of string. */ - while (ISSPACE (*str)) + while (is_whitespace (*str)) str++; opcode_end = str; /* Find the opcode end. */ while (nlen < OPCODE_MAX_LEN - && !is_end_of_line [(unsigned char) *opcode_end] - && *opcode_end != ' ') + && !is_end_of_stmt (*opcode_end) + && !is_whitespace (*opcode_end)) { /* Is csky force 32 or 16 instruction? */ if (IS_CSKY_V2 (mach_flag) @@ -3378,7 +3378,7 @@ parse_opcode (char *str) macro_name[nlen] = '\0'; /* Get csky_insn.opcode_end. */ - while (ISSPACE (*opcode_end)) + while (is_whitespace (*opcode_end)) opcode_end++; csky_insn.opcode_end = opcode_end; @@ -4333,13 +4333,13 @@ parse_operands_op (char *str, struct csk for (j = 0; j < csky_insn.number; j++) { - while (ISSPACE (*oper)) + while (is_whitespace (*oper)) oper++; flag_pass = get_operand_value (&op[i], &oper, &op[i].oprnd.oprnds[j]); if (!flag_pass) break; - while (ISSPACE (*oper)) + while (is_whitespace (*oper)) oper++; /* Skip the ','. */ if (j < csky_insn.number - 1 && op[i].operand_num != -1) @@ -4578,7 +4578,7 @@ md_assemble (char *str) mapping_state (MAP_TEXT); /* Tie dwarf2 debug info to every insn if set option --gdwarf2. */ dwarf2_emit_insn (0); - while (ISSPACE (* str)) + while (is_whitespace (* str)) str++; /* Get opcode from str. */ if (!parse_opcode (str)) @@ -5905,7 +5905,7 @@ static int csky_get_macro_operand (char *src_s, char *dst_s, char end_sym) { int nlen = 0; - while (ISSPACE (*src_s)) + while (is_whitespace (*src_s)) ++src_s; while (*src_s != end_sym) dst_s[nlen++] = *(src_s++); @@ -7778,11 +7778,11 @@ csky_s_section (int ignore) pool. */ char * ilp = input_line_pointer; - while (*ilp != 0 && ISSPACE (*ilp)) + while (is_whitespace (*ilp)) ++ ilp; if (startswith (ilp, ".line") - && (ISSPACE (ilp[5]) || *ilp == '\n' || *ilp == '\r')) + && (is_whitespace (ilp[5]) || is_end_of_stmt (ilp[5]))) ; else dump_literals (0);