From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50043.outbound.protection.outlook.com [40.107.5.43]) by sourceware.org (Postfix) with ESMTPS id 2981C3858D32; Tue, 4 Oct 2022 09:59:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2981C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsmGL6JZA8ZEvYAEI3sSuZkOkQK7eZCPPCwxW0tKzOkbx5RPV4tdg7wCEAxAzF+07sBufUKjDIEOfxLiIOhrs6wbVnxK74J3xpuczbbQmYP6wnOwEhTtg6sbJb/W0m/bcun9ZhH1VMgflwGwrmUq8klPgbvxO6DpeQQksOWqUIUwORc1aFbhi57HqRYWMIkwdWc9F2Ksm8gUmCfB6A/b8FdcLull5v3CpMfs2Niy7joGY4eM9yci3Ik11cEapVrx+THHbbQAwR9nIS4bM91+86aanoT8uvnjTmOYdzvPXmwAsfngR7plAi4686z5lvDUMGuwc4c5DvlXi5/d4plHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KKZ+TDv9jqDaDqv8x3fhdV3m8mKePu47sKDEpBZ1PDE=; b=LQR5neh0XjgtnyeFUKqW0Zs/HGUuD4w0CPAg855XXJLCvD8lzey0JqOT7/1cBG0VnB+1oaRAUQA1PFkhkqFdcH5TxqsJFCxJM02yCA7h9fS/pW+WQaef6HZVORInwlKfHeBauOKus8ioQ51ziOc4p7xQG1N7TsmNQW3rsNN1Lxm614I7TCTSr2FIiqMko1LMDjsuIluZVh5xRwwX2Cpa2qg5pioZIEwtNu7D9ko6iTwrENiosKzn98cZwKR+oOAb1wi8rIPAHMGqL3IHFonh0IW54mDVkVN4U7h/4YuSw9UOop+LSLLKTkmVKpPHYYV0/DOSON/cxu8FSmBEMYWnnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KKZ+TDv9jqDaDqv8x3fhdV3m8mKePu47sKDEpBZ1PDE=; b=e6CHdvF53F+d8XNQfkaU+e7mdyy5rOaOShGqfjSzrb4/YQlJT/gXvAOj6txJNpQHC5AgSnbAef4RPyHWVQqKcUrsTytVptrhb/T+b2rkVOhzcdvON2DxrfvXA33KoUWXZfksFPTIkk6lx/i2J2p4Q+rJ2mrDF0f0IM21ejyS4pAX/m5hKDtH+Qq7ZL2L7Zf0QqBSQN3B4tBhnrDAEMGTOpLRvQDcqvEJd1SYmfi8uOMxmPc4JmLiSLV1gJu72sJJ12V99gWwBDwk3FO7+OxilyXYnni3JGaLUg/OKXOoEo6KhQ0caypJws0xD7g78BEaQ1GNIgi8L+cAeQEsUZSPpQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8308.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct 2022 09:59:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 09:59:00 +0000 Message-ID: <5ca714bd-24d6-54c6-bce1-08cb3b77a47a@suse.com> Date: Tue, 4 Oct 2022 11:58:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 1/2] RISC-V: Fix buffer overflow on print_insn_riscv Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, gdb-patches@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess , Andreas Schwab References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8308:EE_ X-MS-Office365-Filtering-Correlation-Id: 5278027a-5a45-4695-7662-08daa5ef0fdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TRq06Apcflqx+FvIJ+0X4IA0phxMYZ9+O9Hg/vCRwDayx0FKkVnIsoFat1vrFXs0fySIoXpgd9lrytDUa+6s9xrphTWx0ixVzCt/0vQuZYdRo/rShKdztF7Jbmc9ypBthBeAJwLAHaP6OTUV8bDnTZsQ7g+vYu5GXlMnb7FIhHuSShMYi/gQZGplq83bFjOy6iq/r2B/kPds7Nu7Tylmo/pa5gB74JxDqjzTvu1EtyNFYX+qnjZlRWNQMsKh6HIWCzhUWa8iIFXZSpnbr4D67MCYn4TwFh3CY+PfJWZzoW+vueM2RnU0mF1j6fk5w/pDMB6iutVTx0Fmr0fAFn/+O4L5A2n+ZNZArXXtu+i78PY0zJChubu0xmdOH0ZSHMV9kIzaf4oilH1IHGoj2pZBPwpRHZ2QxyQxovOoQHHxcHOCVYtOpRuoqyNHdauxhRcnCTiXU/99Q1bBU/pV07MGdYcsRk7ZE0pVLXcFsDSeHW1/Q2kISTjLmOu5LqvLBxLWPXOer9/40c1AQWcfnsK39Fe8dN24sUa+62X14uEhfGjNbzGzKFzxJXDNklktT7ovkxuMScwq3HVhZ3nfnCfpDTG5SpwAimbIHOjgTJLUjjSHbVzZPjTWnuy/+SjMFUyOuEfsMOLtoharZJNVbiHgS8JsGSFCq8RLocuEFPIinU2iny+qU2igWnfTlPRCsXHgc7qbf+nngWqqvLuy4+JDONlUSPPRWzPdL9XAdMaAmcwOwlbPOFJwaIXJWLYze3RiCBVIIpCFEz2cdx0w9IaRz75ooM0nnfx3I31qQyVgt1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199015)(31686004)(2906002)(4744005)(5660300002)(66899015)(41300700001)(8936002)(6916009)(31696002)(36756003)(478600001)(38100700002)(86362001)(8676002)(66476007)(6512007)(54906003)(2616005)(4326008)(66556008)(316002)(53546011)(6506007)(26005)(186003)(6486002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGNaY3FhUS9rSlgxazlEaDdYUHNpcjdvKzQzTWE0TjFZZjVYWnRKQnkvbzl3?= =?utf-8?B?RHozTnV1ZWlQVENqWjNzNzVaQkd3MHRNYnRvSnhGVElUVlRxNmVGS3l3RGYv?= =?utf-8?B?YVlja0VyNlVqNkZmRTAyY1RJM05mNWJuVEh5anNMT3JUQnY1UTZhU2NMRzVD?= =?utf-8?B?aDU1dGVva1FDVnhmWXQ4RFJid3AxKzlsakpYZml2Zi9zVkgzaFMxTEowVGhN?= =?utf-8?B?Zi9wRW5KZk1sNS8zVGVKWEhiQnRheTl2MUhlaDNxUnZuOFh4N1FxUEVOU3gr?= =?utf-8?B?anB3TjF3eG1CQnowRkphVEEvb2J1NUl4QzVzUzZEdnRxd290OXJQOW4zZWRw?= =?utf-8?B?VDdEWUl0ZjRrUDJid0NDUVNkZ3pGY2xVbEhrWDVNVDgwa0pRSG44bjVISzNk?= =?utf-8?B?UC8yQ0hjbjhPUDYxNHpFVDlhZHRhUnM1YVg1TkxjS1MvSXRHOHpiVy9GNG1t?= =?utf-8?B?S1ZjbGxRdVBGUjUySXF0QTlQNEFBeFd1dzd6Tk9PUSt4R2RhZU9zVDR6bmJu?= =?utf-8?B?bHdGdUg0WS9oNUpqQm81bHZ5bjFZc3ZXSU9LS01Yajhqd2JqVUM4dU1wTGZa?= =?utf-8?B?aU1FL2lVQ2hzRWNzUi9LT0ZjRHV4UXRucW9FOU1OMkE1U2hVRnRybjZERkFM?= =?utf-8?B?QkpjZVExa2NmSWpFTVlzTkFSKzZjU0k4cjZjMEtySXZxRlhlRktmbHF0S215?= =?utf-8?B?VjExanVOMGo5cnhzZVpmNEdnUXY0UHZqT2RDZ3NUTFZRNTJuNzdMY1p2N3li?= =?utf-8?B?Vi9sTk1Pb2FnWUZLd3ZPR0FFanpzeUxzTnlkNnp5MDVZaHJOVmtOOWJtTXRL?= =?utf-8?B?OWVWNTRTRDNPR0luOXdZVTU4cnYzbSthRHJIOTREd0prdlBkYnFsMURsNFpm?= =?utf-8?B?K3BoWHg1L2FKTG1La2hQbVNwb0NaV2RKZ3pwNWtvZlYwVEVobVVzY0swL2dr?= =?utf-8?B?UXVubTBWYWNiTHhBcWRYUlJkZ2p6K3VZV1M1UDFXUEppWmtQOHlma2crREZo?= =?utf-8?B?T0NMN09ZRUZLK1dieHlVZ2VneE0xdFRISGNYWHpTeEhRbUlwcVltSjFreWtt?= =?utf-8?B?NlVYUk15RTd0VE5LR1RnL3FrbXd6Sjl0UTlmb1pHV2YrL2VTcWRZU01NZy9j?= =?utf-8?B?RVdTZ1VyckMvU0VlVVVvR056UG9xQS82WWFBRmFMS2FGamJSbElxbithTFJ5?= =?utf-8?B?SGlRWWRWOCsvNitDSmZKQzhlL1Q2TjIyUCtXTUdDTDZVcm5kTjNsWXh5SFVO?= =?utf-8?B?dVBHL3Rzd2piZjAwa3lEYllOSTBHUWZoN21oVmFxcTFHbk9rODQ1cml0QTZw?= =?utf-8?B?MGhqSmtzcWh4YWtqbDJTYndtc1MrZHJlY1h6TWVVSm9IdC84SXN0WFhKM2NZ?= =?utf-8?B?bjYwS2JMVDBPQVZOYzJvT1dHSGVNR2VPVmM1UWc2Sy9pZDdXcVRJcUdSTzFD?= =?utf-8?B?ZWlPVERFUXZKN1JES01YaDBuWS80OXlJeWhNeGpIaHRzdmJyMXZ4WkRMSDNB?= =?utf-8?B?bEp2Uk50ek81cHZoYUxGMCt1ajJ6TUJZVEsrL1VueFpLM0VTV3JzY2NKSmR3?= =?utf-8?B?Si9SQVA0cUVPdTVJVkEvc1Z2Q1M3elNHVXA1TWdQRDg2MVMwQTNHMFJ0anJr?= =?utf-8?B?Um5MUXVUK0NldnEwUFZsSDB1MUVpZytTWnJIcVh6R2Ryc2ZCTjY3aHN2UUps?= =?utf-8?B?bGRZK0xkc3YxMXh4NUhNOU1qWFhYRThHV2xsMXFMZEF5OC81WklUZlIrcHV2?= =?utf-8?B?dmFGWXZTdllmOEl5ZmoxSlhTUVBvaFp0QlRhdk1PSTVON1ZBb3Z1VEx0TTdV?= =?utf-8?B?TnZVZ1E2SWExZTVZaEhBMzFrNkpMSHNCczdxNmhTTWlkM1ZDMkdrd1pKeGpN?= =?utf-8?B?d2ZVKzZJNGY0azl6Y0tRLzVObE96VlBDYkQxYnpwZEdhYTQ0UlRNZmoyaG4v?= =?utf-8?B?bUkvTTVubmV2Q01Eb1NrNzFIZGpuNld1QjArd0RjbTV3c3R2S1p5eVI2R0FC?= =?utf-8?B?UDZpMVZBU0dadVgzNGo5SlZTakM3SW0yM1BvNFRRTTIzbGZsMUEyOStSam9F?= =?utf-8?B?Q3R1cTIwVjNoc3MwWHN4RGZwaEZYWExPbGpxSHRHYy9GOHR4dzc4Nk1yeGxI?= =?utf-8?Q?kvrURJYx87XB1bEKPT9+lBOwh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5278027a-5a45-4695-7662-08daa5ef0fdb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:59:00.8935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AZZZOG4NeJ2VOXXorux2vC0DSovn0zKYhuWFvIVuCsAioN88iu6HX2sY5EZK3UW1i3aB+JLbm+v3a+Ec5gKEuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8308 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.10.2022 11:45, Tsukasa OI wrote: > --- a/include/opcode/riscv.h > +++ b/include/opcode/riscv.h > @@ -55,6 +55,8 @@ static const char * const riscv_pred_succ[16] = > "i", "iw", "ir", "irw", "io", "iow", "ior", "iorw" > }; > > +#define RISCV_MAX_INSN_LEN 22 /* max 176-bit encoding. */ To be honest this still doesn't look sufficient to me: There's still no connection between this constant and riscv_insn_length(). Yet both want changing at the same time when it comes to insn length aspects. As said in reply to v1 - comments may be one way of dealing with this. We don't have BUILD_BUG_ON() or alike (and even if we had it wouldn't be usable in a portable way), so an actual build time check might not be feasible. A runtime check also doesn't look realistic, as gas_assert (riscv_insn_length(~0) == RISCV_MAX_INSN_LEN); wouldn't be correct, and I'm unconvinced of using other than the most simple ~0 as an argument here. Jan