From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2076.outbound.protection.outlook.com [40.107.20.76]) by sourceware.org (Postfix) with ESMTPS id E29C63858D3C for ; Mon, 9 Jan 2023 09:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E29C63858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aAD4F6ojOsKEpfGVQuZWrvMR0sOMW3V+F15SaE2fN+g=; b=e2SdXvy+Q8SeudNzWEZYvCZH/ZPpEVKZx+42vnc6TzFQffzZDyKpNw8qoFu3h18KFNzdTDc7a1i4/x/3M4DB5/nhD3VnmorxWxJz+7HX3SopJAbGOD96ilU2DeDv5PxGDBVN6if2TMN4dU62zeKewVa/F+0vGOepENEGRtvCIDg= Received: from ZR2P278CA0031.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::12) by DBAPR08MB5607.eurprd08.prod.outlook.com (2603:10a6:10:1ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 09:23:09 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:47:cafe::8f) by ZR2P278CA0031.outlook.office365.com (2603:10a6:910:47::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 09:23:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 09:23:08 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Mon, 09 Jan 2023 09:23:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f8d44076f16313d2 X-CR-MTA-TID: 64aa7808 Received: from bc6533e4113e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79E0A5C8-0F9F-46F9-93E3-C54FF507E5D6.1; Mon, 09 Jan 2023 09:23:07 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc6533e4113e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 09:23:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/1e0uCJacweSp1bH67L4BhMZICPgzXD9rbKTJRt47MKywdBJdecWBANTuJy0BIehpw0Z/A2PgzlRf1lTmgYYkoJbF0Q3ok1TiUKmJ9alTc7M7CEW+Gyjd7fIGeYaTgrElN0n/cVaigztwqRJNMkykZDlYkfY2B/Gu49070lcjX85mry45iQwKArc+PjhofV7bmWVCNHjum+i34T1gnXleh0LKtV+MnZB5Y0XsmKq+SEMJhPXuU9r97Y0AHQidQ/9U1CjBdb6AcQEPcSSG7rufpOeIzR6ohb/hrpQEv/9TM+o9rzTwG9XhevPXww1sD+Ju3SA0Rl9+xeepYyxZE0TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aAD4F6ojOsKEpfGVQuZWrvMR0sOMW3V+F15SaE2fN+g=; b=leozxdqCL4L6TgykojeyG8oOg8bRvZXqCL/9gKvd0Szvzr1qTlh+B2wvnjyZHQHvg6jO3fgM0VwPt7+MkT9HupfWjGya00OyDreZnzmRq/bC5mQN+AC9C84rbSVxPZGcc96Ctsa5eNiOIyVPZC5eCVef35CuMloZnBqQdZF12fMRsqKJqxouBooimL22qvfZTI+WRErTST7E9hPqZzaDZWTSFWTrQl0KXAASPSCVb77mO/d0ve3kbO/+n1wx+ezsu6BRGMLrbKDJvJ4ythoIIVX9EHEsYAEGPX+ZO/Ao9cs6vJ4xdi6pgabBRH2JwMMOFkjOj6pSteurmbuWz+lJQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aAD4F6ojOsKEpfGVQuZWrvMR0sOMW3V+F15SaE2fN+g=; b=e2SdXvy+Q8SeudNzWEZYvCZH/ZPpEVKZx+42vnc6TzFQffzZDyKpNw8qoFu3h18KFNzdTDc7a1i4/x/3M4DB5/nhD3VnmorxWxJz+7HX3SopJAbGOD96ilU2DeDv5PxGDBVN6if2TMN4dU62zeKewVa/F+0vGOepENEGRtvCIDg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) by DU0PR08MB9130.eurprd08.prod.outlook.com (2603:10a6:10:474::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 09:22:55 +0000 Received: from VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::d034:a319:3a2a:7897]) by VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::d034:a319:3a2a:7897%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 09:22:54 +0000 Message-ID: <5cacce21-6eb9-fd6e-9497-006b076fb171@arm.com> Date: Mon, 9 Jan 2023 10:22:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/7] Fix size of external_reloc for pe-aarch64 To: Jan Beulich , Mark Harmstone Cc: binutils@sourceware.org, Tamar.Christina@arm.com, nickc@redhat.com, pinskia@gmail.com, Richard.Earnshaw@foss.arm.com, nightstrike@gmail.com, wej22007@outlook.com, zac.walker@linaro.org References: <20230106012509.7918-1-mark@harmstone.com> <42d1673b-bca4-a4ce-daf2-ae4c24ca923e@arm.com> <3fb4611d-46ee-fe35-748c-238b4d71fff8@suse.com> Content-Language: en-US From: Christophe Lyon In-Reply-To: <3fb4611d-46ee-fe35-748c-238b4d71fff8@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR13CA0099.namprd13.prod.outlook.com (2603:10b6:806:24::14) To VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3390:EE_|DU0PR08MB9130:EE_|VI1EUR03FT055:EE_|DBAPR08MB5607:EE_ X-MS-Office365-Filtering-Correlation-Id: 88529070-7531-4af2-354e-08daf2231f39 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VcLQUSMbvqtX8aBWTNq8wIKmzX5QwS1EfDCyW8/sNoBXM5u36EXbIb8n+6TVGTVl99rfefPxRj/bXj0tOaOwVhqDGvLf20ylzF9+sHcLGC9aw96drGqB5uZ22aGINRKJ4Y7Ve2iYzVOeFFZQYnUgLr7Ko2592fhLvQ9oljiT4tAuAPdbScx/uKPzLShf03KRyfKXrslHBsus87/OnUHDDsWPGaA1k7Q3V0Zl2H0dAB02m9TIe1WfLrYWwCVfYvg+ei36Sn9mC7OUPQhQjprjnp+zlzo9aTOaaJmw+fzxkfXeKew3Ot1z8AvHHAD9vPZXZHtqc1SQM6CaW9HldA0XWlQBZnjZSspNq7xPzymVjgQ5hlt40l8PjGLnr94hfLVB+sLaaCkDK3rmRtus3mRfH8wa3LPx2zkaIeHvlc09qGs7IaJAey7hMBGCuudCmvEdtospiCEatDfV5oR3DmMWjIC/7Z1qMAXY7WayvF6dayEsSQGJm2ih0JqRahcQhxsXO5CyqwNHjlGSyLNWlUYJmLOZhegvmIlJOkwYamw+bbEOyzU2mn0AQelVCH72n6mgXiwFEyNrrI/MnmwVmmdjd8biIm3H1fb0lKY8XPHh9P8QyadeMIe2SpRKRJeleEyXyQD1TUsA/A5bFrBbGBliCwNTGpy6oIipO2dbmx3qxtZ7KJ1HEM47IV4ol0owAcjVwu/GuriFAeNR6IWPoiGZY10PMcbbZ77JBu2PYYGZnAw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3390.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(451199015)(38100700002)(31696002)(66476007)(66556008)(66946007)(8676002)(4326008)(86362001)(41300700001)(110136005)(316002)(44832011)(5660300002)(2906002)(8936002)(2616005)(6512007)(83380400001)(6486002)(186003)(6506007)(26005)(478600001)(6666004)(53546011)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9130 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 058cac82-d31e-4892-4eff-08daf2231651 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dO1cjSZvn4AR/AjnAPc1KTR17ygt1qLtCsJhNoKa1Zii/JK2iDFQEn2SOvR7TxGVvIwCHlSatvW8g5jgnIW1nJtzwLRSewot9iJMgnoi3cbAZyxM1xkPlcEFOuWhJXGZAAudvTlcPf0QvKc7yW4ekXrK5pCtPgNQnCPeCN1VVt26veVAbsSBf2pD0bIkUPZS5Cs9Mqj/Zz6vqW0VSLdR7/q/xyo5+iHvmcyGhBwyCQzf629xohhh5NLSXIz888R1YeWn8YaQvlLFlRHIhQo9XYNETYRkFPL7XBsJVtAmCjs4Hr1+/ETemuId3vA8zrDgy0hHM/OtuQAxunymmf1KNBhZo4PjDpV72fTZ7Q+tksPz2E5sy/rUm2sAMQdfWcXHUv0tXhvaHi9gTiK5GkbDfLfY9fPuD7EkaAjt4rTfBtZVViY7h8NCkhSMKUlQKh8pjImKccGDyFabEBsJ1AfxV6kFYH2W1s8fNhOptPz1pOZTWVlEfNC5BtgPizqzsTfo4pPLrhfgIZnimiavJw0tplr71g+ckYNJQVwkf0gV9fSd0CPwxEsnrJ4ius3l02i2ukWZB5VXNqblxoOtOFj3MsUSYADH4ZxbSq8dloahb2Fn2AqAD71LNndf9d709bKgyOEuVEUkYk2PCzbTLU0jkRFYdlBC4452s7RcvOW1MLWWD4tZwlBtLekn9L9ZsNuZOtM8Bff0BlpAQXiSAr2o2Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(376002)(136003)(396003)(346002)(451199015)(36840700001)(46966006)(31686004)(83380400001)(40480700001)(47076005)(44832011)(82310400005)(36860700001)(5660300002)(336012)(2616005)(356005)(6486002)(2906002)(31696002)(86362001)(81166007)(110136005)(8936002)(316002)(6506007)(8676002)(36756003)(186003)(6512007)(4326008)(6666004)(107886003)(478600001)(53546011)(41300700001)(26005)(82740400003)(70586007)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 09:23:08.6872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88529070-7531-4af2-354e-08daf2231f39 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5607 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/9/23 09:11, Jan Beulich wrote: > On 06.01.2023 18:51, Mark Harmstone wrote: >> On 6/1/23 09:47, Christophe Lyon wrote: >>> Hi! >>> >>> I am not a maintainer, but would you mind adding proper commit messages describing what each patch does (or intends to)? >>> >>> Thanks, >>> >>> Christophe >> >> Hi Christophe, >> >> This is a resubmission of a patch set from a few days ago, because of a change that Tamar wanted. If you're interested in the discussion behind each patch, it's available in the mailing list archives. > > I'm afraid pointing to list archives for explanations on patches isn't a good > approach. Once committed, such links will not be easy to (re-)establish. > Other projects are quite a bit more demanding towards the content of commit > messages, but I guess some minimal level of explanation wants to be in the > average binutils patch as well. > That's what I meant I think, thanks for rephrasing :-) I can't find guidelines on how to contribute patches for binutils, but they are similar to GCC's and GDB's. If you just run 'git log' in a binutils clone, you'll see what we mean: in addition to short a summary (title), commit messages include a description of what the commit does and why this is the right change. It's great if all your changes are obvious for Nick, but they are not for others like me ;-) For instance this patch 1/7 only says "Fix size of external_reloc for pe-aarch64", so why is the removal of SWAP_IN_RELOC_OFFSET/SWAP_OUT_RELOC_OFFSET and r_offset needed? I did check the list archives, so if I'm not mistaken this is third iteration of this patch series? (I saw 1/5 and 1/8 in December, then this one in January). The first iteration had an introduction message which led to a discussion with Jan and Tamar, and I think an updated version of that message would help here, when others will have to try to understand these patches in whatever future time ;-) Also as Jan mentioned on your testsuite patches, can you describe why we have to skip so many of them? Jan seems to think that they could be adjusted to cope with both formats intead. Thanks, Christophe > Jan