From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 0446C3858D35 for ; Sat, 1 Jul 2023 13:08:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0446C3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b7f68f1c9eso22055325ad.2 for ; Sat, 01 Jul 2023 06:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688216922; x=1690808922; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AVJMBLPC/NU5oHu0m9I4YV7i66+ZnXZDTrwbWSA4wSI=; b=Rz4FAABz6feYfpsAfM6z2nWuUNSfEAHBzvwVJy/RM/6Ty+lmI2YKfnjS08YVH6rXdA bE/SiweM9g8GKMSk/1GmSk3Q97srP5Uyc4Xo1dP0VYmXtReTL/inaKAUiFO5I3cXnDAH AN2PQxGP0dMhUH5GIw7QI4fzv/v8eu8ivGi2R9WlUq3hEB1qlCl8sw8cFQ3V6rDbsFfy Ser30d8rfjs8XSiKvTG2dSBC3eLfD2N4FEemAUhE7ayy1XW0fW0pm/02mhc773AtA4gT UVv8Yzkgsqzo6cyu0BG8bLDcOMwBqMM9NLA+i//3qEDCTRf4OGik8/l4Cl5T3UeYX5EE y1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688216922; x=1690808922; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AVJMBLPC/NU5oHu0m9I4YV7i66+ZnXZDTrwbWSA4wSI=; b=Hu+ShH+YqcdHek5xcbusl2pN/s8Z6t0SVpFmGKmKipNhzw5X44SIlvIijuH/+mGYBi Xl+OukSkXeujG2o8uW9ZUOyO/dR0zVlTFp2J9SsrUbpXA6pJKW5m3gObHBAEIJTRkrgH MRLIQxDkLJWhZnhGGPMHgxJcyfhOT89ALwwV70ZAVsMCZYMCU7gAET/Fyg8SnyanYzT1 yVBpp61rV1cS2T2bFYpEE5RqDOkkA/AC661WQ3TZ2oqAN8G3REevEYZbnoyAfy7Wy0WU /06s5TnOhS/PaEZzw4BOoLzg7fjqXrE0nZlkMMqH+AiI2q+2RaVkiFhQxn94VDfhuF1F KRyg== X-Gm-Message-State: ABy/qLa9lGFyNAW2XUJfYv9/C9WGUCbOgEjqjmsXZNfaLqdOZTla6Twu JRbJXNMiWbzh4UDchK5l75ovoxu+F34= X-Google-Smtp-Source: APBJJlFJIqn+4O3e9sXoF3GKjTB/qiJ8I+iTLjQaYWMDW5zv1ZJvJogMrsNYKXFxzb/wbqiKoC7pNA== X-Received: by 2002:a17:903:1104:b0:1b5:64a4:be8b with SMTP id n4-20020a170903110400b001b564a4be8bmr6636595plh.35.1688216921773; Sat, 01 Jul 2023 06:08:41 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i3-20020a17090332c300b001b543b4b07esm12293005plr.260.2023.07.01.06.08.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 06:08:41 -0700 (PDT) Message-ID: <5d38feac-80b6-9257-435f-8531aab5f1a4@gmail.com> Date: Sat, 1 Jul 2023 07:08:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 09/14] Allow nested implications for extensions. Content-Language: en-US To: =?UTF-8?Q?Christoph_M=c3=bcllner?= Cc: Nathan Huckleberry , binutils@sourceware.org, nhuck@pmull.org References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-10-nhuck@google.com> <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> <346ebb6d-a65a-214e-2ab9-66844b463b03@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 23:22, Christoph Müllner wrote: > On Sat, Jul 1, 2023 at 12:24 AM Jeff Law wrote: >> >> >> >> On 6/30/23 15:53, Christoph Müllner wrote: >>> On Fri, Jun 30, 2023 at 10:45 PM Jeff Law via Binutils >>> wrote: >>>> >>>> >>>> >>>> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: >>>>> Certain extensions require two levels of implications. For example, >>>>> zvkng implies zvkn and zvkn implies zvkned. Enabling zvkng should also >>>>> enable zvkned. >>>>> >>>>> This patch fixes this behavior. >>>>> >>>>> Signed-off-by: Nathan Huckleberry >>>>> --- >>>>> bfd/elfxx-riscv.c | 16 ++++++++++++++-- >>>>> 1 file changed, 14 insertions(+), 2 deletions(-) >>>> No problem with the actual code. I would suggest a comment explicitly >>>> stating this only allows two levels rather than arbitrary levels of nesting. >>> >>> If I read the resulting code correctly, then arbitrary nesting should >>> be possible. >>> Whenever an implicit subset is found and added, `finished` will be set to false, >>> `t` will be reset to the initial value and the inner loop will terminate. >>> The outer loop will start over because `finished` is false. >>> Do I miss something? >> This is making my brain hurt, too late on a Friday afternoon to think. >> I should just put it under the debugger (the downside of trying to >> review code for a hands-on learner), but I don't have the time right >> now. ISTM there needs to be a worklist of things we've found that we >> then need to scan. >> >> But I'll trust you on this, you're a lot more familiar with this code in >> general than I am. >> >> I wouldn't lose any sleep if you fixed formatting in this code. We're >> supposed to be using GNU style. So the open curley on the IF statement >> should be on its own line, indented twice (which implies the code in the >> TRUE arm ought to be reindented) and the close curley should line up >> with the open curley. > > I tested all patches with check_GNU_style.sh and it only found > what you have commented here. > > Since nobody has pushed this series so far, I have updated the code > and sent out a v6 > which can also be found here: > https://github.com/cmuellner/binutils-gdb/tree/riscv-zvk-v6 Thank you! That'll be so much easier than applying things by hand! Fetching that remote now ;-) jeff