* [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
@ 2017-05-26 13:34 James Clarke
2017-06-06 13:32 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: James Clarke @ 2017-05-26 13:34 UTC (permalink / raw)
To: binutils; +Cc: James Clarke, H.J. Lu
bfd/
PR ld/19579
* elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
8170f7693bc0a9442c0aa280197925db92d48ca6.
---
bfd/elfnn-aarch64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 2ff2120ffb..1edf2a0bde 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -8949,7 +8949,7 @@ elfNN_aarch64_finish_dynamic_symbol (bfd *output_bfd,
}
else if (bfd_link_pic (info) && SYMBOL_REFERENCES_LOCAL (info, h))
{
- if (!h->def_regular)
+ if (!(h->def_regular || ELF_COMMON_DEF_P (h)))
return FALSE;
BFD_ASSERT ((h->got.offset & 1) != 0);
--
2.13.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
2017-05-26 13:34 [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols James Clarke
@ 2017-06-06 13:32 ` Nick Clifton
2017-06-09 9:50 ` James Clarke
0 siblings, 1 reply; 4+ messages in thread
From: Nick Clifton @ 2017-06-06 13:32 UTC (permalink / raw)
To: James Clarke, binutils; +Cc: H.J. Lu
Hi James,
> bfd/
> PR ld/19579
> * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
> ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
> 8170f7693bc0a9442c0aa280197925db92d48ca6.
Approved and applied. Thanks very much for spotting this.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
2017-06-06 13:32 ` Nick Clifton
@ 2017-06-09 9:50 ` James Clarke
2017-06-13 15:00 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: James Clarke @ 2017-06-09 9:50 UTC (permalink / raw)
To: Nick Clifton; +Cc: Binutils, H.J. Lu, Renlin Li
On 6 Jun 2017, at 14:32, Nick Clifton <nickc@redhat.com> wrote:
> Hi James,
>
>> bfd/
>> PR ld/19579
>> * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
>> ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
>> 8170f7693bc0a9442c0aa280197925db92d48ca6.
>
> Approved and applied. Thanks very much for spotting this.
Thanks; could you please backport to the 2.28 branch too?
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
2017-06-09 9:50 ` James Clarke
@ 2017-06-13 15:00 ` Nick Clifton
0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2017-06-13 15:00 UTC (permalink / raw)
To: James Clarke; +Cc: Binutils, H.J. Lu, Renlin Li
Hi James,
>>> PR ld/19579
>>> * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
>>> ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
>>> 8170f7693bc0a9442c0aa280197925db92d48ca6.
>>
>> Approved and applied. Thanks very much for spotting this.
>
> Thanks; could you please backport to the 2.28 branch too?
Done.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-13 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 13:34 [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols James Clarke
2017-06-06 13:32 ` Nick Clifton
2017-06-09 9:50 ` James Clarke
2017-06-13 15:00 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).